On Feb. 11, 2015, 2:13 a.m., Bill Farner wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 630
https://reviews.apache.org/r/30325/diff/4/?file=859286#file859286line630
s/Key//
Done and done.
- Maxim
---
On Feb. 10, 2015, 11:57 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 1609-1618
https://reviews.apache.org/r/30325/diff/4/?file=859288#file859288line1609
s/final//
Done.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Feb. 11, 2015, 11:51 p.m.)
Review request for Aurora, David
On Feb. 10, 2015, 7:28 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 1609-1618
https://reviews.apache.org/r/30325/diff/4/?file=859288#file859288line1609
I don't know how you feel about the need for a Supplier, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Feb. 11, 2015, 11:35 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review72059
---
This patch does not apply cleanly on master (7b531e9), do you need
On Feb. 11, 2015, 11:44 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
lines 1596-1603
https://reviews.apache.org/r/30325/diff/4/?file=859288#file859288line1596
It seems strange that the UPDATE_COORDINATOR can pulse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review72071
---
Ship it!
Master (b8f71fb) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71904
---
Ship it!
api/src/main/thrift/org/apache/aurora/gen/api.thrift
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71840
---
Ship it!
(assuming it rebases cleanly without the need for major
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71730
---
This patch does not apply cleanly on master (68aa285), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Feb. 10, 2015, 12:53 a.m.)
Review request for Aurora, David
On Feb. 3, 2015, 12:16 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1388
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1388
You can check whether the primitive field is set, which will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Feb. 10, 2015, 12:53 a.m.)
Review request for Aurora, David
On Feb. 3, 2015, 12:16 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1535
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535
This is too restrictive. It means that _only_ the update
On Feb. 2, 2015, 4:16 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1535
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535
This is too restrictive. It means that _only_ the update coordinator
On Feb. 2, 2015, 4:16 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1535
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535
This is too restrictive. It means that _only_ the update coordinator
On Feb. 3, 2015, 12:16 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1535
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535
This is too restrictive. It means that _only_ the update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70655
---
On Feb. 3, 2015, 12:16 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1535
https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535
This is too restrictive. It means that _only_ the update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70379
---
Ship it!
Master (4f04a34) is green with this patch.
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126
https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126
Have we considered adding a batch interface, to avoid having to make
multiple RPCs for a
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126
https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126
Have we considered adding a batch interface, to avoid having to make
multiple RPCs for a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70383
---
Ship it!
Ship It!
- David McLaughlin
On Jan. 30, 2015, 5:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Jan. 30, 2015, 5:23 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70377
---
api/src/main/thrift/org/apache/aurora/gen/api.thrift
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Jan. 30, 2015, 5:19 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review69910
---
Master (57a8f4f) is red with this patch.
29 matches
Mail list logo
