thebalu commented on code in PR #161:
URL: https://github.com/apache/bahir-flink/pull/161#discussion_r1062304376
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/KuduFilterInfo.java:
##
@@ -65,7 +65,7 @@ private KuduPredicate
eskabetxe commented on code in PR #161:
URL: https://github.com/apache/bahir-flink/pull/161#discussion_r1062260924
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/KuduFilterInfo.java:
##
@@ -65,7 +65,7 @@ private KuduPredicate
thebalu commented on PR #161:
URL: https://github.com/apache/bahir-flink/pull/161#issuecomment-1371061922
Hi @eskabetxe , could you please take a look and trigger the checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
eskabetxe commented on PR #159:
URL: https://github.com/apache/bahir-flink/pull/159#issuecomment-1322163663
Hi @srmrz ,
Sorry for the delay..
Thanks for your contribution..
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
eskabetxe merged PR #159:
URL: https://github.com/apache/bahir-flink/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
srmrz commented on PR #159:
URL: https://github.com/apache/bahir-flink/pull/159#issuecomment-1316034645
Checking in on this again since it's been a few weeks now, @eskabetxe. I'm
interested in working with the community to land this PR and see this in a
release soon
--
This is an
eskabetxe commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1303843414
Hi @1p4pk ,
Im checking this again, as 1.16 as been release..
I create a sink2 version of the sink but Im getting stuck on same method,
queryCheckpoints is always returning 0
eskabetxe commented on PR #105:
URL: https://github.com/apache/bahir/pull/105#issuecomment-1301907127
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eskabetxe commented on PR #105:
URL: https://github.com/apache/bahir/pull/105#issuecomment-1301888257
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eskabetxe commented on PR #105:
URL: https://github.com/apache/bahir/pull/105#issuecomment-1301827769
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eskabetxe merged PR #106:
URL: https://github.com/apache/bahir/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
srmrz commented on PR #159:
URL: https://github.com/apache/bahir-flink/pull/159#issuecomment-1297210845
Let me know if this can be considered part of
https://issues.apache.org/jira/browse/BAHIR-315 or if should create a separate
ticket.
--
This is an automated message from the Apache
eskabetxe merged PR #160:
URL: https://github.com/apache/bahir-flink/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe merged PR #104:
URL: https://github.com/apache/bahir/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe merged PR #103:
URL: https://github.com/apache/bahir/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #104:
URL: https://github.com/apache/bahir/pull/104
Bumps [akka-actor_2.12](https://github.com/akka/akka) from 2.5.12 to 2.5.16.
Commits
https://github.com/akka/akka/commit/cebcef2cbd3f14ddce8dc29a98443a8a002c488f;>cebcef2
Update
dependabot[bot] opened a new pull request, #105:
URL: https://github.com/apache/bahir/pull/105
Bumps [h2](https://github.com/h2database/h2database) from 1.4.195 to 2.1.210.
Release notes
Sourced from https://github.com/h2database/h2database/releases;>h2's
releases.
Version
dependabot[bot] opened a new pull request, #103:
URL: https://github.com/apache/bahir/pull/103
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
Release notes
Sourced from https://github.com/junit-team/junit4/releases;>junit's
releases.
JUnit 4.13.1
eskabetxe merged PR #102:
URL: https://github.com/apache/bahir/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe merged PR #158:
URL: https://github.com/apache/bahir-flink/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
srmrz opened a new pull request, #159:
URL: https://github.com/apache/bahir-flink/pull/159
When trying to use the recently added support for SSL (#155), we realized
that we needed support for non-cluster mode.
Here we add support for SSL connections in non-cluster configurations.
eskabetxe commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1285862371
hi @amyxzheng currently is not planned any release soon..
we are working to update flink version to 1.15.2, but we have some test
problems..
I could comment on create a new
amyxzheng commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1285810907
hi @eskabetxe when will this change be released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
srmrz closed pull request #156: Bump redis version to 4.2.9
URL: https://github.com/apache/bahir-flink/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
srmrz closed pull request #157: Support ssl
URL: https://github.com/apache/bahir-flink/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1279148269
@netsi don't worry.. thanks for your contribution..
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
eskabetxe merged PR #155:
URL: https://github.com/apache/bahir-flink/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
netsi commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1279096594
@eskabetxe I don't have an apache id. Not even sure how to get one :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
eskabetxe commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1279079647
@netsi thanks for your contribution, once tests pass I will merge this..
do you have an apache id, so I can assign the jira to you?
--
This is an automated message from the
netsi commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995814337
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior()
eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995812847
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void
eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995812847
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void
netsi commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995806100
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior()
eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995791649
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void
srmrz commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r995758210
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
netsi commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r992533025
##
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior()
eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r992514196
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -47,14 +47,7 @@ public
netsi commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1274918726
@amyxzheng I can't answer this question, it is my first contribution
attempt to this project. But there is some info in the README.md
srmrz commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991500442
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
eskabetxe commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991455017
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
eskabetxe commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991455017
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
srmrz commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991403682
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
eskabetxe commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991223392
##
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##
@@ -46,15 +46,7 @@ public
srmrz opened a new pull request, #157:
URL: https://github.com/apache/bahir-flink/pull/157
Follow up of #156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
srmrz opened a new pull request, #156:
URL: https://github.com/apache/bahir-flink/pull/156
Trying to expedite this change
https://github.com/apache/bahir-flink/pull/155
Splitting #155 into two separate changes.
cc @eskabetxe
--
This is an automated message from the
eskabetxe commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1269548662
Hi @netsi, thanks for your contribution..
Could you create a different commit for every change (Jedis update with
changes needed and Add ssl support)
--
This is an automated
amyxzheng commented on PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#issuecomment-1269163164
hi @netsi how does the review process work for the changes in Bahir? We're
trying out this Redis connector and hope to enable SSL
--
This is an automated message from the Apache
1p4pk commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1230209303
Hi @eskabetxe,
sorry for the delay, but yes I spent some time on it and found several
things. Also talked to Arvid Heise about it. In general, your version bump
leads to the
eskabetxe commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1227490199
@1p4pk could you see anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
netsi opened a new pull request, #155:
URL: https://github.com/apache/bahir-flink/pull/155
* updated jedis to 4.2.3
* added support for SSL cluster connections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eskabetxe merged PR #21:
URL: https://github.com/apache/bahir-website/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
anandshah123 opened a new pull request, #154:
URL: https://github.com/apache/bahir-flink/pull/154
Fixes [BAHIR-313](https://issues.apache.org/jira/browse/BAHIR-313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eskabetxe opened a new pull request, #153:
URL: https://github.com/apache/bahir-flink/pull/153
Add license to README.md files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1p4pk commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1192633472
Hi @eskabetxe,
I will take a look this weekend!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eskabetxe merged PR #152:
URL: https://github.com/apache/bahir-flink/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe commented on PR #152:
URL: https://github.com/apache/bahir-flink/pull/152#issuecomment-1186804377
Thanks @collabH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
collabH commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1186801760
> @collabH you can create a PR to this branch..
Ok，link to [fix
kudu](https://github.com/apache/bahir-flink/pull/152#issue-1307446879)
--
This is an automated message from the
eskabetxe commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1186775682
@collabH you can create a PR to this branch..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
collabH commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1186735289
> Failing tests: **influxdb2** @1p4pk could you help? falling test:
InfluxDBSinkIntegrationTestCase.testSinkDataToInfluxDB
>
> **kudu** @collabH could you help here.. on kudu
eskabetxe commented on PR #151:
URL: https://github.com/apache/bahir-flink/pull/151#issuecomment-1186547902
@collabH could you help here..
on kudu, in the KuduDynamicTableSource
@Override
public void applyProjection(int[][] projectedFields) {
// parser
eskabetxe merged PR #127:
URL: https://github.com/apache/bahir-flink/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe commented on PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#issuecomment-1186504861
@collabH merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eskabetxe merged PR #149:
URL: https://github.com/apache/bahir-flink/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
collabH commented on PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#issuecomment-1183087481
@eskabetxe hi,Can this pr be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
collabH commented on code in PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#discussion_r917243261
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/dynamic/KuduDynamicTableSourceSinkFactory.java:
##
@@ -0,0 +1,243 @@
+/*
+ * Licensed to
eskabetxe merged PR #147:
URL: https://github.com/apache/bahir-flink/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe merged PR #150:
URL: https://github.com/apache/bahir-flink/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe commented on PR #147:
URL: https://github.com/apache/bahir-flink/pull/147#issuecomment-1176027681
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eskabetxe commented on PR #150:
URL: https://github.com/apache/bahir-flink/pull/150#issuecomment-1176026142
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #150:
URL: https://github.com/apache/bahir-flink/pull/150#issuecomment-1176025641
Looks like this PR is already up-to-date with master! If you'd still like to
recreate it from scratch, overwriting any edits, you can request `@dependabot
recreate`.
--
This
eskabetxe commented on PR #150:
URL: https://github.com/apache/bahir-flink/pull/150#issuecomment-1176025611
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eskabetxe commented on PR #147:
URL: https://github.com/apache/bahir-flink/pull/147#issuecomment-1176024607
https://github.com/dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
michidk commented on PR #128:
URL: https://github.com/apache/bahir-flink/pull/128#issuecomment-1161916477
Any news on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] opened a new pull request, #150:
URL: https://github.com/apache/bahir-flink/pull/150
Bumps [fastjson](https://github.com/alibaba/fastjson) from 1.2.25 to 1.2.83.
Release notes
Sourced from https://github.com/alibaba/fastjson/releases;>fastjson's
releases.
collabH commented on code in PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#discussion_r895434557
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/format/AbstractKuduInputFormat.java:
##
@@ -42,39 +43,42 @@
/**
* Input format for reading
collabH commented on code in PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#discussion_r895433952
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/writer/RowDataUpsertOperationMapper.java:
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
collabH commented on code in PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#discussion_r895427732
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowDataConvertor.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
eskabetxe commented on code in PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#discussion_r895405774
##
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/convertor/RowResultRowDataConvertor.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to
eskabetxe commented on PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#issuecomment-1144531534
thanks @collabH for your contribution
@mbalassi could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
collabH commented on PR #149:
URL: https://github.com/apache/bahir-flink/pull/149#issuecomment-1131595911
@eskabetxe could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
collabH closed pull request #103: [BAHIR-255]Kudu flink-sql add hash partitions
nums config config
URL: https://github.com/apache/bahir-flink/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
collabH opened a new pull request, #149:
URL: https://github.com/apache/bahir-flink/pull/149
## ISSUE
ISSUE
URL:[ISSUE](https://issues.apache.org/jira/projects/BAHIR/issues/BAHIR-305?filter=allissues)
## feature
* support flink dynamic source/sink factory
* upgrade
eskabetxe merged PR #148:
URL: https://github.com/apache/bahir-flink/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eskabetxe commented on PR #147:
URL: https://github.com/apache/bahir-flink/pull/147#issuecomment-1113710008
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eskabetxe merged PR #132:
URL: https://github.com/apache/bahir-flink/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #147:
URL: https://github.com/apache/bahir-flink/pull/147
Bumps httpclient from 4.5.2 to 4.5.13.
[