[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379284824 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379281125 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379283232 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379283598 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379282521 ## File path:

[GitHub] [helix] pkuwm opened a new issue #764: Add created resource to json response for MSD rest put requests

2020-02-13 Thread GitBox
pkuwm opened a new issue #764: Add created resource to json response for MSD rest put requests URL: https://github.com/apache/helix/issues/764 Current response of MSD REST PUT response returns only status code. As a REST API design principal, a PUT response should include the created

[GitHub] [helix] kaisun2000 opened a new pull request #763: SharedZKClient

2020-02-13 Thread GitBox
kaisun2000 opened a new pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763 ### Issues - [ x ] My PR addresses the following Helix issues and references them in the PR description: Resolve #762 ### Description - [ ] Here are

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379228170 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379218684 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379218365 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379223922 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379227909 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379218026 ## File path:

[GitHub] [helix] kaisun2000 opened a new issue #762: Add RealmAware SharedZkFactory and SharedZkClient (also dedicated counter part) implementation

2020-02-13 Thread GitBox
kaisun2000 opened a new issue #762: Add RealmAware SharedZkFactory and SharedZkClient (also dedicated counter part) implementation URL: https://github.com/apache/helix/issues/762 Implement the functionality to create realm aware dedicated/shared ZKClient using SharedZKClientFactory and

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379219384 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379216863 ## File path:

[GitHub] [helix] narendly merged pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly merged pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379208017 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379208234 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379208465 ## File path:

[GitHub] [helix] pkuwm opened a new pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm opened a new pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Implements #752

[GitHub] [helix] narendly merged pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly merged pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379173108 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379173157 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379150234 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379149852 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379166015 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379164173 ## File path:

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379143730 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379143320 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379142990 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379142874 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379138961 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379135620 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379134999 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379069586 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379133927 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379132737 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379132420 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379131214 ## File path:

[GitHub] [helix] narendly opened a new issue #760: Add RealmAwareZkClient and RealmAwareZkClientFactory

2020-02-13 Thread GitBox
narendly opened a new issue #760: Add RealmAwareZkClient and RealmAwareZkClientFactory URL: https://github.com/apache/helix/issues/760 RealmAwareZkClient and RealmAwareZkClientFactory are going to be the top-level interfaces for other realm-aware ZkClient APIs (think FederatedZkClient,

[GitHub] [helix] pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
pkuwm commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379125110 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r37912 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379123140 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379122606 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379121949 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379121605 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379121334 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory

2020-02-13 Thread GitBox
narendly commented on a change in pull request #757: Add write REST endpoints to helix rest for metadata store directory URL: https://github.com/apache/helix/pull/757#discussion_r379121271 ## File path:

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379109153 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379110626 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379109153 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379107376 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379107200 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379101610 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379099491 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379098852 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] narendly commented on a change in pull request #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
narendly commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379096350 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379087412 ## File path:

[GitHub] [helix] NealSun96 commented on issue #759: Add validation logic to MSD write operations

2020-02-13 Thread GitBox
NealSun96 commented on issue #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#issuecomment-585933576 **To all:** As I attempt to format the relevant files, it turns out that the formatting on my IDE disagrees with some of the existing files

[GitHub] [helix] dasahcc commented on a change in pull request #729: Implement Helix API for updating customized state

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #729: Implement Helix API for updating customized state URL: https://github.com/apache/helix/pull/729#discussion_r379066046 ## File path: helix-core/src/main/java/org/apache/helix/customizedstate/CustomizedStateProviderFactory.java

[GitHub] [helix] dasahcc commented on a change in pull request #729: Implement Helix API for updating customized state

2020-02-13 Thread GitBox
dasahcc commented on a change in pull request #729: Implement Helix API for updating customized state URL: https://github.com/apache/helix/pull/729#discussion_r379066208 ## File path: helix-core/src/main/java/org/apache/helix/customizedstate/CustomizedStateProviderFactory.java

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379065539 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
narendly commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379065061 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces

2020-02-13 Thread GitBox
kaisun2000 commented on a change in pull request #745: Add RealmAwareZkClient and RealmAwareZkClientFactory interfaces URL: https://github.com/apache/helix/pull/745#discussion_r379057281 ## File path:

[GitHub] [helix] NealSun96 opened a new issue #758: Add validation logic to MetadataStoreDirectory write methods

2020-02-13 Thread GitBox
NealSun96 opened a new issue #758: Add validation logic to MetadataStoreDirectory write methods URL: https://github.com/apache/helix/issues/758 The metadata storage routing data stored in Zookeeper is the source of truth for all related services, and therefore, it needs to stay well