[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082869761 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082808508 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] qqu0127 opened a new pull request, #2346: Create adapter package for data and child change listener and prepare zkclient

qqu0127 opened a new pull request, #2346: URL: https://github.com/apache/helix/pull/2346 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: ### Description - [X] Here are some details about my PR, including screenshots

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082753521 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] qqu0127 commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

qqu0127 commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082719864 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] github-actions[bot] commented on issue #2200: [Failed CI Test] testClusterStatusMonitorLifecycle(org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle)

github-actions[bot] commented on issue #2200: URL: https://github.com/apache/helix/issues/2200#issuecomment-1397843546 This test fails in: https://github.com/apache/helix/actions/runs/3963561075 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] helix-bot commented on a diff in pull request #2344: Added new metric to report real time missing top state for partition

helix-bot commented on code in PR #2344: URL: https://github.com/apache/helix/pull/2344#discussion_r1082048214 ## helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java: ## @@ -85,6 +85,9 @@ private void

[GitHub] [helix] xyuanlu commented on a diff in pull request #2344: Added new metric to report real time missing top state for partition

xyuanlu commented on code in PR #2344: URL: https://github.com/apache/helix/pull/2344#discussion_r1082018501 ## helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java: ## @@ -319,12 +322,17 @@ private void

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081995237 ## meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientKeeperException.java: ## @@ -0,0 +1,39 @@ +package org.apache.helix.metaclient.constants;

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081994436 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1081928254 ## helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java: ## @@ -264,6 +268,136 @@ public void testWithClusterConfigChange() {

[GitHub] [helix] xyuanlu merged pull request #2339: Implement data change listener for ZkMetaClient and test

xyuanlu merged PR #2339: URL: https://github.com/apache/helix/pull/2339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081842259 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import

[GitHub] [helix] rahulrane50 opened a new issue, #2345: Add new metric to report real time missing top state for partition

rahulrane50 opened a new issue, #2345: URL: https://github.com/apache/helix/issues/2345 **Is your feature request related to a problem? Please describe.** Issue : Currently, if waged rebalancer is used then there could be a situation where multiple leader replicas are residing on same

[GitHub] [helix] mgao0 commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

mgao0 commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1081708151 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ## @@ -1121,4 +1120,13 @@ public long getPendingStateTransitionGuage() { }

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081709850 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081684126 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081675851 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import

[GitHub] [helix] xyuanlu commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

xyuanlu commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081668733 ## meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientKeeperException.java: ## @@ -0,0 +1,39 @@ +package org.apache.helix.metaclient.constants; +

[GitHub] [helix] qqu0127 commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

qqu0127 commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081649362 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +415,128 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081640082 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +415,128 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081630325 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import

[GitHub] [helix] desaikomal commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

desaikomal commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081522935 ## meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientKeeperException.java: ## @@ -0,0 +1,39 @@ +package org.apache.helix.metaclient.constants;

[GitHub] [helix] qqu0127 commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

qqu0127 commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081444524 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081455964 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] desaikomal commented on pull request #2344: Added new metric to report real time missing top state for partition

desaikomal commented on PR #2344: URL: https://github.com/apache/helix/pull/2344#issuecomment-1397114199 Just a small nit: since we have an ask, you can create an Issue with all the details and then in Issues section, can say, 'Fixes #', -- This is an automated message from the Apache

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081394971 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081355091 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081355091 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] github-actions[bot] commented on issue #2197: [Failed CI Test] testEnqueueJobsThrottle(org.apache.helix.task.TestTaskCreateThrottling)

github-actions[bot] commented on issue #2197: URL: https://github.com/apache/helix/issues/2197#issuecomment-1397026559 This test fails in: https://github.com/apache/helix/actions/runs/3958254947 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] rahulrane50 opened a new pull request, #2344: Added new metric to report real time missing top state for partition

rahulrane50 opened a new pull request, #2344: URL: https://github.com/apache/helix/pull/2344 ### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Adds a new metric to report real time missing top state for any partition for each

[GitHub] [helix] xyuanlu commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

xyuanlu commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1080686941 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] xyuanlu commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

xyuanlu commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1080686322 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1080678210 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java: ## @@ -371,11 +374,12 @@ public void updateStateHandoffStats(MonitorState

[GitHub] [helix] desaikomal commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

desaikomal commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073113630 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java: ## @@ -371,11 +374,12 @@ public void updateStateHandoffStats(MonitorState

[GitHub] [helix] desaikomal commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

desaikomal commented on code in PR #2339: URL: https://github.com/apache/helix/pull/2339#discussion_r1080668742 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -236,6 +239,10 @@ public ConnectState getClientConnectionState() {

[GitHub] [helix] desaikomal commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

desaikomal commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1080665623 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1080617281 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ## @@ -1121,4 +1120,13 @@ public long getPendingStateTransitionGuage() { }

[GitHub] [helix] Marcosrico opened a new pull request, #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico opened a new pull request, #2343: URL: https://github.com/apache/helix/pull/2343 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #2237 ### Description - [ ] Here are some details about my PR,

[GitHub] [helix] qqu0127 commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

qqu0127 commented on code in PR #2339: URL: https://github.com/apache/helix/pull/2339#discussion_r1080604067 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -236,6 +239,10 @@ public ConnectState getClientConnectionState() { @Override

[GitHub] [helix] qqu0127 commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

qqu0127 commented on code in PR #2339: URL: https://github.com/apache/helix/pull/2339#discussion_r1080575451 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -236,6 +239,10 @@ public ConnectState getClientConnectionState() { @Override

[GitHub] [helix] qqu0127 commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

qqu0127 commented on code in PR #2339: URL: https://github.com/apache/helix/pull/2339#discussion_r1080573661 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java: ## @@ -2489,7 +2489,7 @@ public Object call() throws Exception { }); } -

[GitHub] [helix] desaikomal commented on a diff in pull request #2339: Implement data change listener for ZkMetaClient and test

desaikomal commented on code in PR #2339: URL: https://github.com/apache/helix/pull/2339#discussion_r1080545253 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -236,6 +239,10 @@ public ConnectState getClientConnectionState() {

[GitHub] [helix] xyuanlu merged pull request #2335: MetaClient - Implementation of Create from CRUD operations

xyuanlu merged PR #2335: URL: https://github.com/apache/helix/pull/2335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu merged pull request #2336: MetaClient - Op and OpResult Logic for transactional support

xyuanlu merged PR #2336: URL: https://github.com/apache/helix/pull/2336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073975830 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java: ## @@ -128,6 +129,8 @@ public ResourceMonitor(String clusterName, String

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073974174 ## helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java: ## @@ -272,6 +273,128 @@ public void testWithClusterConfigChange() {

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073973004 ## helix-core/src/test/java/org/apache/helix/controller/stages/TestIntermediateStateCalcStage.java: ## @@ -272,6 +273,128 @@ public void testWithClusterConfigChange() {

[GitHub] [helix] rahulrane50 commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

rahulrane50 commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073928319 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java: ## @@ -128,6 +129,8 @@ public ResourceMonitor(String clusterName, String

[GitHub] [helix] qqu0127 commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

qqu0127 commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1073739996 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ## @@ -1121,4 +1120,13 @@ public long getPendingStateTransitionGuage() { }

[GitHub] [helix] github-actions[bot] opened a new issue, #2342: [Failed CI Test] testActivateSuperCluster(org.apache.helix.rest.server.TestClusterAccessor)

github-actions[bot] opened a new issue, #2342: URL: https://github.com/apache/helix/issues/2342 This issue is created for tracking unstable test: testActivateSuperCluster(org.apache.helix.rest.server.TestClusterAccessor) -- This is an automated message from the Apache Git Service. To

[GitHub] [helix] github-actions[bot] commented on issue #2342: [Failed CI Test] testActivateSuperCluster(org.apache.helix.rest.server.TestClusterAccessor)

github-actions[bot] commented on issue #2342: URL: https://github.com/apache/helix/issues/2342#issuecomment-1386374496 This test fails in: https://github.com/apache/helix/actions/runs/3944479122 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072918228 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ## @@ -937,8 +937,7 @@ private void unregisterAllJobs() { } } - //

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072893104 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java: ## @@ -1121,4 +1120,13 @@ public long getPendingStateTransitionGuage() { }

[GitHub] [helix] desaikomal commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

desaikomal commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072870646 ## helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java: ## @@ -421,7 +419,8 @@ private PartitionStateMap

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072869307 ## helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java: ## @@ -467,19 +475,13 @@ public void resetMaxTopStateHandoffGauge() {

[GitHub] [helix] xyuanlu commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

xyuanlu commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072868935 ## helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java: ## @@ -421,7 +419,8 @@ private PartitionStateMap

[GitHub] [helix] desaikomal commented on a diff in pull request #2340: Add metrics for rebalance throttled because of error partition

desaikomal commented on code in PR #2340: URL: https://github.com/apache/helix/pull/2340#discussion_r1072826719 ## helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java: ## @@ -421,7 +419,8 @@ private PartitionStateMap

[GitHub] [helix] Marcosrico commented on pull request #2336: MetaClient - Op and OpResult Logic for transactional support

Marcosrico commented on PR #2336: URL: https://github.com/apache/helix/pull/2336#issuecomment-1386086151 This PR is ready to merge, approved by @qqu0127 Commit message: Metaclient - Op and OpResult Logic for transactional support -- This is an automated message from the Apache Git

[GitHub] [helix] Marcosrico commented on pull request #2336: MetaClient - Op and OpResult Logic for transactional support

Marcosrico commented on PR #2336: URL: https://github.com/apache/helix/pull/2336#issuecomment-1386081904 This PR is ready to merge, approved by @qqu0127 Commit message: Metaclient - Op and OpResult Logic for transactional support -- This is an automated message from the Apache Git

[GitHub] [helix] Marcosrico commented on pull request #2335: MetaClient - Implementation of Create from CRUD operations

Marcosrico commented on PR #2335: URL: https://github.com/apache/helix/pull/2335#issuecomment-1386080645 This PR is ready to merge, approved by @xyuanlu Commit message: Metaclient - Implementation of Create from CRUD operations -- This is an automated message from the Apache Git

[GitHub] [helix] desaikomal commented on pull request #2340: Add metrics for rebalance throttled because of error partition

desaikomal commented on PR #2340: URL: https://github.com/apache/helix/pull/2340#issuecomment-1386053026 > ### Issues > * [x] My PR addresses the following Helix issues and references them in the PR description: > > #2341 > > ### Description > * [x] Here are some

[GitHub] [helix] github-actions[bot] commented on issue #2231: [Failed CI Test] testDeleteJob(org.apache.helix.rest.server.TestJobAccessor)

github-actions[bot] commented on issue #2231: URL: https://github.com/apache/helix/issues/2231#issuecomment-1385470861 This test fails in: https://github.com/apache/helix/actions/runs/3939059875 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2200: [Failed CI Test] testClusterStatusMonitorLifecycle(org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle)

github-actions[bot] commented on issue #2200: URL: https://github.com/apache/helix/issues/2200#issuecomment-1383364288 This test fails in: https://github.com/apache/helix/actions/runs/3926001560 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2188: [Failed CI Test] testPostRequestFormat(org.apache.helix.rest.client.TestCustomRestClient)

github-actions[bot] commented on issue #2188: URL: https://github.com/apache/helix/issues/2188#issuecomment-1383158097 This test fails in: https://github.com/apache/helix/actions/runs/3923312539 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] Marcosrico commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

Marcosrico commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1070467931 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) { }

[GitHub] [helix] xyuanlu opened a new issue, #2341: Add a metrics to show if load balance is throttled because of error partition

xyuanlu opened a new issue, #2341: URL: https://github.com/apache/helix/issues/2341 **Is your feature request related to a problem? Please describe.** Helix users notice there are some resources are not being load balanced. It takes SRE a long time to find out that there are more than

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069889583 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] xyuanlu opened a new pull request, #2340: [WIP - waiting for CI] Add metrics for rebalance throttled because of error partition

xyuanlu opened a new pull request, #2340: URL: https://github.com/apache/helix/pull/2340 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the

[GitHub] [helix] jiajunwang commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

jiajunwang commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069800692 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] jiajunwang commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

jiajunwang commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069800692 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069643019 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1069638754 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 opened a new pull request, #2339: Implement data change listener for ZkMetaClient and test

qqu0127 opened a new pull request, #2339: URL: https://github.com/apache/helix/pull/2339 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: ### Description - [X] Here are some details about my PR, including screenshots

[GitHub] [helix] jiajunwang commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

jiajunwang commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068951156 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] desaikomal commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

desaikomal commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068796629 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) { }

[GitHub] [helix] qqu0127 commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

qqu0127 commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068780318 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) { }

[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

xyuanlu commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068745528 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) { }

[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

xyuanlu commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068745128 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) { }

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068506241 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] Marcosrico commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

Marcosrico commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068491849 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,12 +55,27 @@ public ZkMetaClient(ZkMetaClientConfig config) {

[GitHub] [helix] desaikomal commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

desaikomal commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068471110 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] xyuanlu commented on pull request #2336: MetaClient - Op and OpResult Logic for transactional support

xyuanlu commented on PR #2336: URL: https://github.com/apache/helix/pull/2336#issuecomment-1380791668 Generally looks good. Please add JavaDoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

xyuanlu commented on code in PR #2335: URL: https://github.com/apache/helix/pull/2335#discussion_r1068433562 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,12 +55,27 @@ public ZkMetaClient(ZkMetaClientConfig config) {

[GitHub] [helix] xyuanlu merged pull request #2327: Meta client - implement CRUD for zkMetaClient

xyuanlu merged PR #2327: URL: https://github.com/apache/helix/pull/2327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu commented on a diff in pull request #2327: Meta client - implement CRUD for zkMetaClient

xyuanlu commented on code in PR #2327: URL: https://github.com/apache/helix/pull/2327#discussion_r1068416527 ## meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java: ## @@ -143,7 +152,7 @@ public int getVersion() { * @eturn Return a list of

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068397632 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068396351 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068378381 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068378381 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] desaikomal commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

desaikomal commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068365894 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

Marcosrico commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068357047 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

Marcosrico commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068357047 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068348501 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] qqu0127 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

qqu0127 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1068345686 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* + *

[GitHub] [helix] rahulrane50 commented on a diff in pull request #2338: Implement a thread-safe listener container for zkclient

rahulrane50 commented on code in PR #2338: URL: https://github.com/apache/helix/pull/2338#discussion_r1067611766 ## zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ListenerContainer.java: ## @@ -0,0 +1,186 @@ +package org.apache.helix.zookeeper.zkclient; + +/* +

[GitHub] [helix] Marcosrico closed issue #2240: Adding Transactional Support to Helix Zk Client

Marcosrico closed issue #2240: Adding Transactional Support to Helix Zk Client URL: https://github.com/apache/helix/issues/2240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

  1   2   3   4   5   6   7   8   9   10   >