[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379712887 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379712825 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@ +/*

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379709673 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] jiajunwang opened a new issue #768: Helix rest should be able to handle node request that with no port specified

jiajunwang opened a new issue #768: Helix rest should be able to handle node request that with no port specified URL: https://github.com/apache/helix/issues/768 Got the following error message (changed the hostname for security): PUT

[GitHub] [helix] jiajunwang commented on issue #767: Assignment metadata missing for the WAGED rebalancer in stress test.

jiajunwang commented on issue #767: Assignment metadata missing for the WAGED rebalancer in stress test. URL: https://github.com/apache/helix/issues/767#issuecomment-586540005 @narendly Could you please take a look at this issue? We will need to fix it before we can put Waged rebalancer

[GitHub] [helix] jiajunwang opened a new issue #767: Assignment metadata missing for the WAGED rebalancer in stress test.

jiajunwang opened a new issue #767: Assignment metadata missing for the WAGED rebalancer in stress test. URL: https://github.com/apache/helix/issues/767 Please see the attachment, the baseline node is empty. I observed this multiple times in the stress test.

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379706750 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@ +/*

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379705245 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@ +/*

[GitHub] [helix] mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock

mgao0 commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379704896 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379657934 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379661799 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379661469 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379657006 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379659750 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379660492 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/ZKHelixNonblockingLock.java ## @@ -0,0 +1,186 @@

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379656665 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379657568 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379659585 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379658991 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379657612 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379659291 ## File path: helix-lock/src/main/java/org/apache/helix/lock/helix/HelixLockScope.java ## @@ -0,0 +1,183 @@ +/* + *

[GitHub] [helix] jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock

jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r379657690 ## File path: helix-lock/src/main/java/org/apache/helix/lock/LockInfo.java ## @@ -19,28 +19,162 @@ package

[GitHub] [helix] dasahcc commented on a change in pull request #763: SharedZKClient

dasahcc commented on a change in pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#discussion_r379660611 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java ## @@ -40,6 +40,8 @@

[GitHub] [helix] dasahcc commented on a change in pull request #763: SharedZKClient

dasahcc commented on a change in pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#discussion_r379661309 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java ## @@ -72,6 +72,25 @@ public

[GitHub] [helix] narendly commented on a change in pull request #763: SharedZKClient

narendly commented on a change in pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#discussion_r379660504 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java ## @@ -72,6 +72,25 @@ public

[GitHub] [helix] narendly commented on a change in pull request #763: SharedZKClient

narendly commented on a change in pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#discussion_r379661215 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java ## @@ -170,13 +172,21 @@ public void

[GitHub] [helix] narendly commented on a change in pull request #763: SharedZKClient

narendly commented on a change in pull request #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#discussion_r379660897 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/ZkClient.java ## @@ -90,7 +90,15 @@ public

[GitHub] [helix] narendly commented on issue #763: SharedZKClient

narendly commented on issue #763: SharedZKClient URL: https://github.com/apache/helix/pull/763#issuecomment-586485892 @kaisun2000 Please update the title of the PR. "SharedZkClient" does not conform to the convention. This

[GitHub] [helix] narendly opened a new issue #766: Add DedicatedZkClient and update DedicatedZkClientFactory

narendly opened a new issue #766: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/issues/766 As part of ZkClient API enhancement, we wish to add DedicatedZkClient, which is a wrapper of the raw ZkClient, that provides realm-aware access to

[GitHub] [helix] narendly opened a new pull request #765: WIP: Add DedicatedZkClient and update DedicatedZkClientFactory

narendly opened a new pull request #765: WIP: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379605915 ## File path: helix-rest/src/test/java/org/apache/helix/rest/metadatastore/TestTrieRoutingData.java ##

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379603177 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations

NealSun96 commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379600299 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@

[GitHub] [helix] pkuwm commented on a change in pull request #759: Add validation logic to MSD write operations

pkuwm commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379210892 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java ## @@ -89,49

[GitHub] [helix] pkuwm commented on a change in pull request #759: Add validation logic to MSD write operations

pkuwm commented on a change in pull request #759: Add validation logic to MSD write operations URL: https://github.com/apache/helix/pull/759#discussion_r379213323 ## File path: helix-rest/src/test/java/org/apache/helix/rest/metadatastore/TestTrieRoutingData.java ## @@