[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382936696 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java ## @@ -20,344 +20,486 @@

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382937262 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382938181 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382938689 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382951536 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +pac

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382951622 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java ## @@ -20,344 +20,486 @@ */

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382953941 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382954074 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,310 @@ +

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382954141 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java ## @@ -20,344 +20,486 @@

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955479 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955522 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955507 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955519 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955494 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955531 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-22 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r382955526 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382955910 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +pac

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382955910 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +pac

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382955910 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +pac

[GitHub] [helix] pkuwm commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382956115 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,310 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #789: Add FederatedZkClient

2020-02-22 Thread GitBox
narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382957093 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestFederatedZkClient.java ## @@ -0,0 +1,252 @@ +

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-22 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r382339380 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@ +pack

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-22 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r382956757 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,81 @@ +pack

[GitHub] [helix] pkuwm commented on issue #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-22 Thread GitBox
pkuwm commented on issue #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#issuecomment-590018614 This PR is ready to be merged, approved by @narendly ``` We need restful metadata store directory service to help

[GitHub] [helix] narendly merged pull request #761: Add REST read endpoints to helix-rest for metadata store directory

2020-02-22 Thread GitBox
narendly merged pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] pkuwm opened a new pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm opened a new pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Implements #798

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382965685 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreD

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382965898 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382963776 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDir

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382966026 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/datamodel/Metada

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382968395 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDire

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382968195 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDirect

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382968882 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/Me

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382968763 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/datamodel/MetadataS

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382969417 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDir

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382970187 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreD

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382970849 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382972521 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDire

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-22 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r382972760 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/Me

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-23 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r383023068 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreD

[GitHub] [helix] narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-23 Thread GitBox
narendly commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r383023440 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDir

[GitHub] [helix] pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm

2020-02-23 Thread GitBox
pkuwm commented on a change in pull request #799: [MSDS] Add REST endpoint to get mapping of all sharding keys by realm URL: https://github.com/apache/helix/pull/799#discussion_r383031448 ## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDirect

[GitHub] [helix] pkuwm commented on issue #799: [helix-rest] Add endpoint to get namespace routing data

2020-02-23 Thread GitBox
pkuwm commented on issue #799: [helix-rest] Add endpoint to get namespace routing data URL: https://github.com/apache/helix/pull/799#issuecomment-590107349 This PR is ready to be merged, approved by @narendly ``` RealmAwareZkClient construction needs a REST endpoint to get routin

[GitHub] [helix] narendly merged pull request #799: [helix-rest] Add endpoint to get namespace routing data

2020-02-23 Thread GitBox
narendly merged pull request #799: [helix-rest] Add endpoint to get namespace routing data URL: https://github.com/apache/helix/pull/799 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [helix] pkuwm commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-23 Thread GitBox
pkuwm commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r383095382 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@ -1043,

[GitHub] [helix] narendly closed issue #798: Support getAllRealmKeyMappings Java API and REST endpoint

2020-02-23 Thread GitBox
narendly closed issue #798: Support getAllRealmKeyMappings Java API and REST endpoint URL: https://github.com/apache/helix/issues/798 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [helix] alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection

2020-02-23 Thread GitBox
alirezazamani commented on a change in pull request #741: Fix ConcurrentModification exception in Workflow Garbage Collection URL: https://github.com/apache/helix/pull/741#discussion_r383097458 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-23 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383111853 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383381966 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] zhangmeng916 commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-24 Thread GitBox
zhangmeng916 commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r383388926 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/C

[GitHub] [helix] zhangmeng916 commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-24 Thread GitBox
zhangmeng916 commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r383387141 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/C

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-24 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r383411738 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig

2020-02-24 Thread GitBox
alirezazamani commented on a change in pull request #797: Add REST API to add, remove and update CustomizedStateAggregationConfig URL: https://github.com/apache/helix/pull/797#discussion_r383411873 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383434586 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383434586 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383437586 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383438964 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383441972 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383442678 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383442678 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383449729 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383441972 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383441968 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383443072 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383434413 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383451923 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
pkuwm commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383443072 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +packag

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383457563 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] dasahcc commented on a change in pull request #789: Add FederatedZkClient

2020-02-24 Thread GitBox
dasahcc commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r382294335 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java ##

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383461503 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383461746 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383465912 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383465344 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383456117 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383461639 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383465218 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383466109 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383464970 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383474440 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] narendly commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
narendly commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383465218 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +pac

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383490911 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #775: Add HttpRoutingDataReader URL: https://github.com/apache/helix/pull/775#discussion_r383490911 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java ## @@ -0,0 +1,134 @@ +p

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383498572 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] NealSun96 opened a new issue #800: Make ZkMetadataStoreDirectory singleton

2020-02-24 Thread GitBox
NealSun96 opened a new issue #800: Make ZkMetadataStoreDirectory singleton URL: https://github.com/apache/helix/issues/800 During the leader request forwarding implementation of `ZkRoutingDataWriter`, it is uncovered that with the current implementation, the request will be forwarded indef

[GitHub] [helix] NealSun96 opened a new issue #801: Fix ZkDistributedLeaderElection that causes follower NullPointerException

2020-02-24 Thread GitBox
NealSun96 opened a new issue #801: Fix ZkDistributedLeaderElection that causes follower NullPointerException URL: https://github.com/apache/helix/issues/801 With the current `ZkDistributedLeaderElection` code, if it is created for a follower, `_currentLeaderInfo` will not be correctly init

[GitHub] [helix] NealSun96 commented on issue #788: WIP: Implement request forwarding for ZkRoutingDataWriter

2020-02-24 Thread GitBox
NealSun96 commented on issue #788: WIP: Implement request forwarding for ZkRoutingDataWriter URL: https://github.com/apache/helix/pull/788#issuecomment-590548405 Current state of the PR: missing integration tests for request forwarding, which will be added to `TestMetadataStoreDirectoryAcc

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383554175 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383568511 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383569123 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383573508 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] alirezazamani opened a new issue #802: Temporary remove/disable workflow garbage collection

2020-02-24 Thread GitBox
alirezazamani opened a new issue #802: Temporary remove/disable workflow garbage collection URL: https://github.com/apache/helix/issues/802 In workflow garbage collection, we check whether config existed or not. There is another thread which does cache refresh. In the refresh, we clear the

[GitHub] [helix] alirezazamani opened a new pull request #803: Remove workflow garbage collection

2020-02-24 Thread GitBox
alirezazamani opened a new pull request #803: Remove workflow garbage collection URL: https://github.com/apache/helix/pull/803 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #802. ### Description - [x] Here are some det

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383498572 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383606398 ## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestSharedZkClient.

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383609028 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383609091 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r383612491 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java

[GitHub] [helix] kaisun2000 commented on issue #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 commented on issue #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#issuecomment-590637031 @narendly Test section updated with module. That is a good point. Current pattern of implementation of all public API of

[GitHub] [helix] kaisun2000 edited a comment on issue #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation

2020-02-24 Thread GitBox
kaisun2000 edited a comment on issue #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#issuecomment-590637031 @narendly Test section updated with module. That is a good point. Current pattern of implementation of all public

[GitHub] [helix] kaisun2000 commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

2020-02-24 Thread GitBox
kaisun2000 commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r383617225 ## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.ja

  1   2   3   4   5   6   7   8   9   10   >