[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9097 to look at the new patch set (#2). Change subject: IMPALA-4835: prerequisite buffer pool changes .. IMPALA-4835:

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. Patch Set 5: Code-Review+2 Nice work! -- To view, visit

[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-22 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: > Change has been successfully merged by Lars

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 8: (1 comment) Applied the update.

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#9). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#6). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 8: Code-Review+2 (1 comment) Thanks! I'll merge

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. IMPALA-6418: Find a reliable way

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 6: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#7). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. IMPALA-3998: Remove

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 14: Code-Review+2 Rebased, carrying Tim's +2. --

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Code-Review-2 Still testing

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Rebased to get the workaround

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#14). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. IMPALA-6318: Revert

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 10: This is now ready for review. There might

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Tianyi Wang, Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8900 to look at the new patch set (#6). Change subject: IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 6: Is this ready to merge? -- To view, visit

[Impala-ASF-CR] [DOCS] Doc for MURMUR HASH() function

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: I'll go ahead and merge this unless there are any remaining

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9098 Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. IMPALA-6430: Log relevant debug pages if

[Impala-ASF-CR] PREVIEW: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#9). Change subject: PREVIEW: IMPALA-4835: Part 3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 20: Code-Review+2 carry -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#20). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8523 to look at the new patch set (#8). Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 7: (6 comments) in addition to the comments,

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 13: (5 comments) Thanks for the review. Please see

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-22 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#13). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9097 Change subject: IMPALA-4835: prerequisite buffer pool changes .. IMPALA-4835: prerequisite buffer pool changes The scanner/buffer pool

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 18: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. IMPALA-5654: Disallow setting Kudu

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9096 Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 6: Code-Review+2 Carry +2. -- To

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#6). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#5). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-22 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Dimitris Tsirogiannis, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8958 to look at the new patch set (#2). Change subject: IMPALA-5152: Introduce metadata loading phase

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (39 comments)

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-6394: Enable HDFS debug logging

2018-01-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9082 ) Change subject: IMPALA-6394: Enable HDFS debug logging .. Patch Set 1: I don't really have a sense of how frequent this is. I would

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9072 ) Change subject: IMPALA-3998: Remove refresh_after_connect option from shell .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3998: Remove refresh after connect option from shell

2018-01-22 Thread Tim Armstrong (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9072 to look at the new patch set (#3). Change subject: IMPALA-3998: Remove refresh_after_connect option from shell

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 7: (1 comment) Thank you for the patch! It looks

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 4: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Let's wait for

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-01-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 1: I see that this

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#4). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 7: Code-Review+1 (7 comments) Mostly

[native-toolchain-CR] Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9086 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Patch Set 1: The toolchain job failed because it pulls

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-22 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9079 to look at the new patch set (#6). Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Burkert, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9060 to look at the new patch set (#3). Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions

[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9077 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. IMPALA-6401 : Re-apply the PPC Breakpad patches This change

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 18: Code-Review+2 -- To view,

[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: I ran md5sum on x86 on all binaries with and without the

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Code-Review+1 > Patch Set 2: > > Checked the binary sizes for

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Checked the binary sizes for release builds: Binary size of

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-01-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9090 Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. IMPALA-5903: Inconsistent

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-22 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#8). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 2: Instead of dropping the test,

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. IMPALA-6318: Revert "Adjustment for hanging query

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 6: Code-Review+1 (3 comments) Thanks for

[native-toolchain-CR] IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-22 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9077 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: > Thanks for providing an updated patch. Can

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 17: Again failed on a flaky test (but on a