[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 3: Code-Review+1 LGTM. I can build the orc patch based on this.

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 25: (33 comments)

[Impala-ASF-CR] IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9154 ) Change subject: IMPALA-6008: Creating a UDF from a shared library with a .ll extenion crashes impala .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 10:

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: This should have read: > However, the

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: > (2 comments) > > > Patch Set 1:

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#8). Change subject: IMPALA-6508: add KRPC test flag

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (2 comments) > Patch Set 1: > > (6

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. IMPALA-6519: API to allocate unreserved buffer The

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 10:

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 10:

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-14 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8363 to look at the new patch set (#10). Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9331 ) Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. Patch Set 1: FWIW, this is the error message in question:

[Impala-ASF-CR] IMPALA-6512: Fix test exchange delays for KRPC

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9331 Change subject: IMPALA-6512: Fix test_exchange_delays for KRPC .. IMPALA-6512: Fix test_exchange_delays for KRPC The sender timed out

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#3). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] DRAFT MISSING COMMENTS IMPALA-6520: Add metrics for number of rejected RPCs

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/9320 ) Change subject: DRAFT MISSING COMMENTS IMPALA-6520: Add metrics for number of rejected RPCs .. Abandoned Squashed into IMPALA-6269 -- To view,

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-14 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9292 to look at the new patch set (#5). Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ..

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 5: PS5 exposes metrics for rejected RPCs on /metrics.

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. IMPALA-4953,IMPALA-6437:

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 16: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9250 to look at the new patch set (#5). Change subject: IMPALA-6519: API to allocate unreserved buffer ..

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 5: Code-Review+2 Thanks, I think this makes sense.

[Impala-ASF-CR] DRAFT MISSING COMMENTS IMPALA-6520: Add metrics for number of rejected RPCs

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9320 ) Change subject: DRAFT MISSING COMMENTS IMPALA-6520: Add metrics for number of rejected RPCs .. DRAFT MISSING COMMENTS IMPALA-6520: Add

[Impala-ASF-CR] IMPALA-6520: Add metrics for number of rejected RPCs

2018-02-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9320 Change subject: IMPALA-6520: Add metrics for number of rejected RPCs .. IMPALA-6520: Add metrics for number of rejected RPCs Change-Id:

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 16: Build started:

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 3: It looks like my first issue may be fixed by ORC-266

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 2: Also bumped the version, thanks for letting me know! -- To

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9274 to look at the new patch set (#3). Change subject: PREVIEW: build ORC C++ lib in toolchain .. PREVIEW: build ORC

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 2: It looks like they fixed the issue on master with this commit,

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9274 to look at the new patch set (#2). Change subject: PREVIEW: build ORC C++ lib in toolchain .. PREVIEW: build ORC

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 7: I have uploaded a patch with the template

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: @tarmstrong. oops. sorry, must have picked the wrong

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 16: Build started:

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 16: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option .. Patch Set 5: Is there already a time limit for time spent in the AC queue?

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 15: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9053 to look at the new patch set (#5). Change subject: IMPALA-6416: extend Thread::Create to track instance id

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-14 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#7). Change subject: IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9250 ) Change subject: IMPALA-6519: API to allocate unreserved buffer .. Patch Set 4: @kwho I think you took over my Change-Id for your draft

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-02-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#12). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-02-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 11: (24 comments)

[native-toolchain-CR] PREVIEW: build ORC C++ lib in toolchain

2018-02-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: PREVIEW: build ORC C++ lib in toolchain .. Patch Set 1: Hi Tim, one file (include/orc/Statistics.hh) is not added to

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (14 comments)