[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 5: This change did not cherrypick successfully

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10599 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. IMPALA-6642 (Part 1): Fix the

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10599 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment) Thanks for looking at this,

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10599 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: It looks like test_lineage.py

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10602 Change subject: IMPALA-6956: deflake and logging for query_expiration test .. IMPALA-6956: deflake and logging for query_expiration

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. IMPALA-6947: Kudu tests flaky due to rpc timeout

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. IMPALA-7008: Rewrite query to make it

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10599 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. IMPALA-7106: Print rewritten SQL correctly when

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Hit https://issues.apache.org/jira/browse/IMPALA-7120 -- To

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-04 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10601 to look at the new patch set (#3). Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10599 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Code-Review+2 Seems good to merge,

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (7 comments)

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-04 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10596 to look at the new patch set (#2). Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. Patch Set 2: To be clear, I haven't been able to test

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows .. Patch Set 2: > (1 comment) I pushed to early, updated

[Impala-ASF-CR] IMPALA-7008: Rewrite query to make it not return 100M rows

2018-06-04 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10597 to look at the new patch set (#2). Change subject: IMPALA-7008: Rewrite query to make it not return 100M rows ..

[Impala-ASF-CR] Rewrite an offending query to make it not return 100M rows

2018-06-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10597 ) Change subject: Rewrite an offending query to make it not return 100M rows .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] Rewrite an offending query to make it not return 100M rows

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10597 Change subject: Rewrite an offending query to make it not return 100M rows .. Rewrite an offending query to make it not return 100M rows

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 1: I started a private build to check for

[Impala-ASF-CR] IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 1: I would say there is a chance to slow

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 3: > Patch Set 3: > > (1 comment) >

[Impala-ASF-CR] IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 1: Is there any chance this could slow down

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 3: (1 comment) We currently have

[Impala-ASF-CR] IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-7008/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-06-04 Thread Alan Choi (Code Review)
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/10472 ) Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-04 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 When S3 support was

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-04 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10595 Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 When S3 support was

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 5: Code-Review-1 I'm a -1 on this

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10594 Change subject: Collect hs_err_pid*.log files in logs/ .. Collect hs_err_pid*.log files in logs/ These JVM error dumps are often

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-04 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#5). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Code-Review+1 Looks fine from my end. The python

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-04 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Code-Review+1 Looks good. -- To view, visit

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#5). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-04 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#4). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support

2018-06-04 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 2: Code-Review+1 LGTM -- To view, visit