Fredy Wijaya has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/10571 )

Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is 
enabled
......................................................................

IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

StatementBase::toSql() method is used to print SQL string that is close
to the original SQL string, which is something that users want to see.
When debugging issues related to SQL rewrites, it can be very useful to
be able to print/get the SQL string that is being rewritten. This patch
adds a new method in StatementBase::toRewrittenSql() to get the rewritten
SQL string. The LOG.trace statement that prints the rewritten SQL is also
updated to use StatementBase::toRewrittenSql().

Testing:
- Added FE test for the rewritten SQL string
- Ran all FE tests

Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/StatementBase.java
M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
6 files changed, 100 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10571/5
--
To view, visit http://gerrit.cloudera.org:8080/10571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53
Gerrit-Change-Number: 10571
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>

Reply via email to