Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10571/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@972 PS3, Line 972: .toSql() > - Why is plain toSql() called here, instead of carrying 'rewritten' like in - FromClause does not extend from StatementBase. - You're right about the strange behavior in StmtRewriter. Good catch! The problem is stmt.sqlString_ is set to null even if it's after the last recursion. I fixed the issue by restoring the stmt.sqlString_ at the end of the recursion. -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 00:08:07 +0000 Gerrit-HasComments: Yes
