[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (11 comments)

[native-toolchain-CR] Add support for Ubuntu 18.04

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12286 ) Change subject: Add support for Ubuntu 18.04 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12286/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-8134: update docs for CGroup mem limita

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12293 Change subject: IMPALA-8134: update docs for CGroup mem limita .. IMPALA-8134: update docs for CGroup mem limita Change-Id:

[Impala-ASF-CR] IMPALA-8134: update docs for CGroup mem limits

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12293 ) Change subject: IMPALA-8134: update docs for CGroup mem limits .. IMPALA-8134: update docs for CGroup mem limits Change-Id:

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: I'm currently working on moving forward

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-28 Thread Quanlong Huang (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12292 to review the following change. Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges

[native-toolchain-CR] Fix orc compilation failures in centos 5

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12284 ) Change subject: Fix orc compilation failures in centos 5 .. Patch Set 1: Code-Review+2 I had to do exactly the same thing to get ORC

[native-toolchain-CR] Make unzip less verbose

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12283 ) Change subject: Make unzip less verbose .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12283 To

[native-toolchain-CR] Fix orc compilation failures in centos 5

2019-01-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12284 ) Change subject: Fix orc compilation failures in centos 5 .. Patch Set 1: Hi Hector, could you pasted the compile errors due to

[Impala-ASF-CR] IMPALA-8111: [DOCS] Added KRPC-related known issues

2019-01-28 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12291 Change subject: IMPALA-8111: [DOCS] Added KRPC-related known issues .. IMPALA-8111: [DOCS] Added KRPC-related known issues Change-Id:

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 27: (3 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#27). ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. IMPALA-7970 : Add support for

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 25: (10 comments)

[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 ) Change subject: IMPALA-8093: Profiles prefix counters inconsistently .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12290 ) Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 22: (5 comments) I

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 25: (12 comments)

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC format files

2019-01-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC format files .. Patch Set 10: (1 comment) > Patch Set 9: > > (2

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12290 Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. IMPALA-8101: Thrift 11 and ext-data-source

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 4: Looks good to me! -- To

[native-toolchain-CR] Initial support for building the toolchain in docker

2019-01-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12285 ) Change subject: Initial support for building the toolchain in docker .. Patch Set 1: (16 comments) Thanks! This is a huge

[native-toolchain-CR] Fix orc compilation failures in centos 5

2019-01-28 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12284 ) Change subject: Fix orc compilation failures in centos 5 .. Patch Set 1: We shouldn't be doing anything that requires centos:5?

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. IMPALA-5031: out-of-range enum values

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 3: (2 comments) Addressed

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 3:

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 2:

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12163 to look at the new patch set (#3). Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 2: (2

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-28 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12163 to look at the new patch set (#2). Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

[native-toolchain-CR] Add support for Ubuntu 18.04

2019-01-28 Thread hector.aco...@cloudera.com (Code Review)
Hello Laszlo Gaal, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12286 to look at the new patch set (#2). Change subject: Add support for Ubuntu 18.04 ..

[native-toolchain-CR] Make unzip less verbose

2019-01-28 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12283 ) Change subject: Make unzip less verbose .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12283 To

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

2019-01-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

2019-01-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 1: Code-Review+1 Thanks for jumping

[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 ) Change subject: IMPALA-8093: Profiles prefix counters inconsistently .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

2019-01-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12288 Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. IMPALA-8129: Don't test exact value of

[native-toolchain-CR] Fix orc compilation failures in centos 5

2019-01-28 Thread hector.aco...@cloudera.com (Code Review)
hector.aco...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12284 Change subject: Fix orc compilation failures in centos 5 .. Fix orc compilation failures in centos 5 Change-Id:

[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently

2019-01-28 Thread Anonymous Coward (Code Review)
yc...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12287 Change subject: IMPALA-8093: Profiles prefix counters inconsistently .. IMPALA-8093: Profiles prefix counters inconsistently

[native-toolchain-CR] Add support for Ubuntu 18.04

2019-01-28 Thread hector.aco...@cloudera.com (Code Review)
hector.aco...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12286 Change subject: Add support for Ubuntu 18.04 .. Add support for Ubuntu 18.04 This adds the ubuntu18 docker file + all the

[native-toolchain-CR] Make unzip less verbose

2019-01-28 Thread hector.aco...@cloudera.com (Code Review)
hector.aco...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12283 Change subject: Make unzip less verbose .. Make unzip less verbose extract_archive defaults to only printing errors, this

[native-toolchain-CR] Initial support for building the toolchain in docker

2019-01-28 Thread hector.aco...@cloudera.com (Code Review)
hector.aco...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12285 Change subject: Initial support for building the toolchain in docker .. Initial support for building the toolchain in

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12282 to look at the new patch set (#3). Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC format files

2019-01-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC format files .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12282 to look at the new patch set (#2). Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 ) Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6050: Query profiles should indicate storage layer(s) used

2019-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12282 Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used .. IMPALA-6050: Query profiles should indicate

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12280 ) Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 13: (1 comment)