[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 5: Code-Review+2 Did a build with

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#5). Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 4: Code-Review+2 Added those

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#4). Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15962 ) Change subject: IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc .. IMPALA-9762: Fix GCC7

[Impala-ASF-CR] IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15962 ) Change subject: IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 5: Build Successful

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Revert "IMPALA-9781: Fix GCC 7 unaligned

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-29 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. IMPALA-9749: ASAN builds should not run FE tests.

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-05-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16008 Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 8: Code-Review+2 Rebased. Carrying over

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15926 to look at the new patch set (#8). Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-05-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 4: (4 comments) Needs to be rebased as

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 6: Build Successful

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15962 ) Change subject: IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc .. Patch Set 3: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15962 ) Change subject: IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc .. Patch Set 3: Build started:

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 1: Verified-1 Build

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 7: (1 comment) will rebase in the next

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15926 to look at the new patch set (#7). Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Code-Review+2 Clean revert of my own

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: > Hm, I don't

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15926 to look at the new patch set (#6). Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 5: LGTM once the test is added back --

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16006 Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 3: Code-Review+2 LGTM once you've

[Impala-ASF-CR] IMPALA-9655: Dynamic intra-node load balancing for HDFS scans

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15926 ) Change subject: IMPALA-9655: Dynamic intra-node load balancing for HDFS scans .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: Hm, I don't

[Impala-ASF-CR] IMPALA-9723: Raise error when when Hive Streaming side-file is found

2020-05-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16002 ) Change subject: IMPALA-9723: Raise error when when Hive Streaming side-file is found .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-05-29 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: I'm running a

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16004 Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. IMPALA-9800: Fix undefined

[Impala-ASF-CR] IMPALA-9787: fix spinning thread with memory-based table invalidation

2020-05-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15994 ) Change subject: IMPALA-9787: fix spinning thread with memory-based table invalidation .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ

2020-05-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15958 ) Change subject: IMPALA-9737: fix reservation accounting bug in PHJ .. IMPALA-9737: fix reservation accounting bug in PHJ This

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-9723: Raise error when when Hive Streaming side-file is found

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16002 ) Change subject: IMPALA-9723: Raise error when when Hive Streaming side-file is found .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-9723: Raise error when when Hive Streaming side-file is found

2020-05-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16002 Change subject: IMPALA-9723: Raise error when when Hive Streaming side-file is found .. IMPALA-9723: Raise error when when Hive

[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python

2020-05-29 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 6: Code-Review+2 Rebased across recent changes, the patch

[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python

2020-05-29 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Bump Kudu to 389d4f1e1, fix toolchain Python Pick up the

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-05-29 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16000 to look at the new patch set (#2). Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate()

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 1: Build started:

[Impala-ASF-CR] WIP - IMPALA-9793: Impala quickstart cluster with docker-compose

2020-05-29 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: WIP - IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 6: (14 comments)

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16001 ) Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-9515: Full ACID Milestone 3: Read support for "original files"

2020-05-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16001 Change subject: IMPALA-9515: Full ACID Milestone 3: Read support for "original files" .. IMPALA-9515: Full ACID Milestone 3: Read

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-05-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16000 Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. IMPALA-9632: Implement ds_hll_sketch() and

[Impala-ASF-CR] IMPALA-8860: Improve /log level usability on WebUI

2020-05-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 ) Change subject: IMPALA-8860: Improve /log_level usability on WebUI .. Patch Set 7: Code-Review+1 Tamas, did you have time to look

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Martin Zink (Code Review)
Martin Zink has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and

[Impala-ASF-CR] IMPALA-9737: fix reservation accounting bug in PHJ

2020-05-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15958 ) Change subject: IMPALA-9737: fix reservation accounting bug in PHJ .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates

[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate a

2020-05-29 Thread Martin Zink (Code Review)
Martin Zink has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15877 ) Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and

[Impala-ASF-CR] Bump Kudu to 389d4f1e1, fix toolchain Python

2020-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15845 ) Change subject: Bump Kudu to 389d4f1e1, fix toolchain Python .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc

2020-05-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15962 ) Change subject: IMPALA-9762: Fix GCC7 shift-count-overflow in tuple-row-compare.cc .. Patch Set 2: Code-Review+2 Thanks for