[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 ) Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events .. Patch Set 3:

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Quanlong Huang (Code Review)
Hello k.venureddy2...@gmail.com, Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20707 to look at the new patch set (#3). Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 ) Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events .. Patch Set 2:

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. IMPALA-12565: Fix crash triggered by

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 ) Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events .. Patch Set 2:

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Quanlong Huang (Code Review)
Hello k.venureddy2...@gmail.com, Sai Hemanth Gantasala, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20707 to look at the new patch set (#2). Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-11805: Fix LLVM memory manager bytes allocated

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20697 ) Change subject: IMPALA-11805: Fix LLVM memory manager bytes allocated .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 3: (4 comments) Hi all, I have addressed Quanlong's

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#3). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 10: Patch set 10 add exception about

[Impala-ASF-CR] IMPALA-11805: Fix LLVM memory manager bytes allocated

2023-11-15 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20697 ) Change subject: IMPALA-11805: Fix LLVM memory manager bytes allocated .. Patch Set 9: This particular patch may become redundant with

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#10). Change subject: IMPALA-12018: Consider runtime filter for

[Impala-ASF-CR] IMPALA-11805: Fix LLVM memory manager bytes allocated

2023-11-15 Thread Michael Smith (Code Review)
Hello Yida Wu, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20697 to look at the new patch set (#9). Change subject: IMPALA-11805: Fix LLVM memory manager bytes allocated

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#9). Change subject: IMPALA-12018: Consider runtime filter for

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 8: (10 comments)

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 2: hit IMPALA-12500 -- To view, visit

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set

2023-11-15 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set .. IMPALA-12505: Add

[Impala-ASF-CR] IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set

2023-11-15 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20591 ) Change subject: IMPALA-12505: Add flag for trusted domain check to use 'origin' if xff header is not set .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#8). Change subject: IMPALA-12018: Consider runtime filter for

[Impala-ASF-CR] IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 ) Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 ) Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

2023-11-15 Thread Anonymous Coward (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20710 to look at the new patch set (#2). Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

[Impala-ASF-CR] IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

2023-11-15 Thread Anonymous Coward (Code Review)
gsi...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20710 Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql .. IMPALA-12471: Scripts to run unit

[Impala-ASF-CR] IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 ) Change subject: IMPALA-12471: Scripts to run unit tests of external jdbc tables for mysql .. Patch Set 1: (10 comments)

[Impala-ASF-CR] IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties

2023-11-15 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 ) Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties .. Patch Set 2: Code-Review+2 LGTM!

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11452: Import LLVM SectionMemoryManager for fixes

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20696 ) Change subject: IMPALA-11452: Import LLVM SectionMemoryManager for fixes .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 1: Code-Review+2 Looks good to me. Thanks for

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11452: Import LLVM SectionMemoryManager for fixes

2023-11-15 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20696 to look at the new patch set (#5). Change subject: IMPALA-11452: Import LLVM SectionMemoryManager for fixes

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20709 ) Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20318 ) Change subject: IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust .. Patch Set 7: Verified+1

[Impala-ASF-CR] IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20318 ) Change subject: IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust .. IMPALA-12306:

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 7: (9 comments)

[Impala-ASF-CR] IMPALA-12565: Fix crash triggered by calling pmod() UDF

2023-11-15 Thread ttttttz (Code Review)
ttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20709 Change subject: IMPALA-12565: Fix crash triggered by calling pmod() UDF .. IMPALA-12565: Fix crash triggered by calling pmod() UDF When the

[Impala-ASF-CR] [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

2023-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 ) Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties

2023-11-15 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 ) Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties .. Patch Set 2: Code-Review+1 Thanks,

[Impala-ASF-CR] [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

2023-11-15 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 ) Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time .. Patch Set 5: (5 comments) Thanks

[Impala-ASF-CR] [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 ) Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time .. Patch Set 6: Build

[Impala-ASF-CR] [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

2023-11-15 Thread Zihao Ye (Code Review)
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20681 ) Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time .. Patch Set 4: (1 comment) > There

[Impala-ASF-CR] [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

2023-11-15 Thread Zihao Ye (Code Review)
Hello Wenzhe Zhou, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20681 to look at the new patch set (#6). Change subject: [WIP] IMPALA-12322: Support converting UTC timestamps read from Kudu to local time

[Impala-ASF-CR] IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20318 ) Change subject: IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust .. Patch Set 7: Code-Review+2

[Impala-ASF-CR] IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20318 ) Change subject: IMPALA-12306: (Part 2) Make codegen cache tests with symbol emitter more robust .. Patch Set 7: Build

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20707 ) Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events .. Patch Set 1:

[Impala-ASF-CR] IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events

2023-11-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20707 Change subject: IMPALA-12561: Event-processor shouldn't go into ERROR state for failures in fetching events .. IMPALA-12561: