[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

2023-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 ) Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros

2021-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros

2021-07-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros

2021-07-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 2: (2 comments)

[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17671 ) Change subject: Add 4.0.0 Release notes and change log .. Patch Set 1: I don't understand why the Jenkins job is failing. It's not

[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17672 ) Change subject: Update version to 4.1.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17672

[Impala-ASF-CR](asf-site) Update download links for release 4.0.0

2021-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17669 ) Change subject: Update download links for release 4.0.0 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Upgrading Python cryptography library

2021-05-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10696: fix accuracy problem

2021-05-15 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17411 ) Change subject: IMPALA-10696: fix accuracy problem .. IMPALA-10696: fix accuracy problem Table alltypes has no statistics, so the

[Impala-ASF-CR] Upgrading Python cryptography library

2021-05-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Upgrading Python cryptography library

2021-05-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Upgrading Python cryptography library

2021-05-11 Thread Jim Apple (Code Review)
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17323 to look at the new patch set (#3). Change subject: Upgrading Python cryptography library

[Impala-ASF-CR] Upgrading Python crptography library

2021-05-08 Thread Jim Apple (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17323 to look at the new patch set (#2). Change subject: Upgrading Python crptography library .. Upgrading

[Impala-ASF-CR] IMPALA-9690: Set minimum CPU requirement to AVX2 for x86 64

2021-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17406 ) Change subject: IMPALA-9690: Set minimum CPU requirement to AVX2 for x86_64 .. Patch Set 2: Code-Review+2 (1 comment) There are still

[Impala-ASF-CR] IMPALA-10696: fix accuracy problem

2021-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17411 ) Change subject: IMPALA-10696: fix accuracy problem .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17411

[Impala-ASF-CR] WIP: upgrading some python requirements.

2021-04-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: WIP: upgrading some python requirements. .. Patch Set 1: > Build failed:

[Impala-ASF-CR] WIP: upgrading some python requirements.

2021-04-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17323 Change subject: WIP: upgrading some python requirements. .. WIP: upgrading some python requirements. Just checking to see if removing adls

[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Code-Review+2 Carry +2 (only change is in formatting of commit

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17301 Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web publication

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Hello Quanlong Huang, Shajini Thayasingh, Sahil Takiar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17301 to look at the new patch set (#2). Change subject: Switch to .asf.yaml for site publishing

[Impala-ASF-CR] Upgrade urllib3 to 1.24.2

2021-04-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17270 Change subject: Upgrade urllib3 to 1.24.2 .. Upgrade urllib3 to 1.24.2 Change-Id: Ib18c76e66db2920e7e05a63b5bcd79854b819cd9 --- M

[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04

2021-04-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 3: > > Patch Set 1: Code-Review+2 > > > > Should we

[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04

2021-03-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 1: Code-Review+2 Should we have a "the minicluster

[Impala-ASF-CR] Update Python requests package to 2.20.0

2021-03-27 Thread Jim Apple (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17215 to look at the new patch set (#3). Change subject: Update Python requests package to 2.20.0

[Impala-ASF-CR] Update Python requests package to 2.20.0

2021-03-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 ) Change subject: Update Python requests package to 2.20.0 .. Patch Set 2: Hi, all! This failed with "Could not find a version that

[Impala-ASF-CR] Update Python requests package to 2.20.0

2021-03-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17215 Change subject: Update Python requests package to 2.20.0 .. Update Python requests package to 2.20.0 See

[Impala-ASF-CR] Update Paramiko to 2.4.2.

2021-03-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17214 Change subject: Update Paramiko to 2.4.2. .. Update Paramiko to 2.4.2. See https://www.paramiko.org/changelog.html#2.4.2. This shouldn't

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16751 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: Code-Review+2 Thank you! -- To view, visit

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > for 'why should it be done', no reason, just don't

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > And I think this solution is same with 'changeing for

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > Don't output to the console. Yes, I understand what

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: > Hello Jim, this from askubuntu.com >

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: > Hello, Jim, maybe we change the 'for' loop to 'while

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: I saw these errors, thanks for taking a look! In my

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-07-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: > > Patch Set 1: > > > > Could we just use the-asf.slack.com and

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-07-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Could we just use the-asf.slack.com and create an #impala channel?

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

2020-05-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 ) Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-05-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-05-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter

2020-05-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 8: The Kudu bloom filter here was actually copied

[Impala-ASF-CR] Add link to quickstart container from README

2020-05-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15847 ) Change subject: Add link to quickstart container from README .. Patch Set 1: Hi Tim! Have you taken a look at the discussion on

[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh

2020-02-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 2: > This update is more about testing Gerrit/Jenkins

[Impala-ASF-CR] Add --impalad args to single node perf run.py

2019-12-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Code-Review+2 (1 comment) Fine as-is, but one question you

[Impala-ASF-CR] Fix single node perf run default num impalads

2019-10-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/14383 ) Change subject: Fix single_node_perf_run default num_impalads .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: widen Thrift enum to placate UBSAN

2019-09-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13940 ) Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN .. Patch Set 1: > I'm a bit reluctant about diverging parquet.thrift from

[Impala-ASF-CR] Revert "build: use thin static archives"

2019-08-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 2: What was the rationale for this revert? I don't see a reference

[Impala-ASF-CR] IMPALA-5031: widen Thrift enum to placate UBSAN

2019-07-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13940 Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN .. IMPALA-5031: widen Thrift enum to placate UBSAN This fixes an instance

[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow

2019-07-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13889 Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-07-19 Thread Jim Apple (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13769 to look at the new patch set (#3). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-07-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13769 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-07-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13803 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 2: Code-Review+2 Carry Tim's -- To view, visit

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-07-19 Thread Jim Apple (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13803 to look at the new patch set (#2). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean

[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior

2019-07-04 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13805 Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. IMPALA-5031: out-of-range enum values are undefined

[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior

2019-07-04 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13804 Change subject: IMPALA-5031: Out-of-range enums are undefined behavior .. IMPALA-5031: Out-of-range enums are undefined behavior This

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-07-04 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13803 Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-06-30 Thread Jim Apple (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13769 to look at the new patch set (#2). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2019-06-30 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13769 Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According

[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN

2019-06-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN

2019-06-24 Thread Jim Apple (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#3). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN

[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN

2019-06-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: > Build failed:

[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN

2019-06-22 Thread Jim Apple (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#2). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN

[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN

2019-06-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13710 Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-06-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13437 ) Change subject: IMPALA-5031: signed overflow is undefined behavior .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-06-09 Thread Jim Apple (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13437 to look at the new patch set (#2). Change subject: IMPALA-5031: signed overflow is undefined behavior

[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp

2019-06-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13436 ) Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp

2019-06-01 Thread Jim Apple (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13436 to look at the new patch set (#3). Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp

[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior

2019-05-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13438 ) Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. Patch Set 3: > Build failed:

[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior

2019-05-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13438 ) Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. Patch Set 1: Hi Tim! After this patch is in, the custom

[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior

2019-05-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13438 Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. IMPALA-5031: Out-of-range enum values are undefined

[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp

2019-05-25 Thread Jim Apple (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13436 to look at the new patch set (#2). Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp ..

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-05-25 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13437 Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior Fix remaining

[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp

2019-05-25 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13436 Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. IMPALA-5031: NULL is undefined in memcpy and memcmp This patch

[Impala-ASF-CR] IMPALA-5031: memcpy requires two non-null arguments

2019-05-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13434 Change subject: IMPALA-5031: memcpy requires two non-null arguments .. IMPALA-5031: memcpy requires two non-null arguments

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-05-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13433 Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior This undefined

[Impala-ASF-CR] [DOCS] Removed the enterprise-specific links and versions

2019-05-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13392 ) Change subject: [DOCS] Removed the enterprise-specific links and versions .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8116: [DOCS] A new doc for Impala Scaling Limits

2019-05-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13277 ) Change subject: IMPALA-8116: [DOCS] A new doc for Impala Scaling Limits .. Patch Set 5: (1 comment) Let's keep Impala documentation

[Impala-ASF-CR] Allow running backend tests sharded and in parallel

2019-05-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 ) Change subject: Allow running backend tests sharded and in parallel .. Patch Set 2: (1 comment) Thanks, I'm hopeful this will bring

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 4: > Uploaded patch set 4. This has no benchmark

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-04-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4) to the change originally created by Jim Apple. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. IMPALA-5031: signed overflow

[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh

2019-04-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Jim Apple (Code Review)
Hello Lars Volker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#4). Change subject: Give each config change in bootstrap_system.sh its own line

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Ensure ssh config change is on its own line

2019-03-31 Thread Jim Apple (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#3). Change subject: Ensure ssh config change is on its own line

[Impala-ASF-CR] Ensure ssh config change is on its own line

2019-03-31 Thread Jim Apple (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#2). Change subject: Ensure ssh config change is on its own line

[Impala-ASF-CR] Ensure ssh config change is on its own line

2019-03-31 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12900 Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end

[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04

2019-03-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 ) Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04 .. Patch Set 3: Code-Review+2 (1 comment) Thanks for doing this!

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

2019-03-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: (1 comment)

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: (1 comment)

[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@

2019-03-18 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12779 ) Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Remove company affiliations: concerns of ASF

[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@

2019-03-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12779 Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Remove company affiliations: concerns of ASF trademarks@

[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@

2019-03-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12779 ) Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > > I like the current solution, but I think that it

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > I like the current solution, but I think that it should

  1   2   3   4   >