[Impala-ASF-CR] IMPALA-11450: Support building on Centos 8 alternatives

2022-08-10 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18773 ) Change subject: IMPALA-11450: Support building on Centos 8 alternatives .. Patch Set 1: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change

2022-08-02 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18800 ) Change subject: Update gerrit-auto-critic for a virtualenv API change .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] Update gerrit-auto-critic for a virtualenv API change

2022-07-31 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18800 Change subject: Update gerrit-auto-critic for a virtualenv API change .. Update gerrit-auto-critic for a virtualenv API change

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

2022-07-31 Thread Laszlo Gaal (Cloudera) (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12892 to look at the new patch set (#5). Change subject: Make Docker-based tests available on more hosting OS platforms .

[Impala-ASF-CR] IMPALA-11439: Add option to control whether prepopulate m2 directory or not.

2022-07-23 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18740 ) Change subject: IMPALA-11439: Add option to control whether prepopulate m2 directory or not. .. Patch Set 2: Your concern is

[Impala-ASF-CR] IMPALA-11419: Incremental build is broken

2022-07-11 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18708 ) Change subject: IMPALA-11419: Incremental build is broken .. Patch Set 1: Code-Review+2 (2 comments) There's a suggestion fo

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

2022-07-06 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 ) Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11403: Fix cmake escaping for sed regex in common/thrift

2022-06-28 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18678 Change subject: IMPALA-11403: Fix cmake escaping for sed regex in common/thrift .. IMPALA-11403: Fix cmake escaping for sed reg

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-20 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18630 ) Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload .. IMPALA-10316: Increase Yarn minimum

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-20 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18630 ) Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload .. Patch Set 4: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18630 ) Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload .. Patch Set 4: Code-Review+1 Carry +1 from M

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18630 to look at the new patch set (#4). Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload ..

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18630 to look at the new patch set (#3). Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload ..

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18630 ) Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload .. Patch Set 2: Code-Review+1 Carry +1 from M

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18630 to look at the new patch set (#2). Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload ..

[Impala-ASF-CR] IMPALA-10316: Increase Yarn minimum container size for dataload

2022-06-16 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18630 Change subject: IMPALA-10316: Increase Yarn minimum container size for dataload .. IMPALA-10316: Increase Yarn minimum containe

[Impala-ASF-CR] IMPALA-11249: Fix add test dimensions() locations to call super()

2022-05-25 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18557 ) Change subject: IMPALA-11249: Fix add_test_dimensions() locations to call super() .. Patch Set 2: Code-Review+1 Looks good,

[Impala-ASF-CR] IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes

2022-05-25 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18556 ) Change subject: IMPALA-11317/IMPALA-11316/IMPALA-11315: impala-shell Python 3 fixes .. Patch Set 2: Code-Review+2 LGTM. Make

[native-toolchain-CR] IMPALA-11259: Bump Kudu version to 1.16 release (5cd6779)

2022-04-25 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18437 ) Change subject: IMPALA-11259: Bump Kudu version to 1.16 release (5cd6779) .. Patch Set 4: Code-Review+2 LGTM, thank you for t

[native-toolchain-CR] IMPALA-10699: Patch libev to support C++17

2022-04-21 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18404 ) Change subject: IMPALA-10699: Patch libev to support C++17 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests

2022-04-21 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 ) Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests .. Patch Set 1: Code-Review+2 -- To view, visit

[native-toolchain-CR] IMPALA-11259: Bump Kudu version to 1.16 release (5cd6779)

2022-04-21 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18437 ) Change subject: IMPALA-11259: Bump Kudu version to 1.16 release (5cd6779) .. Patch Set 3: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-11242: Impala cluster doesn't start when building with debug noopt

2022-04-13 Thread Laszlo Gaal (Cloudera) (Code Review)
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18412 ) Change subject: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt .. Patch Set 1: (1 comment) Chang