[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#6). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-14 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#5). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#4). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-06-07 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 3: (22 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. Patch Set 1: (31 comments)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#3). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10415 to look at the new patch set (#2). Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-6035: Add query options to limit thread reservation

2018-05-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 ) Change subject: IMPALA-6035: Add query options to limit thread reservation .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6034: Add Cpu and scanned bytes limits per query

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10415 Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query .. IMPALA-6034: Add Cpu and scanned bytes limits per query

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-05-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 12: (1 comment)

[Impala-ASF-CR] CDH-65183 Update scripts in benchmark folder to store workload and few minor updates

2018-04-24 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 ) Change subject: CDH-65183 Update scripts in benchmark folder to store workload and few minor updates .. Patch Set 5: (4 comments)

[Impala-ASF-CR] Add new queries to targeted-perf workload

2018-04-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: Add new queries to targeted-perf workload .. Patch Set 3: Please add a description to the change describing the high

[Impala-ASF-CR] IMPALA-6792: Fail status reporting if coordinator refuses connections

2018-04-03 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9916 ) Change subject: IMPALA-6792: Fail status reporting if coordinator refuses connections .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-28 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-16 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9661 ) Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. Patch Set 2: Ran small and large payload test cases against

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-16 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9661 ) Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6461 : Micro-optimizations to DataStreamSender::Send

2018-02-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9221 ) Change subject: IMPALA-6461 : Micro-optimizations to DataStreamSender::Send .. Patch Set 8: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6461 : Micro-optimizations to DataStreamSender::Send

2018-02-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9221 ) Change subject: IMPALA-6461 : Micro-optimizations to DataStreamSender::Send .. IMPALA-6461 : Micro-optimizations to

[Impala-ASF-CR] IMPALA-6461 : Micro-optimizations to DataStreamSender::Send

2018-02-21 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9221 ) Change subject: IMPALA-6461 : Micro-optimizations to DataStreamSender::Send .. Patch Set 7: (4 comments)

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-16 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Is it this accumulation limit existed

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 2: Code-Review+1 Validated the the