[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: I did set them - the benchmark complains otherwise. It is a bit

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/92

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: > On my system after: > > With AVX2: > > insert:

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9214 to look at the new patch set (#3). Change subject: Force inlining of BloomFilter::MakeMask .. Force in

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: On my system after: With AVX2: insert:Fun

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: The speedup was pretty significant on the benchmark. On my sys

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: Code-Review+1 Just for sanity checking, did you run bloom-filter-be

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9214/2/be/src/

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9214/2/be/sr

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this function was showi

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9214 Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this function was show