[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. IMPALA-11478: Cleanup JniCatalog This change adds a new class

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 8: Code-Review+2 LGTM. Carry Csaba's +1. Thanks for making this

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 9: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2023-01-02 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#8). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 7: Code-Review+1 (3 comments) I have some more comments on the

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#7). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 6: Code-Review+1 (1 comment) Thanks for making it even more compact!

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-07 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#6). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Code-Review+1 (3 comments) Looks good to me, just some extra

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Code-Review+1 LGTM. Give +1 first if other reviewers also want to

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-12-01 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#5). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 4: (2 comments) The refactor is pretty good! I just have minor

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-22 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-22 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. IMPALA-11478: Cleanup JniCatalog This change adds a new class called JniCatalogOp

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 3: (9 comments) This patch looks pretty good to me!

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-10 Thread Peter Rozsa (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19198 to look at the new patch set (#3). Change subject: IMPALA-11478: Cleanup JniCatalog

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-10 Thread Peter Rozsa (Code Review)
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19198 Change subject: IMPALA-11478: Cleanup JniCatalog .. IMPALA-11478: Cleanup JniCatalog This change adds a new class called JniCatalogOp