[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 10: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 10: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 10: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change add

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 9: I have added py tests -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 9: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 9: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 9: I should have caught this earlier, but can you add a

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13345 To un

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 9: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 8: (1 comment) I think the tests were removed because

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13345/7/b

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 8: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/13345/7/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 7: (2 comments) I think this is looking good for a fir

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 7: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-28 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/13345/6/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/13

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 6: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-23 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-22 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13345/5/b

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/13

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 5: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-21 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds Pro

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-21 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/13345/4/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/133

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13345/4//

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 4: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 3: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/13

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds Pro

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 3: (47 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds Pro

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-17 Thread Harshil (Code Review)
Harshil has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/13345/2

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 2: (13 comments) Some more style nits and I some reque

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. Patch Set 2: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8560: Prometheus metrics support in Impala

2019-05-16 Thread Harshil (Code Review)
Harshil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13345 ) Change subject: IMPALA-8560: Prometheus metrics support in Impala .. IMPALA-8560: Prometheus metrics support in Impala -- This change adds Pro