[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. IMPALA-9902: add rewrite of TPC-DS q38 I generated the

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Code-Review+2 This makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Tim Armstrong (Code Review)
Hello Fang-Yu Rao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16118 to look at the new patch set (#3). Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ..

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-29 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 2: Code-Review+1 (3 comments) Thanks Tim for addressing my

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 2: (3 comments) Thanks for pointing out that I need to update

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-29 Thread Tim Armstrong (Code Review)
Hello Fang-Yu Rao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16118 to look at the new patch set (#2). Change subject: IMPALA-9902: add rewrite of TPC-DS q38 ..

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-28 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 1: Hi Tim, I am answering one of my questions regarding whether to

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-28 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 1: (3 comments) Hi Tim, thanks for this patch! I only have two

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38

2020-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16118 Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. IMPALA-9902: add rewrite of TPC-DS q38 I generated the query with dsqgen and