[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: Code-Review+1 OK, thank you so much! -- To view, visit

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: @Quanlong I sorted out the infra issues. Going forward all

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds the C++

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: Verified+1 Successful build with ID 65-33162f8c3f -- To

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: In the time waiting for the infrastructure issues to be

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 5: I've just been running into some infrastructure issues

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: (3 comments)

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Just getting back to this. I know a lot of people at

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Code-Review+1 Could you please merge this patch? So my

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-27 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: -Code-Review As for tests, there're two executable:

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-27 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Code-Review+1 -- To view, visit

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Running the test suites would be a good idea. I think we

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-21 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: Code-Review+1 Tim, thanks a lot for getting this done.

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 4: This is now tested and ready for review if someone wants

[native-toolchain-CR] IMPALA-5717: Build ORC C++ lib in toolchain

2018-02-20 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9274 to look at the new patch set (#4). Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: