[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11160 to look at the new patch set (#7). Change subject: IMPALA-7412: width_bucket() function overflows too easily ..

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 7: Build Failed https://jenkins.impala

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 7: Build Failed https://jenkins.impala

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 7: Build Failed https://jenkins.impala

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11247 Change subject: IMPALA-7455: Exclude another log4j artifact. .. IMPALA-7455: Exclude another log4j artifact. log4j-1.2-api-2.8.2.jar

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11247 ) Change subject: IMPALA-7455: Exclude another log4j artifact. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11247 ) Change subject: IMPALA-7455: Exclude another log4j artifact. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. Patch Set 2: Code-Review+2 (1 co

[Impala-ASF-CR] IMPALA-5937: [DOCS] Documented ENABLE EXPR REWRITES query option

2018-08-16 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11206 ) Change subject: IMPALA-5937: [DOCS] Documented ENABLE_EXPR_REWRITES query option .. Patch Set 5: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 8: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11247 ) Change subject: IMPALA-7455: Exclude another log4j artifact. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. Patch Set 2: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11229 ) Change subject: IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location .. Patch Set 1: Build started: htt

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 ) Change subject: IMPALA-7096: restore scanner thread memory heuristics .. Patch Set 12: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 ) Change subject: IMPALA-7096: restore scanner thread memory heuristics .. Patch Set 11: Hit a timeout fetching from mvn repo: 23:09:57

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 ) Change subject: IMPALA-7096: restore scanner thread memory heuristics .. Patch Set 12: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 2: Code-Review

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. Patch Set 2: (1 comment) http:/

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. Patch Set 2: Build started: htt

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 2: (1 comment) http:/

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11232 to look at the new patch set (#3). Change subject: IMPALA-7406. Avoid memory overhead of Fla

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: r3 fixes the commen

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 8: Code-Review+2 (1 comment) Carrying +2

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 9: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 9: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 3: Build Suc

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11247 ) Change subject: IMPALA-7455: Exclude another log4j artifact. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7455: Exclude another log4j artifact.

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11247 ) Change subject: IMPALA-7455: Exclude another log4j artifact. .. IMPALA-7455: Exclude another log4j artifact. log4j-1.2

[Impala-ASF-CR] IMPALA-7421. Static methods use wrong JNI call function

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11181 ) Change subject: IMPALA-7421. Static methods use wrong JNI call function .. Patch Set 3: Code-Review+1 (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: Build sta

[Impala-ASF-CR] IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11229 ) Change subject: IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11103 ) Change subject: IMPALA-7096: restore scanner thread memory heuristics .. Patch Set 12: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-7096: restore scanner thread memory heuristics

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11103 ) Change subject: IMPALA-7096: restore scanner thread memory heuristics .. IMPALA-7096: restore scanner thread memory heu

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 1: (2 comments) Great supportability

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
Hello Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11235 to look at the new patch set (#7). Change subject: IMPALA-7399: Remove third-party dependencies from junit

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 7: Code-Review+2 Carrying +2 -- To vi

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Sorry -- forgot to rebase. Carrying

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. IMPALA-7399: Remove third-party dependenci

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 8: Verified+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. Patch Set 9: Verified+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7412: width bucket() function overflows too easily

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11160 ) Change subject: IMPALA-7412: width_bucket() function overflows too easily .. IMPALA-7412: width_bucket() function overf

[Impala-ASF-CR] IMPALA-7399: Remove third-party dependencies from junit xml script

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11235 ) Change subject: IMPALA-7399: Remove third-party dependencies from junit xml script .. Patch Set 7: Build Successful https://

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 1: (3 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. IMPALA-6644: Add last heartbeat timestamp into Sta

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. Patch Set 6: (11 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. Patch Set 6: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#3). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. Patch Set 6: Build Failed https://jenkins

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 2: (1 comment) patch lgtm. Can we add an Fe test (tabl

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 3: Build Successful https://

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11250 Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. IMPALA-7343: Update SentryProxy to use Sentry bulk API Prior t

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-16 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11157 to look at the new patch set (#7). Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit With this patch the mem limit of a query is automatically set based on the mem limit set in the query opt

2018-08-16 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit With this patch the mem_limit of a query is automatically set based on the mem_limit set in the query optio

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: (1 comment) h

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-16 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10771 to look at the new patch set (#5). Change subject: IMPALA-110: Support for multiple DISTINCT

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-16 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 5: (29 comments) I addressed everything except the comment a

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/107

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: Verified+1

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. IMPALA-6644: Add last heartbeat timestamp into Sta

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. Patch Set 7: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 3: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting mem limit

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting mem_limit .. Patch Set 7: Build Failed

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11229 ) Change subject: IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location .. IMPALA-7439. CREATE DATABASE creat

[Impala-ASF-CR] IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11230 ) Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable .. IMPALA-7140 fix: fix NDV calculati

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6644: Add last heartbeat timestamp into Statestore metric

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 ) Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric .. Patch Set 7: Build Failed https://jenkins

[Impala-ASF-CR] IMPALA-7437. LRU caching of partitions in impalad

2018-08-16 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11208 to look at the new patch set (#5). Change subject: IMPALA-7437. LRU caching of partitions in impalad

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11253 Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. IMPALA-7457. statestore: allow filtering by key prefix This add

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-16 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11182 to look at the new patch set (#7). Change subject: IMPALA-7436: initial fetch-from-catalogd implementation ..

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7437. LRU caching of partitions in impalad

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11208 ) Change subject: IMPALA-7437. LRU caching of partitions in impalad .. Patch Set 5: Build Successful https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 1: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. Patch Set 7: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. IMPALA-7343: Update SentryProxy to use Sentry bulk API Prior to

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: Build Successful https://jenkins.impal