[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 15: Code-Review+2 Carry Bharath's +2. -- To

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 5: > (1 comment) Thanks Tim. I had some

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. IMPALA-6521: Show experimental flags in

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. IMPALA-5474: Adding a trivial subquery turns error

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment ids.

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment ids. .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-03 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#16). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 3: Build started:

[Impala-ASF-CR] Added timeout to run-all-tests

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Build started:

[Impala-ASF-CR] Added timeout to run-all-tests

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7446: enable buffer pool GC when near process mem limit

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12133 ) Change subject: IMPALA-7446: enable buffer pool GC when near process mem limit .. IMPALA-7446: enable buffer pool GC when near process

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-03 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#15). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 2: Code-Review+2 (1 comment) > (1 comment) > > My feeling is that it's not

[Impala-ASF-CR] Added timeout to run-all-tests

2019-01-03 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 2: (1 comment) Thanks for doing this, it would be great to get things working

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 2: (1 comment) My feeling is that it's not worth adding the comments - when

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 14: (12 comments)

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 15: Build Successful

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 4: (1 comment) > Please file a bug for

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-03 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-03 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. IMPALA-7970 : Add support for

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-03 Thread Tim Armstrong (Code Review)
Hello Pooja Nilangekar, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12120 to look at the new patch set (#7). Change subject: IMPALA-7941: part 1: detect cgroups memory limit

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 14: Code-Review+2 (8 comments) just a

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 14: Build Successful

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. IMPALA-6521: Patch gflags to

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12152 Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. IMPALA-6521: Show experimental flags in /varz and log

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. IMPALA-6521: Patch

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 5: Verified+1 --

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. IMPALA-6521: Show experimental flags in /varz and log

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-03 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 6: (4 comments) Looks good. I just have a few

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 2: (3 comments) Generally seems good, had

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 4: Right, but the failure is unrelated

[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 ) Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Added timeout to run-all-tests

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Fix some warnings on GCC7 I tried compiling with GCC7 to see what

[Impala-ASF-CR] Fix some warnings on GCC7

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12132 ) Change subject: Fix some warnings on GCC7 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12132

[Impala-ASF-CR] Added timeout to run-all-tests

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Added timeout to run-all-tests Change-Id:

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 14: (7 comments)

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 3: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 4: (5 comments) Thanks for doing this, this

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 4: (3 comments)

[Impala-ASF-CR] [PREVIEW] Unified backend test executable

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: [PREVIEW] Unified backend test executable .. Patch Set 1: (2 comments) Generally seems OK to me

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. IMPALA-6521: Show experimental flags in /varz and log

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6521: Show experimental flags in /varz and log files

2019-01-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12152 ) Change subject: IMPALA-6521: Show experimental flags in /varz and log files .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 15: (8 comments)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. IMPALA-7795: Implement REFRESH AUTHORIZATION statement This