[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. IMPALA-7132: Filter out useless output from run_clang_tidy.sh Clang's run-clang-tidy.py script produces a lot of output even when there are no warnings or errors. None of this output is useful. This patch has two parts: 1. Bump LLVM to 5.0.1-p1, which has patched run-clang-tidy.py to make it reduce its own output when passed -quiet (along with other enhancements). 2. Pass -quiet to run-clang-tidy.py and pipe the stderr output to a temporary file. Display this output only if run-clang-tidy.py hits an error, as this output is not useful otherwise. Testing with a known clang tidy issue shows that warnings and errors are still in the output, and the output is clean on a clean Impala checkout. Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Reviewed-on: http://gerrit.cloudera.org:8080/10615 Reviewed-by: Jim Apple Tested-by: Impala Public Jenkins --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M bin/run_clang_tidy.sh 3 files changed, 14 insertions(+), 6 deletions(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails toSql() method is used to print SQL string that is close to the original SQL string when errors arise or as the result of "SHOW CREATE". When debugging issues related to SQL rewrites, it can be very useful to be able to get the SQL string that is being rewritten. This patch adds a new method toSql(boolean rewritten) to get the rewritten SQL string. This patch also logs the original and rewritten SQL when SQL rewrite fails. Testing: - Added FE test for the rewritten SQL string - Ran all FE tests Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Reviewed-on: http://gerrit.cloudera.org:8080/10571 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/StatementBase.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java M fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java M fe/src/main/java/org/apache/impala/analysis/WithClause.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java 17 files changed, 203 insertions(+), 43 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 24 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. Patch Set 23: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 23 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 04:36:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 17 Jul 2018 04:19:40 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove dead multiple filesystems member from THdfsTable
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10935 ) Change subject: Remove dead multiple_filesystems member from THdfsTable .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2823/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/10935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33197a52e05d0c9647f5ce64a77c59950d9a1b94 Gerrit-Change-Number: 10935 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 03:21:26 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] A typo fix in impala perf stats.xml
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10958 ) Change subject: [DOCS] A typo fix in impala_perf_stats.xml .. [DOCS] A typo fix in impala_perf_stats.xml Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d Reviewed-on: http://gerrit.cloudera.org:8080/10958 Reviewed-by: Alex Rodoni Tested-by: Impala Public Jenkins --- M docs/topics/impala_perf_stats.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Rodoni: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d Gerrit-Change-Number: 10958 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] [DOCS] A typo fix in impala perf stats.xml
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10958 ) Change subject: [DOCS] A typo fix in impala_perf_stats.xml .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/346/ -- To view, visit http://gerrit.cloudera.org:8080/10958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d Gerrit-Change-Number: 10958 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 17 Jul 2018 02:24:28 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] A typo fix in impala perf stats.xml
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10958 ) Change subject: [DOCS] A typo fix in impala_perf_stats.xml .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d Gerrit-Change-Number: 10958 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Comment-Date: Tue, 17 Jul 2018 02:24:07 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] A typo fix in impala perf stats.xml
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10958 Change subject: [DOCS] A typo fix in impala_perf_stats.xml .. [DOCS] A typo fix in impala_perf_stats.xml Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d --- M docs/topics/impala_perf_stats.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/10958/1 -- To view, visit http://gerrit.cloudera.org:8080/10958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2de22e61ce016cb9c1f780bca84a7338482b212d Gerrit-Change-Number: 10958 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. Patch Set 23: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2822/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 23 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 01:34:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. Patch Set 23: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 23 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 01:34:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Fredy Wijaya has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails toSql() method is used to print SQL string that is close to the original SQL string when errors arise or as the result of "SHOW CREATE". When debugging issues related to SQL rewrites, it can be very useful to be able to get the SQL string that is being rewritten. This patch adds a new method toSql(boolean rewritten) to get the rewritten SQL string. This patch also logs the original and rewritten SQL when SQL rewrite fails. Testing: - Added FE test for the rewritten SQL string - Ran all FE tests Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 --- M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java M fe/src/main/java/org/apache/impala/analysis/FromClause.java M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/StatementBase.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/main/java/org/apache/impala/analysis/TableRef.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java M fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java M fe/src/main/java/org/apache/impala/analysis/WithClause.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java 17 files changed, 203 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10571/22 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 22 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 17 Jul 2018 01:12:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2821/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 17 Jul 2018 01:12:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Log the original and rewritten SQL when SQL rewrite fails .. Patch Set 21: Code-Review+2 (2 comments) I'm fine with the patch... thx for working on this. I have two more comment improvement requests so let me know if you have an alternative suggestion. http://gerrit.cloudera.org:8080/#/c/10571/21/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/10571/21/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@136 PS21, Line 136:* rewritten. Otherwise, the original SQL will be returned instead. explicitly state that its the caller's responsibility to know if/when the statement was indeed rewritten. http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/10571/18/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@191 PS18, Line 191: , : boolean rewritten > The original behavior is still the same when calling ctasStmt.toSql(), see ok, pls add a comment for the new param and state that its only for testing (that part was not obvious). -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 21 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 01:06:59 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1760: Implement shutdown command
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 13: Rebased -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 17 Jul 2018 01:04:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1760: Implement shutdown command
Hello Michael Ho, Pranay Singh, Quanlong Huang, Lars Volker, Fredy Wijaya, Todd
Lipcon, Bikramjeet Vig, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10744
to look at the new patch set (#13).
Change subject: IMPALA-1760: Implement shutdown command
..
IMPALA-1760: Implement shutdown command
This allows graceful shutdown of executors and partially graceful
shutdown of coordinators (new operations fail, old operations can
continue).
Details:
* In order to allow future admin commands, this is implemented with
function-like syntax and does not add any reserved words.
* ALL privilege is required on the server
* The coordinator impalad that the client is connected to can be shut
down directly with ":shutdown()".
* Remote shutdown of another impalad is supported, e.g. with
":shutdown('hostname')", so that non-coordinators can be shut down
and for the convenience of the client, which does not have to
connect to the specific impalad. There is no assumption that the
other impalad is registered in the statestore; just that the
coordinator can connect to the other daemon's thrift endpoint.
This simplifies things and allows shutdown in various important
cases, e.g. statestore down.
* The shutdown time limit can be overridden to force a quicker or
slower shutdown by specifying a deadline in seconds after the
statement is executed.
* If shutting down, a banner is shown on the root debug page.
Workflow:
1. (if a coordinator) clients are prevented from submitting
queries to this coordinator via some out-of-band mechanism,
e.g. load balancer
2. the shutdown process is started via ":shutdown()"
3. a bit is set in the statestore and propagated to coordinators,
which stop scheduling fragment instances on this daemon
(if an executor).
4. the quiesce period (which is ideally set to the AC queueing
delay plus some additional leeway) expires
5. once the daemon is drained (i.e. no fragments, no registered
queries), it shuts itself down.
6. If the daemon does not drain (e.g. rogue clients, long-running
queries), after a longer timeout it will shut down anyway.
What this does:
* Executors can be shut down without causing a service-wide outage
* Shutting down an executor will not disrupt any short-running queries
and will wait for long-running queries up to a threshold.
* Coordinators can be shut down without query failures only if
there is an out-of-band mechanism to prevent submission of more
queries to the shut down coordinator. If queries are submitted to
a coordinator after shutdown has started, they will fail.
* Long running queries or other issues (e.g. stuck fragments) will
slow down but not prevent eventual shutdown.
Limitations:
* The quiesce period needs to be configured to be greater than the
latency of statestore updates + scheduling + admission +
coordinator startup. Otherwise a coordinator may send a
fragment instance to the shutting down impalad. (We could
automate this configuration as a follow-on)
* The quiesce period means a minimum latency for shutdown,
even if the cluster is idle.
* We depend on the statestore detecting the process going down
if queries are still running on that backend when the timeout
expires. This may still be subject to existing problems,
e.g. IMPALA-2990.
Tests:
* Added parser, analysis and authorization tests.
* End-to-end test of shutting down impalads.
* End-to-end test of shutting down then restarting an executor while
queries are running.
* End-to-end test of shutting down a coordinator
- New queries cannot be started on coord, existing queries continue to run
- Exercises various Beeswax and HS2 operations.
Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0
---
M be/src/runtime/backend-client.h
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/data-stream-test.cc
M be/src/scheduling/scheduler.cc
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-internal-service.cc
M be/src/service/impala-internal-service.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/testutil/fault-injection-util.h
M be/src/util/default-path-handlers.cc
M common/thrift/Frontend.thrift
M common/thrift/ImpalaInternalService.thrift
M common/thrift/StatestoreService.thrift
M common/thrift/Types.thrift
M common/thrift/generate_error_codes.py
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/LimitElement.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M
[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 11: I really liked the suggestions btw, I think it's getting cleaner. -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 11 Gerrit-Owner: Mostafa Mokhtar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 17 Jul 2018 00:47:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 17 Jul 2018 00:44:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query
Tim Armstrong has uploaded a new patch set (#10) to the change originally created by Mostafa Mokhtar. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. IMPALA-6034: Add CPU and scanned bytes limits per query To protect Impala from runaway queries add per query limits for CPU and scanned bytes, limits are specified via query options CPU_LIMIT_S and SCAN_BYTES_LIMIT and applied to the entire query, not per backend like mem_limit. If a query exceeds any of the limits it is terminated. The checks are periodic so the query may go somewhat over the limits. Query profile is updated to include query wide and per backend metrics for CPU and scanned bytes. Testing: Added tests for various permutations for CPU_LIMIT_S and SCAN_BYTES_LIMIT Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 --- M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift A testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test M tests/query_test/test_cancellation.py M tests/query_test/test_resource_limits.py 14 files changed, 353 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/10415/10 -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 10 Gerrit-Owner: Mostafa Mokhtar Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Remove dead multiple filesystems member from THdfsTable
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10935 ) Change subject: Remove dead multiple_filesystems member from THdfsTable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33197a52e05d0c9647f5ce64a77c59950d9a1b94 Gerrit-Change-Number: 10935 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Tue, 17 Jul 2018 00:36:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/10543/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10543/20//COMMIT_MSG@19 PS20, Line 19: For managed tables it's no longer allowed to drop a partition that : shares it's location with other partitions. In this case an error is : displayed to the user. > what was the previous behavior here? it would drop and remove the files, an The behavior is that Hive would delete the dirs/files (see the discussion in the comments for June 1). We thought that may have been unintentional given the discussion on the related Hive jira so decided to prevent the case when dropping (see June 14 comment). If they do want to drop a such a partition, I'd expect that they point each duplicate to another location-- though it would be useful to try this first and include the workaround in the error message. http://gerrit.cloudera.org:8080/#/c/10543/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10543/18/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1435 PS18, Line 1435: / Only reload file metadata of partitions speci > not really. the code in that patch loops over the partitions to delete, and whoops, indeed, looks like I was looking at the wrong ps. the change in 20 looks fine. there was an earlier question in the review about benchmarking-- have you tried these operations with a table with many partitions to see how much of a slow-down we should expect? http://gerrit.cloudera.org:8080/#/c/10543/20/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10543/20/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1380 PS20, Line 1380: its easier wording: ... that have locations in common with partitions in partitionsToUpdate. -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 20 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 17 Jul 2018 00:30:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2819/ -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 17 Jul 2018 00:19:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2820/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/10862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f2beb5bc027a4bb44e854bf1dd8919807a92ea0 Gerrit-Change-Number: 10862 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 17 Jul 2018 00:10:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh@57 PS3, Line 57: TMP_STDERR=$(mktemp) > When making a temp file, can you rm it on exit? Done, verified it works. -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 17 Jul 2018 00:09:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10615 to look at the new patch set (#4). Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. IMPALA-7132: Filter out useless output from run_clang_tidy.sh Clang's run-clang-tidy.py script produces a lot of output even when there are no warnings or errors. None of this output is useful. This patch has two parts: 1. Bump LLVM to 5.0.1-p1, which has patched run-clang-tidy.py to make it reduce its own output when passed -quiet (along with other enhancements). 2. Pass -quiet to run-clang-tidy.py and pipe the stderr output to a temporary file. Display this output only if run-clang-tidy.py hits an error, as this output is not useful otherwise. Testing with a known clang tidy issue shows that warnings and errors are still in the output, and the output is clean on a clean Impala checkout. Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M bin/run_clang_tidy.sh 3 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/10615/4 -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/10615/3/bin/run_clang_tidy.sh@57 PS3, Line 57: TMP_STDERR=$(mktemp) When making a temp file, can you rm it on exit? http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_12_02.html trap "rm $TMP_STDERR" EXIT -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 16 Jul 2018 23:30:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/10543/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10543/20//COMMIT_MSG@19 PS20, Line 19: For managed tables it's no longer allowed to drop a partition that : shares it's location with other partitions. In this case an error is : displayed to the user. what was the previous behavior here? it would drop and remove the files, and then the user would need to invalidate/refresh to ensure that the other partition starts reflecting the change instead of giving FileNotFoundErrors? If the user ends up in a state with multiple partitions at the same location, what's the recommended way to resolve it? First alter one partition to point somewhere else? -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 20 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Jul 2018 23:29:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/10862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f2beb5bc027a4bb44e854bf1dd8919807a92ea0 Gerrit-Change-Number: 10862 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Jul 2018 23:17:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database
Hello Michael Brown, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10862 to look at the new patch set (#2). Change subject: IMPALA-7238: Use custom timeout for create unique database .. IMPALA-7238: Use custom timeout for create unique database test_kudu.TestCreateExternalTables() saw a timeout when creating the unique database for its tests. __unique_conn() opens a connection, creates a unique database, then returns another connection in that database. It takes a custom timeout argument, but the timeout is only for the returned connection. The first connection to create the unique database uses the default timeout of 45 seconds. This patch changes the first connection to use the custom timeout. For Kudu tests, this is 5 minutes rather than 45 seconds. Change-Id: I4f2beb5bc027a4bb44e854bf1dd8919807a92ea0 --- M tests/conftest.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/10862/2 -- To view, visit http://gerrit.cloudera.org:8080/10862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f2beb5bc027a4bb44e854bf1dd8919807a92ea0 Gerrit-Change-Number: 10862 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10862/1/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/10862/1/tests/conftest.py@359 PS1, Line 359: db_name=db_name > Missing timeout=timeout here as well. Done -- To view, visit http://gerrit.cloudera.org:8080/10862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f2beb5bc027a4bb44e854bf1dd8919807a92ea0 Gerrit-Change-Number: 10862 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Jul 2018 23:16:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2819/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 16 Jul 2018 23:09:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/10615 )
Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10615/2/bin/run_clang_tidy.sh
File bin/run_clang_tidy.sh:
http://gerrit.cloudera.org:8080/#/c/10615/2/bin/run_clang_tidy.sh@57
PS2, Line 57: run-clang-tidy.py -quiet -header-filter "${PIPE_DIRS%?}"
-j"${CORES}" ${DIRS} 2> /dev/null
> What if something catastrophically bad happens with the script that is orth
Good idea, changed this to write stderr to a tempfile and only output it on
error. I tested it by adding an invalid import to run-clang-tidy.py and
verifying that it outputs the error.
--
To view, visit http://gerrit.cloudera.org:8080/10615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d
Gerrit-Change-Number: 10615
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Mon, 16 Jul 2018 23:09:14 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10615 to look at the new patch set (#3). Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. IMPALA-7132: Filter out useless output from run_clang_tidy.sh Clang's run-clang-tidy.py script produces a lot of output even when there are no warnings or errors. None of this output is useful. This patch has two parts: 1. Bump LLVM to 5.0.1-p1, which has patched run-clang-tidy.py to make it reduce its own output when passed -quiet (along with other enhancements). 2. Pass -quiet to run-clang-tidy.py and pipe the stderr output to a temporary file. Display this output only if run-clang-tidy.py hits an error, as this output is not useful otherwise. Testing with a known clang tidy issue shows that warnings and errors are still in the output, and the output is clean on a clean Impala checkout. Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M bin/run_clang_tidy.sh 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/10615/3 -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Jul 2018 22:07:54 + Gerrit-HasComments: No
[Impala-ASF-CR] cleanup: extract RowBatchQueue into its own file
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10943 ) Change subject: cleanup: extract RowBatchQueue into its own file .. cleanup: extract RowBatchQueue into its own file While looking at IMPALA-7096, I noticed that RowBatchQueue was implemented in a strange place. Change-Id: I3577c1c6920b8cf858c8d49f8812ccc305d833f6 --- M be/src/exec/blocking-join-node.h M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/hdfs-scan-node.cc M be/src/exec/kudu-scan-node.cc M be/src/exec/scan-node.cc M be/src/exec/scan-node.h M be/src/exec/scanner-context.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.cc A be/src/runtime/row-batch-queue.cc A be/src/runtime/row-batch-queue.h 13 files changed, 129 insertions(+), 66 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/10943/2 -- To view, visit http://gerrit.cloudera.org:8080/10943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3577c1c6920b8cf858c8d49f8812ccc305d833f6 Gerrit-Change-Number: 10943 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2818/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 16 Jul 2018 21:52:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 16 Jul 2018 21:52:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: IMPALA-7199: Add scripts to create code coverage reports .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh File bin/coverage_helper.sh: http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@44 PS2, Line 44:shift; > is that semicolon doing anything? Removed (I copy/pasted from buildall.sh) http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@51 PS2, Line 51: shift; > I don't think that semicolon needs to be tehre? Removed -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 16 Jul 2018 21:51:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10791 to look at the new patch set (#3). Change subject: IMPALA-7199: Add scripts to create code coverage reports .. IMPALA-7199: Add scripts to create code coverage reports gcovr is a python library that uses gcov to generate code coverage reports. This adds gcovr to the python dependencies and adds bin/impala-gcovr to provide easy access to gcovr's command line. gcovr 3.4 supports python 2.6+. This also adds bin/coverage_helper.sh to provide a simplified interface to generate reports and zero coverage counters. Code coverage data is written out when a program exits, so it is important to avoid hard kills to shut down the impalads when generating coverage. This modifies testdata/bin/kill-all.sh to call start-impala-cluster.py --kill when shutting down the minicluster to try to avoid doing a hard kill. It will still do a hard kill if impala is still running after the softer kill. Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd --- A bin/coverage_helper.sh A bin/impala-gcovr M infra/python/deps/requirements.txt M testdata/bin/kill-all.sh 4 files changed, 111 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/10791/3 -- To view, visit http://gerrit.cloudera.org:8080/10791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd Gerrit-Change-Number: 10791 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc@343 PS1, Line 343: if (std::is_floating_point::value) valid_column_index_ = false; > Will this still allow page skipping for predicates on other columns? Yes, at L1261 it can be seen that we only skip column index writing for columns that have valid_column_index_ == false. And we write the offset index for all the columns. So, e.g. if we have a predicate on an int32 column, and with the help of the page index (column index + offset index) we can figure out that we only need rows from row range 100 and 200, we can still use this row range to filter pages from all of the columns with the help of the offset index. -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Jul 2018 21:48:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10951 ) Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/10951/1/be/src/exec/hdfs-parquet-table-writer.cc@343 PS1, Line 343: if (std::is_floating_point::value) valid_column_index_ = false; Will this still allow page skipping for predicates on other columns? -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 16 Jul 2018 20:12:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Jul 2018 18:21:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. IMPALA-7299: [DOCS] A known issue with IMPALA-7298 Kerberos authentication fails with the reverse DNS lookup disabled. Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Reviewed-on: http://gerrit.cloudera.org:8080/10952 Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M docs/topics/impala_known_issues.xml 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/345/ -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Jul 2018 18:15:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Jul 2018 18:10:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Hello Michael Ho, Sailesh Mukil, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10952 to look at the new patch set (#3). Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. IMPALA-7299: [DOCS] A known issue with IMPALA-7298 Kerberos authentication fails with the reverse DNS lookup disabled. Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 --- M docs/topics/impala_known_issues.xml 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/10952/3 -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10952/2/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/10952/2/docs/topics/impala_known_issues.xml@349 PS2, Line 349: disabled > Should we say which releases include this bug? If yes, it's Impala 2.12.0 a Done http://gerrit.cloudera.org:8080/#/c/10952/2/docs/topics/impala_known_issues.xml@352 PS2, Line 352: If the : rdns = false, > nit: If the flag rdns = false, ... Done http://gerrit.cloudera.org:8080/#/c/10952/2/docs/topics/impala_known_issues.xml@353 PS2, Line 353: Impala uses the IP addresses of : remote hosts instead of the hostnames even if actual hostnames have : been passed instead. > when Impala tries to match principals, it will fail because kerberos receiv Done -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Jul 2018 18:09:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with IMPALA-7298
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10952 ) Change subject: IMPALA-7299: [DOCS] A known issue with IMPALA-7298 .. IMPALA-7299: [DOCS] A known issue with IMPALA-7298 Kerberos authentication fails with the reverse DNS lookup disabled. Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 --- M docs/topics/impala_known_issues.xml 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/10952/2 -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7299: [DOCS] A known issue with rnds�
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10952 Change subject: IMPALA-7299: [DOCS] A known issue with rnds=false .. IMPALA-7299: [DOCS] A known issue with rnds=false Kerberos authentication fails with the reverse DNS lookup disabled. Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 --- M docs/topics/impala_known_issues.xml 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/10952/1 -- To view, visit http://gerrit.cloudera.org:8080/10952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5b8104a2747b4e8051d4bdcab906486444680218 Gerrit-Change-Number: 10952 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-7202: Add width bucket() to the decimal fuzz test
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10859 ) Change subject: IMPALA-7202: Add width_bucket() to the decimal fuzz test .. Patch Set 1: Code-Review+1 Maybe some doc comments could be added to the new functions, but looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/10859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f8a63733ebddc07f46c525ca51ad4794dd0 Gerrit-Change-Number: 10859 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Reviewer: anujphadke Gerrit-Comment-Date: Mon, 16 Jul 2018 16:10:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Jinchul Kim, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10900 to look at the new patch set (#6). Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell .. IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell This change provides a way to modify command-line options like -B, --output_file and --delimiter inside impala-shell without quitting the shell and then restarting again. Also fixed IMPALA-7286: command "unset" does not work for shell options Testing: Added tests for all new options in test_shell_interactive.py Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 75 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10900/6 -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 6 Gerrit-Owner: Le Minh Nghia Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Jinchul Kim Gerrit-Reviewer: Le Minh Nghia Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10900 ) Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell .. Patch Set 5: (1 comment) Seems good to me, only missed some doc comments. http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10900/5/tests/shell/test_shell_interactive.py@91 PS5, Line 91: p = ImpalaShell() nit: please add some doc comments to the tests. -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 5 Gerrit-Owner: Le Minh Nghia Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Jinchul Kim Gerrit-Reviewer: Le Minh Nghia Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 16 Jul 2018 15:07:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved.
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10951 Change subject: IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. .. IMPALA-7304: Don't write floating column index until PARQUET-1222 is resolved. Impala master branch can already write the Parquet page index. However, we still don't have a well-defined ordering for floating-point numbers in Parquet, see PARQUET-1222 Currently impala writes the page index with fmax()/fmin() semantics, but it might contradicts the future semantics that will be defined once PARQUET-1222 is resolved. >From this patch Impala won't write the column index for floating-point columns until PARQUET-1222 is resolved and implemented. I updated the python test accordingly. Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b --- M be/src/exec/hdfs-parquet-table-writer.cc M tests/query_test/test_parquet_page_index.py 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10951/1 -- To view, visit http://gerrit.cloudera.org:8080/10951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I50aa2e6607de6a8943eb068b8162b0506763078b Gerrit-Change-Number: 10951 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Jinchul Kim, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10900 to look at the new patch set (#5). Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell .. IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell This change provides a way to modify command-line options like -B, --output_file and --delimiter inside impala-shell without quitting the shell and then restarting again. Also fixed IMPALA-7286: command "unset" does not work for shell options Testing: Added tests for all new options in test_shell_interactive.py Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 72 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10900/5 -- To view, visit http://gerrit.cloudera.org:8080/10900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763 Gerrit-Change-Number: 10900 Gerrit-PatchSet: 5 Gerrit-Owner: Le Minh Nghia Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Jinchul Kim Gerrit-Reviewer: Le Minh Nghia Gerrit-Reviewer: Zoltan Borok-Nagy
