[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: Awesome! Good to know the ORC issue is

[Impala-ASF-CR] test-with-docker: decrease image size by "de-duping" HDFS.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11782 ) Change subject: test-with-docker: decrease image size by "de-duping" HDFS. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: Code-Review+1 (2 comments) one question

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11781 ) Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: Build Successful

[Impala-ASF-CR] test-with-docker: decrease image size by "de-duping" HDFS.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11782 Change subject: test-with-docker: decrease image size by "de-duping" HDFS. .. test-with-docker: decrease image size by "de-duping"

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11781 Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. test-with-docker: allow built images to

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: (6 comments) Good news--the ORC / timestamp

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#4). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 20: Build Successful

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 6: Code-Review+1 Carry +1 -- To view,

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11615 ) Change subject: IMPALA-4063: Merge report of query fragment instances per executor .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: (8 comments) Addressed comments and made a

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 20: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-4063: Merge report of query fragment instances per executor

2018-10-24 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Tim Armstrong, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11615 to look at the new patch set (#6). Change subject: IMPALA-4063: Merge report of query fragment instances per

[Impala-ASF-CR] IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC

2018-10-24 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Todd Lipcon, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, Michal Ostrowski, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10855 to look at the new patch set (#20). Change subject: IMPALA-7213, IMPALA-7241: Port

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Paul Rogers, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11698 to look at the new patch set (#5). Change subject: IMPALA-5004: Switch to sorting node for large TopN queries

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 ) Change subject: IMPALA-7662: fix error race when scanner open fails .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11692 to look at the new patch set (#4). Change subject: IMPALA-7351: Add estimates to Exchange node

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11556 to look at the new patch set (#6). Change subject: IMPALA-6323 Allow constant analytic window expressions.

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-24 Thread Tim Armstrong (Code Review)
Hello Pooja Nilangekar, Lars Volker, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11596 to look at the new patch set (#8). Change subject: IMPALA-7662: fix error race when scanner open fails

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 ) Change subject: IMPALA-7662: fix error race when scanner open fails .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 5: Code-Review+2 LGTM once my two style comments

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Build started:

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 18: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (3 comments) main question from my end is to

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. IMPALA-5031: Increase backend test

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michal Ostrowski (Code Review)
Hello Michael Ho, Thomas Marshall, Paul Rogers, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11535 to look at the new patch set (#17). Change subject: IMPALA-6661 Make NaN values equal for grouping

[Impala-ASF-CR](asf-site) Fix name of 3.0.1 in link title

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11767 ) Change subject: Fix name of 3.0.1 in link title .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11767 To

[Impala-ASF-CR](asf-site) Fix name of 3.0.1 in link title

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11767 ) Change subject: Fix name of 3.0.1 in link title .. Fix name of 3.0.1 in link title Change-Id:

[Impala-ASF-CR](asf-site) Fix name of 3.0.1 in link title

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11767 ) Change subject: Fix name of 3.0.1 in link title .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7351: Add estimates to Exchange node

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11692 ) Change subject: IMPALA-7351: Add estimates to Exchange node .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 2: (2 comments)

[Impala-ASF-CR](asf-site) Fix name of 3.0.1 in link title

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11767 Change subject: Fix name of 3.0.1 in link title .. Fix name of 3.0.1 in link title Change-Id: I46ee692cd0925d6a72613ed152110d6d1eb34d6a

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 3: (7 comments)

[Impala-ASF-CR](asf-site) Download 3.0.1

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11766 ) Change subject: Download 3.0.1 .. Patch Set 1: Code-Review+2 Thanks for doing it. -- To view, visit

[Impala-ASF-CR](asf-site) Download 3.0.1

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11766 ) Change subject: Download 3.0.1 .. Download 3.0.1 This removes download links for old versions that don't have the security

[Impala-ASF-CR](asf-site) Download 3.0.1

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11766 ) Change subject: Download 3.0.1 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11766 To unsubscribe, visit

[Impala-ASF-CR](asf-site) Download 3.0.1

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11766 Change subject: Download 3.0.1 .. Download 3.0.1 This removes download links for old versions that don't have the security patches 3.0.1

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. Patch Set 2: Code-Review+2 carry Tim's +2 -- To view,

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-24 Thread Michal Ostrowski (Code Review)
Michal Ostrowski has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 5: (1 comment) > Patch Set 5: > > (1

[Impala-ASF-CR] IMPALA-7662: fix error race when scanner open fails

2018-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11596 ) Change subject: IMPALA-7662: fix error race when scanner open fails .. Patch Set 7: Code-Review+1 (3 comments) Just some nits.

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11764 ) Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-5031: Increase backend test timeout under UBSAN FULL

2018-10-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11764 Change subject: IMPALA-5031: Increase backend test timeout under UBSAN_FULL .. IMPALA-5031: Increase backend test timeout under UBSAN_FULL

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 3: Code-Review+1 (3 comments) If you do not want

[Impala-ASF-CR] IMPALA-6661 Make NaN values equal for grouping purposes.

2018-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 ) Change subject: IMPALA-6661 Make NaN values equal for grouping purposes. .. Patch Set 16: Code-Review+2 (2 comments) LGTM. Two minor