[Impala-ASF-CR] IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES

2019-10-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 ) Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES .. Patch Set 6: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. IMPALA-8950: Set overwrite to

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7504 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 ) Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7504 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-14 Thread Xiaomeng Zhang (Code Review)
Hello Michael Ho, Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14433 to look at the new patch set (#2). Change subject: IMPALA-7504 ParseKerberosPrincipal() should use krb5_parse_name() instead

[Impala-ASF-CR] ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-14 Thread Anonymous Coward (Code Review)
xiaom...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14433 Change subject: ParseKerberosPrincipal() should use krb5_parse_name() instead .. ParseKerberosPrincipal() should use

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES

2019-10-14 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Kurt Deschler, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14400 to look at the new patch set (#6). Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES

2019-10-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 ) Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES .. Patch Set 5: (2 comments) > Patch

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14432 ) Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. Patch Set 1: Code-Review+2 This makes sense to

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8950: Set overwrite to False by default in fs client.copy

2019-10-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14432 Change subject: IMPALA-8950: Set overwrite to False by default in fs_client.copy .. IMPALA-8950: Set overwrite to False by default in

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. IMPALA-9030: Handle translated external Kudu tables In HMS

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting

2019-10-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9025: Handle AnalysisException caused by expr rewrites properly

2019-10-14 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14403 ) Change subject: IMPALA-9025: Handle AnalysisException caused by expr_rewrites properly .. Patch Set 3: The build error seems not

[Impala-ASF-CR] IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES

2019-10-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 ) Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14423 to look at the new patch set (#2). Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api

2019-10-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14423 Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. IMPALA-9008: Serialize Maven invocations

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. IMPALA-8498: Write

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 10: Verified+1 --

[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC

2019-10-14 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC .. Patch Set 24: (18 comments) Hi Michael and Thomas, please

[Impala-ASF-CR] IMPALA-9030: Handle translated external Kudu tables

2019-10-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14397 ) Change subject: IMPALA-9030: Handle translated external Kudu tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9021: Fix the field of client's IP sent to Ranger

2019-10-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14410 ) Change subject: IMPALA-9021: Fix the field of client's IP sent to Ranger .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6501: Optimize count(star) for Kudu scans

2019-10-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14347 ) Change subject: IMPALA-6501: Optimize count(star) for Kudu scans .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 9: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14264 ) Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Patch Set 10: Code-Review+2

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-10-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-10-14 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 ) Change subject: IMPALA-8984: Fix race condition in creating Kudu table .. Patch Set 4: (8 comments) Thanks for your reviewed, Quanlong.

[Impala-ASF-CR] IMPALA-8984: Fix race condition in creating Kudu table

2019-10-14 Thread wangsheng (Code Review)
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14319 to look at the new patch set (#4). Change subject: IMPALA-8984: Fix race condition in creating Kudu table

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 5: (1 comment)