[Impala-ASF-CR] IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16119 ) Change subject: IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16119/2/testdata/datasets/tpcds/tpcds_schema_template.sql File testdata/datasets/tpcds/tpcds_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/16119/2/testdata/datasets/tpcds/tpcds_schema_template.sql@1142 PS2, Line 1142: r_reason_id CHAR(16) : r_reason_desc CHAR(100) nit: Why not using STRING? I think at least STRING saves some space. -- To view, visit http://gerrit.cloudera.org:8080/16119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f260e75a3803aabe9ccef271ba94036f96e5cf Gerrit-Change-Number: 16119 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 29 Jun 2020 02:56:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16119 ) Change subject: IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6445/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f260e75a3803aabe9ccef271ba94036f96e5cf Gerrit-Change-Number: 16119 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jun 2020 23:34:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16119 Change subject: IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite .. IMPALA-9890 (Part 1): Add more TPCDS queries to Impala's test suite This patch adds the following 12 TPCDS queries to the class of TestTpcdsDecimalV2Query: Q26, Q30, Q31, Q47, Q48, Q57, Q58, Q59, Q63, Q83, Q85, and Q89. All the queries except for Q31 are added to the class of TestTpcdsQuery as well because Impala returns one fewer row than expected for TestTpcdsQuery::test_tpcds_q31(), which requires further investigation. To verify whether or not the returned result set from Impala for a given query is correct, we compare the result set with that produced by the HiveServer2 (HS2) in Impala's mini-cluster. We could execute SQL statements in HS2 via Beeline, HS2's command line shell, which could be launched by the following command. beeline -u "jdbc:hive2://localhost:11050/default" We note that among these 12 queries, the execution of Q31, Q58, and Q83 result in the error of "Counters limit exceeded" by TEZ. To work around this problem, for these 3 queries we have to execute the following statement before running them to increase the default number of counters, which is set to 120. set tez.counters.max=1200 On the other hand, the table of 'reason' is referenced by Q85. This table was not referenced by any TPCDS query before this patch and thus was not created. In this regard, in this patch we also modify tpcds_schema_template.sql to create this additional table along with its data. Testing: - Verified that this patch passes the exhaustive tests in the DEBUG build. Change-Id: Ib5f260e75a3803aabe9ccef271ba94036f96e5cf --- M testdata/datasets/tpcds/tpcds_schema_template.sql A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q26.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q30.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q31.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q47.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q48.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q57.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q58.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q59.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q63.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q83.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q85.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q89.test A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q30.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q48.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q58.test A testdata/workloads/tpcds/queries/tpcds-q59.test A testdata/workloads/tpcds/queries/tpcds-q63.test A testdata/workloads/tpcds/queries/tpcds-q83.test A testdata/workloads/tpcds/queries/tpcds-q85.test A testdata/workloads/tpcds/queries/tpcds-q89.test M tests/query_test/test_tpcds_queries.py M tests/util/parse_util.py 26 files changed, 2,622 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/16119/2 -- To view, visit http://gerrit.cloudera.org:8080/16119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5f260e75a3803aabe9ccef271ba94036f96e5cf Gerrit-Change-Number: 16119 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 1: Hi Tim, I am answering one of my questions regarding whether to update EXPECTED_TPCDS_QUERIES_COUNT from 72 to 73 at https://github.com/apache/impala/blob/master/tests/util/parse_util.py#L25. According to the logic in the function of load_tpc_queries() at https://github.com/apache/impala/blob/master/tests/util/test_file_parser.py#L348-L350, it seems that we only need to update EXPECTED_TPCDS_QUERIES_COUNT when adding tests with names containing "tpcds-demical_v2" and thus we do not need to change EXPECTED_TPCDS_QUERIES_COUNT if we do not add tests under the class of TestTpcdsDecimalV2Query. -- To view, visit http://gerrit.cloudera.org:8080/16118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81807683aa265a946729e15156bd2e33724103e1 Gerrit-Change-Number: 16118 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 28 Jun 2020 21:35:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9902: add rewrite of TPC-DS q38
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16118 ) Change subject: IMPALA-9902: add rewrite of TPC-DS q38 .. Patch Set 1: (3 comments) Hi Tim, thanks for this patch! I only have two minor comments. I left one comment in test_tpcds_queries.py and the other one regarding EXPECTED_TPCDS_QUERIES_COUNT in the following. Specifically, I am wondering if we need to change EXPECTED_TPCDS_QUERIES_COUNT from 72 to 73 at https://github.com/apache/impala/blob/master/tests/util/parse_util.py#L25 since we add one more query in this patch. I recall that the following 2 tests depend on the value of EXPECTED_TPCDS_QUERIES_COUNT. 1) tests/infra/test_stress_infra.py::TestStressInfra::test_stress_finds_workloads: https://github.com/apache/impala/blob/master/tests/infra/test_stress_infra.py#L66, and 2) tests/infra/test_perf_infra.py::TestPerfInfra::test_run_workload_finds_queries: https://github.com/apache/impala/blob/master/tests/infra/test_perf_infra.py#L44 http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test File testdata/workloads/tpcds/queries/tpcds-q38.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q38.test@1 PS1, Line 1: : QUERY: TPCDS-Q38 : -- This is an unofficial variant that is rewritten to use EXISTS subqueries instead of : -- INTERSECT : select count(*) from ( : select distinct c_last_name, c_first_name, d_date : from store_sales, date_dim dd1, customer c1 : where store_sales.ss_sold_date_sk = dd1.d_date_sk : and store_sales.ss_customer_sk = c1.c_customer_sk : and d_month_seq between 1189 and 1189 + 11 : and exists ( :select distinct c_last_name, c_first_name, d_date :from catalog_sales, date_dim dd2, customer c2 : where catalog_sales.cs_sold_date_sk = dd2.d_date_sk : and catalog_sales.cs_bill_customer_sk = c2.c_customer_sk : and d_month_seq between 1189 and 1189 + 11 : and c1.c_last_name <=> c2.c_last_name and c1.c_first_name <=> c2.c_first_name and dd1.d_date <=> dd2.d_date : ) : and exists ( :select distinct c_last_name, c_first_name, d_date :from web_sales, date_dim dd3, customer c3 : where web_sales.ws_sold_date_sk = dd3.d_date_sk : and web_sales.ws_bill_customer_sk = c3.c_customer_sk : and d_month_seq between 1189 and 1189 + 11 : and c1.c_last_name <=> c3.c_last_name and c1.c_first_name <=> c3.c_first_name and dd1.d_date <=> dd3.d_date : ) : ) hot_cust : limit 100 : RESULTS : 108 : TYPES : BIGINT : I just found that HS2 is not able to compile the rewritten Q38 due to the following error. Error while compiling statement: FAILED: SemanticException [Error 10249]: Line 15:9 Unsupported SubQuery Expression 'd_date': Only 1 SubQuery expression is supported. But I am still able to use HS2 to verify the correctness by using the unmodified query and I found the results from Impala and HS2 match. http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test File testdata/workloads/tpcds/queries/tpcds-q8.test: http://gerrit.cloudera.org:8080/#/c/16118/1/testdata/workloads/tpcds/queries/tpcds-q8.test@4 PS1, Line 4: -- INTERSECT. Thanks Tim for catching this! After checking $IMPALA_HOME/toolchain/toolchain-packages-gcc7.5.0/tpc-ds-2.1.0/share/tpc-ds/query_templates/query8.tpl, I just realized that Q8 is indeed a variant. http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py File tests/query_test/test_tpcds_queries.py: http://gerrit.cloudera.org:8080/#/c/16118/1/tests/query_test/test_tpcds_queries.py@127 PS1, Line 127: def test_tpcds_q38(self, vector): I am wondering if we need to add the modified Q38 under the class of TestTpcdsDecimalV2Query (https://github.com/apache/impala/blob/master/tests/query_test/test_tpcds_queries.py#L269). On the other hand, I am also wondering if it is better to change the name of the test to test_tpcds_q38a so that one can tell from its name that the query is a variant. -- To view, visit http://gerrit.cloudera.org:8080/16118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81807683aa265a946729e15156bd2e33724103e1 Gerrit-Change-Number: 16118 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 28 Jun 2020 19:19:12 + Gerri
[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I124a58a09a1a47e1222a22d84b54fe7d07844461 Gerrit-Change-Number: 16052 Gerrit-PatchSet: 3 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jun 2020 19:00:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16052 ) Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. Patch Set 3: (4 comments) CR comments addressed, still working on clean jenkins runs. http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@465 PS2, Line 465: // TODO: Remove this when independent subquery evaluation is implemented. > Can we add a simple planner test for this rewrite? With the cardinality che Done http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@466 PS2, Line 466: // TODO: IMPALA-5100 to cover all cases, we do let through runtime scalars with > It might be helpful to file a separate JIRA with an example of this query, IMPALA-1285 already existed to cover this case, however the way the JIRA is worded in such way to cover the case of detecting these situations at plan time. I had linked this JIRA with IMPALA-5100 which is the blanket issue for runtime scalar checks. Adding IMPALA-9905 to cover the case of queries that can now run after this change. http://gerrit.cloudera.org:8080/#/c/16052/2/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@469 PS2, Line 469: presence > nit: presence Done http://gerrit.cloudera.org:8080/#/c/16052/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test File testdata/workloads/functional-query/queries/QueryTest/subquery.test: http://gerrit.cloudera.org:8080/#/c/16052/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1218 PS2, Line 1218: from alltypestiny group by id > nit: remove the functional database name here and below - the test framewor Done -- To view, visit http://gerrit.cloudera.org:8080/16052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I124a58a09a1a47e1222a22d84b54fe7d07844461 Gerrit-Change-Number: 16052 Gerrit-PatchSet: 3 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jun 2020 18:16:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.
Hello Aman Sinha, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16052 to look at the new patch set (#3). Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. .. IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING. Support rewriting subqueries in the HAVING clause by nesting the aggregation query and pulling up the subquery predicates into the outer WHERE clause. Testing: * New analyzer tests * New functional subquery tests * Added Q23, Q24 and Q44 to the tpcds workload * Ran subquery rewrite tests Change-Id: I124a58a09a1a47e1222a22d84b54fe7d07844461 --- M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java M testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test M testdata/workloads/functional-query/queries/QueryTest/subquery.test A testdata/workloads/tpcds/queries/tpcds-q23-1.test A testdata/workloads/tpcds/queries/tpcds-q23-2.test A testdata/workloads/tpcds/queries/tpcds-q24-1.test A testdata/workloads/tpcds/queries/tpcds-q24-2.test A testdata/workloads/tpcds/queries/tpcds-q44.test M tests/query_test/test_tpcds_queries.py 12 files changed, 1,194 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/16052/3 -- To view, visit http://gerrit.cloudera.org:8080/16052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I124a58a09a1a47e1222a22d84b54fe7d07844461 Gerrit-Change-Number: 16052 Gerrit-PatchSet: 3 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8984: Uncorrelated scalar subqueries in the select list
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8984: Uncorrelated scalar subqueries in the select list .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf55d26889aa01d69bb85f18c9241dda095fb66 Gerrit-Change-Number: 16007 Gerrit-PatchSet: 5 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 28 Jun 2020 17:04:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8984: Uncorrelated scalar subqueries in the select list
Hello Aman Sinha, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16007 to look at the new patch set (#5). Change subject: IMPALA-8984: Uncorrelated scalar subqueries in the select list .. IMPALA-8984: Uncorrelated scalar subqueries in the select list Extend StmtRewriter with the ability to rewrite scalar subqueries in the select list into cross joins. Currently the subquery must pass plan-time checks to determine that it returns a single row which may miss cases that may be valid at runtime or with more complex evaluation of the predicate expressions in the planner. Support for correlated subqueries will be a follow on change. With this change Q9 of TPC-DS is supported, we now load the 'reasons' table as part of the TPC-DS workload for use by Q9. Testing: * Added new analyzer tests, updated previous subquery tests * test_queries.py::TestQueries::test_subquery Change-Id: Ibcf55d26889aa01d69bb85f18c9241dda095fb66 --- M fe/src/main/java/org/apache/impala/analysis/SelectList.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeSubqueriesTest.java M testdata/datasets/tpcds/tpcds_schema_template.sql M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test M testdata/workloads/functional-query/queries/QueryTest/subquery.test M testdata/workloads/tpcds/queries/count.test A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q9.test A testdata/workloads/tpcds/queries/tpcds-q9.test M tests/query_test/test_tpcds_queries.py M tests/util/parse_util.py 12 files changed, 1,456 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/16007/5 -- To view, visit http://gerrit.cloudera.org:8080/16007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibcf55d26889aa01d69bb85f18c9241dda095fb66 Gerrit-Change-Number: 16007 Gerrit-PatchSet: 5 Gerrit-Owner: Shant Hovsepian Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9213: Add query retry info to GetLog result
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16093 ) Change subject: IMPALA-9213: Add query retry info to GetLog result .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6441/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Gerrit-Change-Number: 16093 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Sun, 28 Jun 2020 07:03:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9569: Fix progress bar and live summary to show info of the retried query
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16096 ) Change subject: IMPALA-9569: Fix progress bar and live_summary to show info of the retried query .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6442/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f96919f00e0b64d589efd15b6b5ec82fb725d56 Gerrit-Change-Number: 16096 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Sun, 28 Jun 2020 07:03:59 + Gerrit-HasComments: No
