[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Add slack channel in the community page

2021-04-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17311 Change subject: Add slack channel in the community page .. Add slack channel in the community page This patch adds links to join the

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. .. Patch

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

2021-04-12 Thread Sourabh Goyal (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17298 to look at the new patch set (#3). Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions.

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. IMPALA-10619: Minor refactoring of analytic

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Code-Review+2 Carry forward +2 -- To

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 18: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. IMPALA-10647 Improve always-true min/max

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 3: It looks like the solution of this

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-12 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#3). Change subject: IMPALA-10584: Defer advancing read page when reservation is tight.

[Impala-ASF-CR] IMPALA-10350 Fix precision loss while converting DecimalValue to double.

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 ) Change subject: IMPALA-10350 Fix precision loss while converting DecimalValue to double. .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-10350 Fix precision loss while converting DecimalValue to double.

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 ) Change subject: IMPALA-10350 Fix precision loss while converting DecimalValue to double. .. Patch Set 4: (20 comments)

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 17: (5 comments)

[Impala-ASF-CR] IMPALA-10350 Fix precision loss while converting DecimalValue to double.

2021-04-12 Thread Amogh Margoor (Code Review)
Amogh Margoor has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17303 ) Change subject: IMPALA-10350 Fix precision loss while converting DecimalValue to double. .. IMPALA-10350 Fix precision loss while

[Impala-ASF-CR] [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: [WIP] IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Verified+1 > Patch Set 4: Verified-1 > >

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has removed a vote on this change. Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/17237

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 17: Three new tests are added in

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. IMPALA-10647 Improve always-true min/max

[Impala-ASF-CR] IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats

2021-04-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17300 ) Change subject: IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. IMPALA-10445: Adjust NDV's precision/scale by query option

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. IMPALA-10445: Adjust NDV's precision/scale by query option

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-04-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 25: Code-Review+1 (5

[Impala-ASF-CR] IMPALA-10350 Fix precision loss while converting DecimalValue to double.

2021-04-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 ) Change subject: IMPALA-10350 Fix precision loss while converting DecimalValue to double. .. Patch Set 3: (7 comments) The

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. IMPALA-10445: Adjust NDV's precision/scale by query option

[Impala-ASF-CR] WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17262 ) Change subject: WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types .. Patch Set 3: Build

[Impala-ASF-CR] WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17262 ) Change subject: WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types .. Patch Set 3: (1 comment)

[Impala-ASF-CR] WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types

2021-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17262 Change subject: WIP - IMPALA-10642: Write support for Parquet Bloom filters - most common types .. WIP - IMPALA-10642: Write support

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. IMPALA-10445: Adjust NDV's precision/scale by query option

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Code-Review+2 Carry +2 (only change is in formatting of commit

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17301 Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web publication

[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing

2021-04-12 Thread Jim Apple (Code Review)
Hello Quanlong Huang, Shajini Thayasingh, Sahil Takiar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17301 to look at the new patch set (#2). Change subject: Switch to .asf.yaml for site publishing

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's precision/scale by query option

2021-04-12 Thread fifteencai (Code Review)
fifteencai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17306 Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option .. IMPALA-10445: Adjust NDV's precision/scale by query option

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10631: Upgrade DataSketches to version 3.0.0

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17294 ) Change subject: IMPALA-10631: Upgrade DataSketches to version 3.0.0 .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10631: Upgrade DataSketches to version 3.0.0

2021-04-12 Thread Fucun Chu (Code Review)
Fucun Chu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17294 ) Change subject: IMPALA-10631: Upgrade DataSketches to version 3.0.0 .. IMPALA-10631: Upgrade DataSketches to version 3.0.0 Upgrade the

[native-toolchain-CR] IMPALA-10488: Add jwt-cpp 0.5.0 to the toolchain

2021-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17118 ) Change subject: IMPALA-10488: Add jwt-cpp 0.5.0 to the toolchain .. Patch Set 3: Code-Review+2 >here are some CMake extensions that

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10619: Minor refactoring of analytic function methods

2021-04-12 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 ) Change subject: IMPALA-10619: Minor refactoring of analytic function methods .. Patch Set 3: (1 comment)