[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8669 Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. IMPALA-6255: Add device names to DiskIoMgr thread names This

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-26 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8609 ) Change subject: Make wording around adopters of Impala more consistent. .. Make wording around adopters of Impala more

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 4: Code-Review+2 (1 comment) Carrying Tim's +2

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#4). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 6: Code-Review+2 Changed thread names for

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#5). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala-ASF-CR] Remove "incubator-" from URLs.

2017-11-29 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/8698 ) Change subject: Remove "incubator-" from URLs. .. Abandoned Tim was faster :) -- To view, visit http://gerrit.cloudera.org:8080/8698 To

[Impala-ASF-CR] Remove "incubator-" from URLs.

2017-11-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8698 Change subject: Remove "incubator-" from URLs. .. Remove "incubator-" from URLs. I did this with the help of this command: git grep -l

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (7 comments) Thank you for working on this.

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8758 Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. IMPALA-6190/6246: Add instances tab and event sequence This

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-18 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#8). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 1: Code-Review+1 I confirmed that port 27000 is not used by

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 12: Code-Review+1 Thank you for making all the

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 14: Code-Review+2 This seems to be a known

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 13: Code-Review+2 Carrying Tim's +2 -- To

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2017-12-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 5: Code-Review+1 (2 comments) LGTM.

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time.

2017-12-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time. .. Patch Set 3: (14 comments) Thank you for working on this! I

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 7: (18 comments) Thank you for the review. Please

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 10: (11 comments) I added some comments to

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#5). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#6). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 4: (11 comments) This looks good to me, I only

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > >

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > Dan, what's your

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8609 Change subject: Make wording around adopters of Impala more consistent. .. Make wording around adopters of Impala more consistent.

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 7: Flaky test, will restart the Jenkins

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing this

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > >

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8590 Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. IMPALA-6109: xfail

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#3). Change subject: IMPALA-6190/6246: Add instances tab and event sequence ..

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 2: PS2 passed a private build:

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 2: > Patch Set 2: > > Can you link to a full profile

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 4: Can you adjust the logging details according to

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 5: (5 comments)

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/5829 ) Change subject: Add .pep8rc for Impala's Python style .. Abandoned Not finding time to work on this one. -- To view, visit

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: > Patch Set 2: > > I spoke to Gabor about this a few days ago.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 1: (19 comments) The approach looks good to me, I

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (5 comments) > Patch Set 3: > > (5 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-20 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#9). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 9: (6 comments) Thanks for the comments, please see

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 2: Code-Review+1 (1 comment) I manually compared this

[Impala-ASF-CR] IMPALA-6946: handle negative counts in RLE decoder

2018-05-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 ) Change subject: IMPALA-6946: handle negative counts in RLE decoder .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 8: Code-Review+1 Alex, do you have time to

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 15: (25 comments) Still need to do a pass over the tests.

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 17: (5 comments) Only a few minor comments, otherwise looks

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 16: (20 comments)

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-27 Thread Lars Volker (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10222 to look at the new patch set (#5). Change subject: Warn about Hadoop / Java version incompatibility .. Warn about

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 4: (1 comment) Updated the commit message in PS5,

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-27 Thread Lars Volker (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10222 to look at the new patch set (#6). Change subject: Warn about Hadoop / Java version incompatibility .. Warn about

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 4: (6 comments) > - At this point every

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 2: Code-Review-1 (3 comments) I think this has a bug when multiprocessing

[Impala-ASF-CR] IMPALA-6946: handle negative counts in RLE decoder

2018-05-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 ) Change subject: IMPALA-6946: handle negative counts in RLE decoder .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6946: handle negative counts in RLE decoder

2018-05-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 ) Change subject: IMPALA-6946: handle negative counts in RLE decoder .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 18: Code-Review+2 (2 comments) LGTM, had one remaining nit.

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Code-Review+2 (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10409 Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. IMPALA-7032: Disable codegen for CHAR type null literals

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10409 to look at the new patch set (#2). Change subject: IMPALA-7032: Disable codegen for CHAR type null literals ..

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-05-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 15: Code-Review+2 Carrying Alex's +2 -- To

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-22 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10483 Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. IMPALA-7044: Prevent overflow when computing Parquet

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10496 Change subject: Bump libunwind version to 1.3-rc1 .. Bump libunwind version to 1.3-rc1 This changes bumps libunwind to version 1.3-rc1,

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10488 ) Change subject: IMPALA-7062: fix unsafe RuntimeProfile::SortChildren() function .. Patch Set 1: (2 comments)

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Bump libunwind version to 1.3-rc1 This changes bumps libunwind to version

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: Verified+1 Built the toolchain locally -- To view, visit

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10496/1/buildall.sh

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Hello Thomas Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#3). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Hello Thomas Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#4). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 2: (1 comment) Thanks for the review.

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. IMPALA-7032: Disable codegen for CHAR type null

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 2: This was a false positive from the recent

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Lars Volker (Code Review)
Lars Volker has removed a vote on this change. Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 ) Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7044: Prevent overflow when computing Parquet block size

2018-05-23 Thread Lars Volker (Code Review)
Hello Thomas Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10483 to look at the new patch set (#2). Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size

[Impala-ASF-CR](2.x) Revert "IMPALA-7156: temporary revert to older Sentry version"

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10689 ) Change subject: Revert "IMPALA-7156: temporary revert to older Sentry version" .. Revert "IMPALA-7156: temporary revert to older

[Impala-ASF-CR](2.x) Revert "IMPALA-7156: temporary revert to older Sentry version"

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10689 ) Change subject: Revert "IMPALA-7156: temporary revert to older Sentry version" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: > I think we can run the script in a standalone

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Bharath, do we have an easy way to test this? -- To

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Change variables to make the code easier to read Change-Id:

[Impala-ASF-CR] Change variables to make the code easier to read

2018-06-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10699 ) Change subject: Change variables to make the code easier to read .. Patch Set 1: Verified+1 -- To view, visit

  1   2   3   4   5   6   7   8   9   10   >