Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 )
Change subject: Speed up Python dependencies. ...................................................................... Patch Set 2: Code-Review-1 (3 comments) I think this has a bug when multiprocessing fails to import. http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@137 PS2, Line 137: results = [] Hoist this out of the loop (see my comment below). http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@139 PS2, Line 139: # Multiprocessing was introduced in Python2.6; fail gracefully if If it was introduced in 2.6, can we not rely on it (I thought that was the earliest Python version we support). http://gerrit.cloudera.org:8080/#/c/10234/2/infra/python/deps/pip_download.py@172 PS2, Line 172: if results: If the import above fails, then results = [] will never execute and this statement will fail (unless I'm missing something). Moving it out of the loop above also allows to get rid of the "if ". -- To view, visit http://gerrit.cloudera.org:8080/10234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cbf622adb7d037f1a53c519402dcd8ae3c0fe30 Gerrit-Change-Number: 10234 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Fri, 27 Apr 2018 21:44:55 +0000 Gerrit-HasComments: Yes
