[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8623 to look at the new patch set (#3). Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (12 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5940: Avoid stack tracing and log spew with Status::Expected()

2017-11-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8689 ) Change subject: IMPALA-5940: Avoid stack tracing and log spew with Status::Expected() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8623 to look at the new patch set (#4). Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 ) Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8751 Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. IMPALA-6238: Enhance

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Hello Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8751 to look at the new patch set (#2). Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message

[Impala-ASF-CR] IMPALA-6238: Enhance TErrorCode::DATASTREAM SENDER TIMEOUT message

2017-12-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 ) Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 1: You may want to update it here too:

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Kudu Jenkins. -- To view,

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Dan Burkert. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Patch Set 1: (1 comment) Mostly a clean cherry-pick

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Removed reviewer Alexey Serbin. -- To view,

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-18 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8875 to review the following change. Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: (13 comments)

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8878 to review the following change. Change subject: KUDU-2228: Make Messenger options configurable ..

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Hello Lars Volker, Dan Burkert, Kudu Jenkins, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8878 to look at the new patch set (#2). Change subject: KUDU-2228: Make Messenger options configurable

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2017-12-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 1: Some number of conflicts in the #include files. Conflicts

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: (6 comments) Thanks for updating the interface.

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots

2017-12-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 12: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 11: (7 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: The backport for the fix of KUDU-2228 is being

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. IMPALA-6220: Revert

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Abandoned Dup with https://gerrit.cloudera.org/#/c/8611/

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 1: As discussed offline, it may be

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 2: As mentioned before, an alternate

[Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8623 Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection .. IMPALA-6187: Fix missing conjuncts evaluation with

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8572 to look at the new patch set (#2). Change subject: IMPALA-6184: Clean up after ScalarExprEvaluator::Clone() fails

[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8572 Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone()

[Impala-ASF-CR] IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 ) Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (16 comments)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#4). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 8: (10 comments)

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8766 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: I would recommend against reverting this

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: The change looks good. Please address the question

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 16: Code-Review+2 Thanks for updating the patch to move

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8788 Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. IMPALA-6285: Don't print stack trace on RPC errors. There is not

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8770 Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime profile for DataSink

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Hello Philip Zeyliger, Sailesh Mukil, Tim Armstrong, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8788 to look at the new patch set (#3). Change subject: IMPALA-6285: Don't print stack trace on RPC errors.

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 4: Code-Review+2 Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6069: Fix CodegenAnyVal's handling of 'nan'

2017-12-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8790 ) Change subject: IMPALA-6069: Fix CodegenAnyVal's handling of 'nan' .. Patch Set 1: Nice catch ! Do we have a similar problem with the

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime profile for DataSink

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 4: (18 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: LGTM. Will there be another change addressing similar

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Hello Tianyi Wang, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10327 to look at the new patch set (#4). Change subject: IMPALA-6907: Close stale connections to removed cluster members

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-11 Thread Michael Ho (Code Review)
Hello Tianyi Wang, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10327 to look at the new patch set (#5). Change subject: IMPALA-6907: Close stale connections to removed cluster members

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. IMPALA-6907: Close stale connections to removed cluster

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Tim, thanks for pointing that out. I

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10480 Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to 3.5.1 Protobuf 3.0.0+ has support for both v2 and v3 of protobuf syntax.

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 3: Code-Review+2 Rebase. Carry +2. --

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10496/1/buildall.sh

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment)

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10480 to look at the new patch set (#2). Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified the change by building on various platforms and tried the new bits on

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTITIONED

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10421 Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTITIONED

  1   2   3   4   5   6   7   8   9   10   >