[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-29 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11995 to look at the new patch set (#3). Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 2: (2 comments) Thanks Fredy for the review. Went

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12016 Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. IMPALA-7915: Wrap SQL parser to avoid redundant code The FE has

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-11-30 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12016 to look at the new patch set (#2). Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code ..

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5973: Provide query plan in JSON format

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 ) Change subject: IMPALA-5973: Provide query plan in JSON format .. Patch Set 3: Thanks much for the contribution. The implementation

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#7). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] Fix

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12018 Change subject: Fix .. Fix Change-Id: Ie565ff02ad74f805a667017ba9bc8c0a2697a97b --- D

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12017 Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. IMPALA-7914: Base interface for statement-like AST nodes In

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: (1 comment) Cleaned up the API a bit.

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12017 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Abandoned Wrong branch -- To view, visit

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#4). Change subject: IMPALA-7842: Make query fragments available for unit testing

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-11-30 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#3). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() ..

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. IMPALA-7907: Fix ScalarFunction.toSql() Each AST statement node has a toSql()

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-01 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#4). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() ..

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12018 to look at the new patch set (#4). Change subject: IMPALA-7914: Base interface for statement-like AST nodes

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: This patch touches just one FE unit

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 4: Turns out a base class is even more useful than a

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 3: (1 comment) Bharath, thanks for the good

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 7: (1 comment) Bharath, thanks for the additional

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#7). Change subject: IMPALA-7842: Expose physical plan for unit testing

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: Code-Review+1 (2 comments) My vote is to

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-05 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12018 to look at the new patch set (#5). Change subject: IMPALA-7914: Base class for statement-like AST nodes

[Impala-ASF-CR] IMPALA-5973: Provide query plan in JSON format

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11974 ) Change subject: IMPALA-5973: Provide query plan in JSON format .. Patch Set 3: Pranay, turns out it would be very handy indeed to

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 9: (8 comments)

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-05 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#4). Change subject: IMPALA-7844: HAVING clause cannot support ordinals ..

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-03 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 8: (10 comments) Thanks Tim for your review comments. I've

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-03 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12018 to look at the new patch set (#3). Change subject: IMPALA-7914: Base interface for statement-like AST nodes

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-03 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 2: (3 comments) Bharath, thanks much for your

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-03 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#9). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-03 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 5: (5 comments) Bharath, thanks much for the review.

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-03 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#5). Change subject: IMPALA-7842: Expose physical plan for unit testing

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-12-03 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Abandoned IMPALA-7902/12001 has a slightly more general

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-02 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12014 to look at the new patch set (#5). Change subject: IMPALA-7907: Fix ScalarFunction.toSql() ..

[Impala-ASF-CR] IMPALA-7907: Fix ScalarFunction.toSql()

2018-12-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12014 ) Change subject: IMPALA-7907: Fix ScalarFunction.toSql() .. Patch Set 5: Passed pre-review tests:

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 3: Rebased on latest master. Bharath, can you

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-06 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 9: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-06 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 11: Code-Review+1 (1 comment) LGTM. The parser/AST

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-04 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#6). Change subject: IMPALA-7842: Expose physical plan for unit testing

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-04 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#3). Change subject: IMPALA-7844: HAVING clause cannot support ordinals ..

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-04 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#10). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 6: (3 comments) Bharath, thanks for the review.

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 9: (6 comments) Thanks Tim for the additional review.

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-03 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2018-12-05 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12033 Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. IMPALA-7927: Enhance Rewritten SQL in test files Makes two changes

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has removed Anonymous Coward (168) from this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Removed reviewer null. -- To view, visit

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Anonymous Coward (168), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11893 to look at the new patch set (#5). Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 3: (3 comments) Addressed code review comments.

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-20 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11954 to look at the new patch set (#3). Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. IMPALA-7844: HAVING clause cannot support ordinals The SELECT

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Patch Set 5: Rebased on master. This one is pure clean-up. A

[Impala-ASF-CR] IMPALA-7867, part 1: Expose List in TreeNode, parser

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867, part 1: Expose List in TreeNode, parser .. Patch Set 2: This is a simple clean-up patch. No urgency. --

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 2: Change mostly passed the pre-commit test:

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull to use CASE

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull to use CASE .. Abandoned Will revisit after cleaning up blocking issues. -- To view, visit

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Abandoned Split test code into a separate patch. Will reopen this with just

[Impala-ASF-CR] MPALA-7867, part 1: Expose List in TreeNode, parser

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11954 Change subject: MPALA-7867, part 1: Expose List in TreeNode, parser .. MPALA-7867, part 1: Expose List in TreeNode, parser When using

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-27 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11995 Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. IMPALA-7867 (Part 2): ArrayList cleanup in analyzer Follow-on to

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-27 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ..

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: Code-Review+1 Reran the unit tests,

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11980 Change subject: IMPALA-7881: Visualize AST for easier debugging .. IMPALA-7881: Visualize AST for easier debugging Provides a debug-time

[Impala-ASF-CR] IMPALA-7867, part 1: Expose List in TreeNode, parser

2018-11-20 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11954 to look at the new patch set (#2). Change subject: IMPALA-7867, part 1: Expose List in TreeNode, parser ..

[Impala-ASF-CR] IMPALA-7823: Clean up unused Java imports

2018-11-26 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11987 to look at the new patch set (#2). Change subject: IMPALA-7823: Clean up unused Java imports

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11993 Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. IMPALA-7895: Incorrect expected results for

[Impala-ASF-CR] IMPALA-7823: Clean up unused Java imports

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11987 ) Change subject: IMPALA-7823: Clean up unused Java imports .. Patch Set 1: Hi Phillip, Fredy and I decided it would be best to do the

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ..

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 4: (3 comments) Addressed "reversed

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11953 Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. IMPALA-7866: Predicates, helpers for implicit casts,

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 1: Pre-commit tests passed:

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Patch Set 2: Pre-commit tests passed:

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11952 Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. IMPALA-7865: Repeated type widening of arithmetic

[Impala-ASF-CR] IMPALA-7823: Clean up Java warnings, fix minor issues

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11893 ) Change subject: IMPALA-7823: Clean up Java warnings, fix minor issues .. Abandoned Abandoning this per reviewer requests. Will do a series of

[Impala-ASF-CR] IMPALA-7823: Clean up unused Java imports

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11987 Change subject: IMPALA-7823: Clean up unused Java imports .. IMPALA-7823: Clean up unused Java imports Cleans up unused Java imports.

[Impala-ASF-CR] IMPALA-7823: Clean up unused Java imports

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11987 ) Change subject: IMPALA-7823: Clean up unused Java imports .. Patch Set 1: Fredy, this is the reduced CR with only imports cleaned up.

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 2: Bharath, anything more I should do on

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#7). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 6: Alex, sorry, I botched a rebase and the title got

[Impala-ASF-CR] [DOCS] Added a note in impala scan bytes limit.xml

2018-11-26 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11954 to look at the new patch set (#5). Change subject: [DOCS] Added a note in impala_scan_bytes_limit.xml

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11985 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Abandoned Incorrect branch -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11985 Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. IMPALA-7867 (Part 1): Expose List in TreeNode, parser When

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11954 ) Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser .. Patch Set 4: (4 comments) Fredy, addressed the generics

[Impala-ASF-CR] IMPALA-7867 (Part 1): Expose List in TreeNode, parser

2018-11-26 Thread Paul Rogers (Code Review)
Hello Alex Rodoni, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11954 to look at the new patch set (#6). Change subject: IMPALA-7867 (Part 1): Expose List in TreeNode, parser

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12136 to look at the new patch set (#15). Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12136 to look at the new patch set (#16). Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-01-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 7: (7 comments) The idea of refactoring auth system

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12136 to look at the new patch set (#17). Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 3: (10 comments) Looks pretty good!

[Impala-ASF-CR] IMPALA-6664: Tag log statements with fragment or query ids.

2019-01-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 ) Change subject: IMPALA-6664: Tag log statements with fragment or query ids. .. Patch Set 3: Does/should this fix up the Java side

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-09 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 17: Finally passed the pre-commit builds after

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 13: (7 comments) Addressed review comments,

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12136 to look at the new patch set (#13). Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 2: Rebased on master. Fixed code style issues. -- To view,

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Rebased on latest master to resolve merge

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12144 to look at the new patch set (#2). Change subject: IMPALA-8041, Part 2: Refactor SELECT list

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#8). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 7: (2 comments) Addressed recent review comments.

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#7). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

<    1   2   3   4   5   >