[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 ) Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f Gerrit-Change-Number: 19477 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 06 Feb 2023 17:10:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6 Gerrit-Change-Number: 17583 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 18 Jul 2021 01:29:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17583/2/README.md File README.md: http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55 PS2, Line 55: SLES12 > Good question. I just know that CDP/CDH supports SLES12 so Impala supports SGTM; ty! -- To view, visit http://gerrit.cloudera.org:8080/17583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6 Gerrit-Change-Number: 17583 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 13 Jul 2021 01:11:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9659: [DOCS] Document supported distros
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17583 ) Change subject: IMPALA-9659: [DOCS] Document supported distros .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17583/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17583/2//COMMIT_MSG@9 PS2, Line 9: docuemnt document http://gerrit.cloudera.org:8080/#/c/17583/2/README.md File README.md: http://gerrit.cloudera.org:8080/#/c/17583/2/README.md@55 PS2, Line 55: SLES12 Is this noted anywhere else? I'm trying to find it in the code or docs, partially to help me understand what we mean when we say "supported". -- To view, visit http://gerrit.cloudera.org:8080/17583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7104c24112d3ee298a9c9edd07e267b39bc77fa6 Gerrit-Change-Number: 17583 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 12 Jul 2021 12:44:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add 4.0.0 Release notes and change log
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17671 ) Change subject: Add 4.0.0 Release notes and change log .. Patch Set 1: I don't understand why the Jenkins job is failing. It's not finding check-rat-report and Makefile, but this patch touches neither of those . . . -- To view, visit http://gerrit.cloudera.org:8080/17671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I3f43b8a58e3adaad9423f3ed2cdd8ab7b187969c Gerrit-Change-Number: 17671 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sun, 11 Jul 2021 13:21:32 + Gerrit-HasComments: No
[Impala-ASF-CR] Update version to 4.1.0-SNAPSHOT
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17672 ) Change subject: Update version to 4.1.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cdf3084bb8fbc56944c26a2adc2cb838349f4b8 Gerrit-Change-Number: 17672 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 11 Jul 2021 13:20:27 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update download links for release 4.0.0
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17669 ) Change subject: Update download links for release 4.0.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17669/1/downloads.html File downloads.html: http://gerrit.cloudera.org:8080/#/c/17669/1/downloads.html@136 PS1, Line 136: "https://downloads.apache.org/impala/4.0.0/apache-impala-4.0.0.tar.gz;> This is 404 right now, presumably b/c the apache mirrors have not caught up yet (it takes them 24 hours). -- To view, visit http://gerrit.cloudera.org:8080/17669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I3b51e29eb7f31c5535e226b58c063aa4e1c58dc6 Gerrit-Change-Number: 17669 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sun, 11 Jul 2021 13:16:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python cryptography library
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt File infra/python/deps/adls-requirements.txt: http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24 PS2, Line 24: cryptography==3.2 > I don't have one at hand, but I will look into how to run the tests with AD Any updates on this? -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 22 May 2021 16:35:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10696: fix accuracy problem
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17411 ) Change subject: IMPALA-10696: fix accuracy problem .. IMPALA-10696: fix accuracy problem Table alltypes has no statistics, so the cardinality of alltypes will be estimated based on the hdfs files and the avg row size. Calling PrintUtils.printMetric, double will be divided by long. There will be accuracy problems. In most cases, the number of lines calculated is 17.91 K. But due to accuracy problems here, the calculated value is 17.90K. I modified line 221 of stats-extrapolation.test and used row_regex to match, referring to the matching method of cardinality in line 224,in this case, their values are the same Testing: metadata/test_stats_extrapolation.py Change-Id: I0a1a3809508c90217517705b2b188b2ccba6f23f Reviewed-on: http://gerrit.cloudera.org:8080/17411 Tested-by: Impala Public Jenkins Reviewed-by: Jim Apple --- M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0a1a3809508c90217517705b2b188b2ccba6f23f Gerrit-Change-Number: 17411 Gerrit-PatchSet: 2 Gerrit-Owner: liuyao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] Upgrading Python cryptography library
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt File infra/python/deps/adls-requirements.txt: http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24 PS2, Line 24: cryptography==3.2 > I don't have one at hand, but I will look into how to run the tests with AD SGTM! :-) -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 11 May 2021 19:35:33 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python cryptography library
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: Upgrading Python cryptography library .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG@7 PS2, Line 7: crptography > typo, missing first y Done http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt File infra/python/deps/adls-requirements.txt: http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24 PS2, Line 24: cryptography==3.2 > about testing: this change only affects ADLS environments, which is not cov I don't actually have an ADLS environment set up. Do you? -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 11 May 2021 13:37:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python cryptography library
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17323 to look at the new patch set (#3). Change subject: Upgrading Python cryptography library .. Upgrading Python cryptography library For release notes, see https://cryptography.io/en/latest/changelog/ Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 --- M infra/python/deps/adls-requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/3 -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Upgrading Python crptography library
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17323 to look at the new patch set (#2). Change subject: Upgrading Python crptography library .. Upgrading Python crptography library For release notes, see https://cryptography.io/en/latest/changelog/ Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 --- M infra/python/deps/adls-requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/2 -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] IMPALA-9690: Set minimum CPU requirement to AVX2 for x86 64
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17406 ) Change subject: IMPALA-9690: Set minimum CPU requirement to AVX2 for x86_64 .. Patch Set 2: Code-Review+2 (1 comment) There are still some places where things like CpuInfo::IsSupported(CpuInfo::SSE4_2) is present. I assume you're saving those for a follow-on commit? http://gerrit.cloudera.org:8080/#/c/17406/2/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17406/2/be/src/codegen/CMakeLists.txt@68 PS2, Line 68: set(PLATFORM_SPECIFIC_FLAGS "-mavx2") Does this imply POPCNT, as used in bit-util? -- To view, visit http://gerrit.cloudera.org:8080/17406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6de2e897d8ff24dea3c7c1c4ab9d61734839835d Gerrit-Change-Number: 17406 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 08 May 2021 16:32:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10696: fix accuracy problem
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17411 ) Change subject: IMPALA-10696: fix accuracy problem .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a1a3809508c90217517705b2b188b2ccba6f23f Gerrit-Change-Number: 17411 Gerrit-PatchSet: 1 Gerrit-Owner: liuyao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Sat, 08 May 2021 13:43:40 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 ) Change subject: WIP: upgrading some python requirements. .. Patch Set 1: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/ Appears just to be a flaky test. Here's an exhaustive run that passed: https://jenkins.impala.io/view/Utility/job/ubuntu-16.04-from-scratch/13700/ -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 19 Apr 2021 13:38:59 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17323 Change subject: WIP: upgrading some python requirements. .. WIP: upgrading some python requirements. Just checking to see if removing adls python packages breaks any tests Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 --- M infra/python/deps/adls-requirements.txt 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/1 -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR](asf-site) Add slack channel in the community page
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I26112aff63cabf6f4ca437f12d71928e80106687 Gerrit-Change-Number: 17311 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 13 Apr 2021 05:12:06 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add slack channel in the community page
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17311 ) Change subject: Add slack channel in the community page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17311/1/community.html File community.html: http://gerrit.cloudera.org:8080/#/c/17311/1/community.html@155 PS1, Line 155: sign up Do join links expire after a certain amount of time or a certain number of users? I have a recollection of running into that. -- To view, visit http://gerrit.cloudera.org:8080/17311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I26112aff63cabf6f4ca437f12d71928e80106687 Gerrit-Change-Number: 17311 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 13 Apr 2021 02:51:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web publication will be going offline. .asf.yaml is the replacement. See also https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Publishingabranchtoyourprojectwebsite (not visible to all users) https://lists.apache.org/thread.html/r8d023c0f5afefca7f6ce4e26d02404762bd6234fbe328011e1564249%40%3Cusers.infra.apache.org%3E https://infra-reports.apache.org/site-source/ Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Reviewed-on: http://gerrit.cloudera.org:8080/17301 Reviewed-by: Jim Apple Tested-by: Jim Apple --- A .asf.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jim Apple: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: merged Gerrit-Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Gerrit-Change-Number: 17301 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shajini Thayasingh
[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Gerrit-Change-Number: 17301 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shajini Thayasingh Gerrit-Comment-Date: Mon, 12 Apr 2021 14:22:31 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17301 ) Change subject: Switch to .asf.yaml for site publishing .. Patch Set 2: Code-Review+2 Carry +2 (only change is in formatting of commit description -- To view, visit http://gerrit.cloudera.org:8080/17301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Gerrit-Change-Number: 17301 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shajini Thayasingh Gerrit-Comment-Date: Mon, 12 Apr 2021 14:20:42 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17301 Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web publication will be going offline. .asf.yaml is the replacement. See also https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Publishingabranchtoyourprojectwebsite (not visible to all users) https://lists.apache.org/thread.html/r8d023c0f5afefca7f6ce4e26d02404762bd6234fbe328011e1564249%40%3Cusers.infra.apache.org%3E https://infra-reports.apache.org/site-source/ Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 --- A .asf.yaml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17301/1 -- To view, visit http://gerrit.cloudera.org:8080/17301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Gerrit-Change-Number: 17301 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shajini Thayasingh
[Impala-ASF-CR](asf-site) Switch to .asf.yaml for site publishing
Hello Quanlong Huang, Shajini Thayasingh, Sahil Takiar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17301 to look at the new patch set (#2). Change subject: Switch to .asf.yaml for site publishing .. Switch to .asf.yaml for site publishing Our existing method of web publication will be going offline. .asf.yaml is the replacement. See also https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Publishingabranchtoyourprojectwebsite (not visible to all users) https://lists.apache.org/thread.html/r8d023c0f5afefca7f6ce4e26d02404762bd6234fbe328011e1564249%40%3Cusers.infra.apache.org%3E https://infra-reports.apache.org/site-source/ Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 --- A .asf.yaml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17301/2 -- To view, visit http://gerrit.cloudera.org:8080/17301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9154ab397674d4c98e20f7c4f3774dfc19ff2932 Gerrit-Change-Number: 17301 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Shajini Thayasingh
[Impala-ASF-CR] Upgrade urllib3 to 1.24.2
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17270 Change subject: Upgrade urllib3 to 1.24.2 .. Upgrade urllib3 to 1.24.2 Change-Id: Ib18c76e66db2920e7e05a63b5bcd79854b819cd9 --- M infra/python/deps/requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/17270/1 -- To view, visit http://gerrit.cloudera.org:8080/17270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib18c76e66db2920e7e05a63b5bcd79854b819cd9 Gerrit-Change-Number: 17270 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 3: > > Patch Set 1: Code-Review+2 > > > > Should we have a "the minicluster starts" test in Jenkins that > runs on 20.04? > > Good point. Did you mean it in the context of GVO or postcommit? > In general, we should probably revisit the question of our runtime > platform for the precommit tests on public Jenkins (there was an > earlier discussion about migrating GVO & friends to Ubuntu 18.04) > as well as how we handle additional (supported) OS platforms. I'll > kick off a discussion on dev@, it is a better medium for a wider > discussion. I'm generally in favor of pre-commit tests, rather than post, if it doesn't slow down the end-to-end wall-clock time to commit. I like your idea of discussing in dev@. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Thu, 01 Apr 2021 14:30:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10618: Update bootstrap system for Ubuntu 20.04
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17240 ) Change subject: IMPALA-10618: Update bootstrap_system for Ubuntu 20.04 .. Patch Set 1: Code-Review+2 Should we have a "the minicluster starts" test in Jenkins that runs on 20.04? -- To view, visit http://gerrit.cloudera.org:8080/17240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I212f6df3657cf9d621a0669573e1e511eae13662 Gerrit-Change-Number: 17240 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Qifan Chen Gerrit-Comment-Date: Tue, 30 Mar 2021 13:50:04 + Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Hello Laszlo Gaal, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17215 to look at the new patch set (#3). Change subject: Update Python requests package to 2.20.0 .. Update Python requests package to 2.20.0 See https://2.python-requests.org/en/master/community/updates/#id8. This is currently only used in the tests, but it's best to fix this now. While here, remove now-false not about required support for Python 2.6. Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800 --- M infra/python/deps/requirements.txt M infra/python/deps/stage2-requirements.txt 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17215/3 -- To view, visit http://gerrit.cloudera.org:8080/17215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800 Gerrit-Change-Number: 17215 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] Update Python requests package to 2.20.0
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17215 ) Change subject: Update Python requests package to 2.20.0 .. Patch Set 2: Hi, all! This failed with "Could not find a version that satisfies the requirement chardet<3.1.0,>=3.0.2". Do you know how to manage that? I can't recall how python deps are managed and what would be causing this if pypi clearly has 3.0.2 available: https://pypi.org/project/chardet/3.0.2/ -- To view, visit http://gerrit.cloudera.org:8080/17215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800 Gerrit-Change-Number: 17215 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 22 Mar 2021 19:59:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Update Python requests package to 2.20.0
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17215 Change subject: Update Python requests package to 2.20.0 .. Update Python requests package to 2.20.0 See https://2.python-requests.org/en/master/community/updates/#id8. This is currently only used in the tests, but it's best to fix this now. Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800 --- M infra/python/deps/requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17215/1 -- To view, visit http://gerrit.cloudera.org:8080/17215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I092a641a12f38cdb45b0062c31ffb51c0c664800 Gerrit-Change-Number: 17215 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] Update Paramiko to 2.4.2.
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17214 Change subject: Update Paramiko to 2.4.2. .. Update Paramiko to 2.4.2. See https://www.paramiko.org/changelog.html#2.4.2. This shouldn't directly apply to Impala deployments, but it is best to fix this in test now. Change-Id: If9cc9ea4a0763c8b5303ca4e8482761ee2f53efa --- M infra/python/deps/extended-test-requirements.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/17214/1 -- To view, visit http://gerrit.cloudera.org:8080/17214 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If9cc9ea4a0763c8b5303ca4e8482761ee2f53efa Gerrit-Change-Number: 17214 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16751 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: Code-Review+2 Thank you! -- To view, visit http://gerrit.cloudera.org:8080/16751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id664dd66874ac65d6b78e630c974a6a563408147 Gerrit-Change-Number: 16751 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Fri, 20 Nov 2020 02:27:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > for 'why should it be done', no reason, just don't output to the > console, I already tested, adding it or not don't impact the logic. In that case, let's not redirect. I think that's more the style of the rest of the script. -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Nov 2020 16:17:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > And I think this solution is same with 'changeing for loop to while > true', just different checking lock solution. Sorry, I missed this part of your message. I find the two solutions different, as apt-get can fail for reasons other than another process holding the lock. This solution reduces the number of scenarios in which a build spins indefinitely, which is a result that should be avoided in terms of CI/CD ergonomics and economics. -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Nov 2020 04:47:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > Don't output to the console. Yes, I understand what it does. My question is "why should it be done?" -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Nov 2020 04:38:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16725/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/16725/2/bin/bootstrap_system.sh@212 PS2, Line 212: >/dev/null 2>&1 Looks good! One question - what is the rationale for redirecting stdout and stderr here? -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Nov 2020 03:51:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: > Hello Jim, this from askubuntu.com > https://askubuntu.com/questions/15433/unable-to-lock-the-administration-directory-var-lib-dpkg-is-another-process > I think removing the lock file and killing the process are not the > good choice. Any other suggestion? Yes, I agree! What do you think about the various solutions on this question: https://askubuntu.com/questions/132059/how-to-make-a-package-manager-wait-if-another-instance-of-apt-is-running -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 18 Nov 2020 03:19:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: > Hello, Jim, maybe we change the 'for' loop to 'while true'? I see the logic in that. We can just get started when the system is ready! But what happens if there's a problem other than this one that we can just wait out? Then the build would keep going for hours just failing at apt-get, yes? Maybe we should look around for what the best practices are for this kind of use case. I think I may have seen something on askubuntu.com. -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Tue, 17 Nov 2020 04:37:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 1: I saw these errors, thanks for taking a look! In my experience, these things happen when a new VM is starting and getting updates from the distro maintainer. Is there a way we can wait on the dpkg lock? I'm concerned that increasing the retry times just "kicks the can down the road", so to speak. -- To view, visit http://gerrit.cloudera.org:8080/16725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I790750da36ad53c87a830dfab6803a1862490daf Gerrit-Change-Number: 16725 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 16 Nov 2020 14:25:35 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add link to slack channel on community
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: > > Patch Set 1: > > > > Could we just use the-asf.slack.com and create an #impala > channel? It looks like that space is already active with other > projects like Beam and I think the space is blessed by ASF infra. > > The current slack channel has a decent number of people in it. > Might not be worth the switch over to the-asf unless there is some > kind of official policy? SGTM, assuming we can set a good invitation policy that allows new people in without overwhelming the workspace with spam. -- To view, visit http://gerrit.cloudera.org:8080/16024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibc05665607cc35a967c01660b6f4890ddd7e6a40 Gerrit-Change-Number: 16024 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Shant Hovsepian Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 19 Jul 2020 16:44:35 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add link to slack channel on community
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Could we just use the-asf.slack.com and create an #impala channel? It looks like that space is already active with other projects like Beam and I think the space is blessed by ASF infra. -- To view, visit http://gerrit.cloudera.org:8080/16024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ibc05665607cc35a967c01660b6f4890ddd7e6a40 Gerrit-Change-Number: 16024 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 17 Jul 2020 16:12:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 ) Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985 Gerrit-Change-Number: 15964 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 27 May 2020 23:29:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/15683/12/be/src/benchmarks/bloom-filter-benchmark.cc File be/src/benchmarks/bloom-filter-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/15683/12/be/src/benchmarks/bloom-filter-benchmark.cc@64 PS12, Line 64: // Machine Info: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz > Reran the the bloom filter benchmark on my desktop before and after applyin Sounds good; thanks! -- To view, visit http://gerrit.cloudera.org:8080/15683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9100076f68ea299ddb6ec8bc027cac7a47f5d754 Gerrit-Change-Number: 15683 Gerrit-PatchSet: 14 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 14 May 2020 14:02:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/15683/12/be/src/benchmarks/bloom-filter-benchmark.cc File be/src/benchmarks/bloom-filter-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/15683/12/be/src/benchmarks/bloom-filter-benchmark.cc@64 PS12, Line 64: // Machine Info: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz I'd suggest re-running these on your machine before and after applying this patch, to see if there are any regressions. There are an indirection or two that hopefully will be inlined away, but I'm not sure. -- To view, visit http://gerrit.cloudera.org:8080/15683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9100076f68ea299ddb6ec8bc027cac7a47f5d754 Gerrit-Change-Number: 15683 Gerrit-PatchSet: 12 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 11 May 2020 03:19:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 ) Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter .. Patch Set 8: The Kudu bloom filter here was actually copied from Impala - https://github.com/apache/kudu/commit/e671e81ce170c4595fed497a5a518a50eb700b69#diff-7cf847a66bbf0a8a603f35c0c03129fe Should we meld them rather than having two copies of the algorithm within the Impala code base? -- To view, visit http://gerrit.cloudera.org:8080/15676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357 Gerrit-Change-Number: 15676 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 11 May 2020 02:55:03 + Gerrit-HasComments: No
[Impala-ASF-CR] Add link to quickstart container from README
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15847 ) Change subject: Add link to quickstart container from README .. Patch Set 1: Hi Tim! Have you taken a look at the discussion on https://issues.apache.org/jira/browse/LEGAL-427? This seems like a case not covered there, since the "third party" is another Apache project. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/15847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b200a862fb0a5d3e40778bed02b8393720f35d1 Gerrit-Change-Number: 15847 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Sat, 02 May 2020 22:14:10 + Gerrit-HasComments: No
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 2: > This update is more about testing Gerrit/Jenkins integration after > a Gerrit plugin update. Sorry, I don't quite follow. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 16 Feb 2020 02:28:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Add --impalad args to single node perf run.py
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/14923 ) Change subject: Add --impalad_args to single_node_perf_run.py .. Patch Set 1: Code-Review+2 (1 comment) Fine as-is, but one question you might want to clarify in the help text. http://gerrit.cloudera.org:8080/#/c/14923/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/14923/1/bin/single_node_perf_run.py@286 PS1, Line 286: help="Additional arguments to pass to each Impalad during startup") Does it only work like --impalad_args=--foo --impalad_args=--bar or will the following also work: --impalad_args="--foo --bar" -- To view, visit http://gerrit.cloudera.org:8080/14923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib903f0eabb06a7e8981c874c8fe1cec0936b1a64 Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 19 Dec 2019 03:42:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Fix single node perf run default num impalads
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/14383 ) Change subject: Fix single_node_perf_run default num_impalads .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia295ce0b0040e02b4fa8faafc0ac749e35b46c19 Gerrit-Change-Number: 14383 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Tue, 08 Oct 2019 00:45:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: widen Thrift enum to placate UBSAN
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13940 ) Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN .. Patch Set 1: > I'm a bit reluctant about diverging parquet.thrift from the > upstream Apache Parquet thrift. Need to think about whether this is > the right way. We actually already deviated in the encoding. That kind of deviation or this one are the two ways that occurred to me to resolve issues like this. Did you have any other particular method in mind? -- To view, visit http://gerrit.cloudera.org:8080/13940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844 Gerrit-Change-Number: 13940 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 08 Sep 2019 18:32:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 2: What was the rationale for this revert? I don't see a reference in JIRA. -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 12 Aug 2019 00:12:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: widen Thrift enum to placate UBSAN
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13940 Change subject: IMPALA-5031: widen Thrift enum to placate UBSAN .. IMPALA-5031: widen Thrift enum to placate UBSAN This fixes an instance of undefined behavior in the end-to-end tests in which an enum value is outside of the allowable values for that enum according to the C++14 standard. Representative backtrace: exec/parquet/parquet-metadata-utils.cc:293:26: runtime error: load of value 49, which is not a valid value for type 'Type::type' #0 ParquetMetadataUtils::ValidateRowGroupColumn( parquet::FileMetaData const&, char const*, int, int, parquet::SchemaElement const&, RuntimeState*) exec/parquet/parquet-metadata-utils.cc:293:26 #1 BaseScalarColumnReader::Reset(HdfsFileDesc const&, parquet::ColumnChunk const&, int) exec/parquet/parquet-column-readers.cc:1077:43 #2 HdfsParquetScanner::InitScalarColumns() exec/parquet/hdfs-parquet-scanner.cc:1679:60 #3 HdfsParquetScanner::NextRowGroup() exec/parquet/hdfs-parquet-scanner.cc:648:45 #4 HdfsParquetScanner::GetNextInternal(RowBatch*) exec/parquet/hdfs-parquet-scanner.cc:437:45 #5 HdfsParquetScanner::ProcessSplit() exec/parquet/hdfs-parquet-scanner.cc:353:21 #6 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #7 HdfsScanNode::ScannerThread(bool, long) exec/hdfs-scan-node.cc:415:7 #8 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*):: $_0::operator()() const exec/hdfs-scan-node.cc:337:13 Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844 --- M common/thrift/parquet.thrift 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/13940/1 -- To view, visit http://gerrit.cloudera.org:8080/13940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48090e8e0c6c6f18bb1ad3c32c1f5fbffc908844 Gerrit-Change-Number: 13940 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: Fix undefined behavior: ptr overflow
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13889 Change subject: IMPALA-5031: Fix undefined behavior: ptr overflow .. IMPALA-5031: Fix undefined behavior: ptr overflow In expr.add, the standard says: When an expression that has integral type is added to or subtracted from a pointer, the result has the type of the pointer operand. ... If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined. This is triggered in the end-to-end tests.h The interesting part of the backtrace is: exec/parquet/hdfs-parquet-scanner.cc:1405:45: runtime error: pointer index expression with base 0x1300e0e9 overflowed to 0x1300e0ea #0 HdfsParquetScanner::ProcessFooter() exec/parquet/hdfs-parquet-scanner.cc:1405:45 #1 HdfsParquetScanner::Open(ScannerContext*) exec/parquet/hdfs-parquet-scanner.cc:186:26 #2 HdfsScanNodeBase::CreateAndOpenScannerHelper( HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-base.cc:721:59 #3 HdfsScanNodeMt::CreateAndOpenScanner(HdfsPartitionDescriptor*, ScannerContext*, scoped_ptr*) exec/hdfs-scan-node-mt.cc:127:19 #4 HdfsScanNodeMt::GetNext(RuntimeState*, RowBatch*, bool*) exec/hdfs-scan-node-mt.cc:97:21 Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f --- M be/src/exec/parquet/hdfs-parquet-scanner.cc 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/13889/1 -- To view, visit http://gerrit.cloudera.org:8080/13889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I81c7db75b564045106edf3d46e2c4a62be77359f Gerrit-Change-Number: 13889 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13769 to look at the new patch set (#3). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According to [expr.post] in the C++14 standard, a call to a member function like a->b() is interpreted as (a->b)(). In other words, the dereferencing is done separately from the call. This makes calling member functions on nullptr undefined behavior, since the dereference invokes undefined behavior. This fixes such an error in exec-node.cc in the end-to-end tests. The interesting part of the backtrace is: exec/exec-node.cc:396:27: runtime error: member call on null pointer of type 'MemTracker' #0 in ExecNode::ExecDebugActionImpl(TExecNodePhase::type, RuntimeState*) exec/exec-node.cc:396:27 #1 in ExecNode::ExecDebugAction(TExecNodePhase::type, RuntimeState*) exec/exec-node.h:379:12 #2 in ExecNode::Prepare(RuntimeState*) exec/exec-node.cc:106:43 #3 in TopNNode::Prepare(RuntimeState*) exec/topn-node.cc:75:53 Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 --- M be/src/exec/exec-node.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 3 files changed, 24 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/13769/3 -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13769 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h@358 PS2, Line 358: /// Makes MemLimitExceeded callable for nullptr MemTrackers. > Can you add a brief comment, just to explain that this exists so that mtrac Done http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@421 PS2, Line 421: mtracker > mtracker != nullptr to be more explicit Done http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@437 PS2, Line 437: mtracker > mtracker != nullptr to be more explicit Done -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 20 Jul 2019 01:59:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13803 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 2: Code-Review+2 Carry Tim's -- To view, visit http://gerrit.cloudera.org:8080/13803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 Gerrit-Change-Number: 13803 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 20 Jul 2019 01:31:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13803 to look at the new patch set (#2). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According to [expr.post] in the C++14 standard, a call to a member function like a->b() is interpreted as (a->b)(). In other words, the dereferencing is done separately from the call. This makes calling member functions on nullptr undefined behavior, since the dereference invokes undefined behavior. This fixes an error in hdfs-scanner.h in the end-to-end tests. The interesting part of the backtrace is: exec/hdfs-scanner.h:512:14: runtime error: member call on null pointer of type 'Tuple' #0 HdfsScanner::InitTuple(TupleDescriptor const*, Tuple*, Tuple*) exec/hdfs-scanner.h:512:14 #1 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:743:7 #2 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #3 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #4 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #5 OrcStructReader::TransferTuple(Tuple*, MemPool*) exec/orc-column-readers.cc:346:52 #6 HdfsOrcScanner::TransferTuples(OrcComplexColumnReader*, RowBatch*) exec/hdfs-orc-scanner.cc:670:58 #7 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:630:45 #8 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:508:19 #9 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:427:21 #10 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #11 HdfsScanNode::ScannerThread(bool, long) exec/hdfs-scan-node.cc:415:7 #12 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0 ::operator()() const exec/hdfs-scan-node.cc:337:13 Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 --- M be/src/exec/hdfs-scanner.h M be/src/runtime/tuple.h 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13803/2 -- To view, visit http://gerrit.cloudera.org:8080/13803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 Gerrit-Change-Number: 13803 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: out-of-range enum values are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13805 Change subject: IMPALA-5031: out-of-range enum values are undefined behavior .. IMPALA-5031: out-of-range enum values are undefined behavior This patch fixes an out-of-range enum value in the end-to-end tests. The [expr] section of the C++14 standard indicates that out-of-range enum values are undefined behavior: "If during the evaluation of an expression, the result is not mathematically defined or not in the range of representable values for its type, the behavior is undefined." The [decl.enum] section explains what values are "in the range of representable values for its type": "[F]or an enumeration where emin is the smallest enumerator and emax is the largest, the values of the enumeration are the values in the range bmin to bmax, defined as follows: Let K be 1 for a two's complement representation and 0 for a one's complement or sign-magnitude representation. bmax is the smallest value greater than or equal to max(|emin| - K, |emax|) and equal to 2M-1, where M is a non-negative integer. bmin is zero if emin is non-negative and -(bmax+K) otherwise." The Parquet PageType enum has emin = 0 and emax = 3, so bmin = 0 and bmax = 3. The out-of-range value in the tests is 4294967249, and is therefore undefined behavior. The interesting part of the backtrace is: parquet/parquet-column-readers.cc:1269:24: runtime error: load of value 4294967249, which is not a valid value for type 'PageType::type' #0 BaseScalarColumnReader::InitDictionary() parquet/parquet-column-readers.cc:1269:24 #1 BaseScalarColumnReader::InitDictionaries( vector) parquet/parquet-column-readers.cc:1381:53 #2 HdfsParquetScanner::NextRowGroup() parquet/hdfs-parquet-scanner.cc:678:14 #3 HdfsParquetScanner::GetNextInternal(RowBatch*) parquet/hdfs-parquet-scanner.cc:437:45 #4 HdfsParquetScanner::ProcessSplit() parquet/hdfs-parquet-scanner.cc:353:21 #5 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #6 HdfsScanNode::ScannerThread(bool, long) hdfs-scan-node.cc:415:7 #7 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*) ::$_0::operator()() const hdfs-scan-node.cc:337:13 Change-Id: I2d126a8f3e5910d23088a3f916c4cf31aac28d95 --- M be/src/exec/parquet/parquet-column-readers.cc 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/13805/1 -- To view, visit http://gerrit.cloudera.org:8080/13805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d126a8f3e5910d23088a3f916c4cf31aac28d95 Gerrit-Change-Number: 13805 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13804 Change subject: IMPALA-5031: Out-of-range enums are undefined behavior .. IMPALA-5031: Out-of-range enums are undefined behavior This eliminates an out-of-range enum value in the end-to-end tests. The interesting part of the backtrace is: exec/parquet/parquet-column-readers.cc:1530:112: runtime error: load of value 38, which is not a valid value for type 'Encoding::type' #0 BaseScalarColumnReader::ReadDataPage() exec/parquet/parquet-column-readers.cc:1530:112 #1 BaseScalarColumnReader::NextPage() exec/parquet/parquet-column-readers.cc:1769:28 #2 bool ScalarColumnReader ::ReadValueBatch(int, int, unsigned char*, int*) exec/parquet/parquet-column-readers.cc:459:12 #3 ScalarColumnReader ::ReadNonRepeatedValueBatch(MemPool*, int, int, unsigned char*, int*) exec/parquet/parquet-column-readers.cc:106:12 #4 HdfsParquetScanner::AssembleRows(vector const&, RowBatch*, bool*) exec/parquet/hdfs-parquet-scanner.cc:1113:42 #5 HdfsParquetScanner::GetNextInternal(RowBatch*) exec/parquet/hdfs-parquet-scanner.cc:456:19 #6 HdfsParquetScanner::ProcessSplit() exec/parquet/hdfs-parquet-scanner.cc:353:21 #7 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #8 HdfsScanNode::ScannerThread(bool, long) exec/hdfs-scan-node.cc:415:7 #9 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0 ::operator()() const exec/hdfs-scan-node.cc:337:13 Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129 --- M be/src/exec/parquet/parquet-column-readers.cc M be/src/exec/parquet/parquet-level-decoder.cc M be/src/exec/parquet/parquet-level-decoder.h M common/thrift/parquet.thrift 4 files changed, 21 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/13804/1 -- To view, visit http://gerrit.cloudera.org:8080/13804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129 Gerrit-Change-Number: 13804 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13803 Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According to [expr.post] in the C++14 standard, a call to a member function like a->b() is interpreted as (a->b)(). In other words, the dereferencing is done separately from the call. This makes calling member functions on nullptr undefined behavior, since the dereference invokes undefined behavior. This fixes an error in hdfs-scanner.h in the end-to-end tests. The interesting part of the backtrace is: exec/hdfs-scanner.h:512:14: runtime error: member call on null pointer of type 'Tuple' #0 HdfsScanner::InitTuple(TupleDescriptor const*, Tuple*, Tuple*) exec/hdfs-scanner.h:512:14 #1 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:743:7 #2 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #3 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #4 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #5 OrcStructReader::TransferTuple(Tuple*, MemPool*) exec/orc-column-readers.cc:346:52 #6 HdfsOrcScanner::TransferTuples(OrcComplexColumnReader*, RowBatch*) exec/hdfs-orc-scanner.cc:670:58 #7 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:630:45 #8 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:508:19 #9 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:427:21 #10 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #11 HdfsScanNode::ScannerThread(bool, long) exec/hdfs-scan-node.cc:415:7 #12 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0 ::operator()() const exec/hdfs-scan-node.cc:337:13 Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 --- M be/src/exec/hdfs-scanner.h M be/src/runtime/tuple.h 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13803/1 -- To view, visit http://gerrit.cloudera.org:8080/13803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7e5b130848a3c8f11d9010b3378f4054a35e1612 Gerrit-Change-Number: 13803 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13769 to look at the new patch set (#2). Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According to [expr.post] in the C++14 standard, a call to a member function like a->b() is interpreted as (a->b)(). In other words, the dereferencing is done separately from the call. This makes calling member functions on nullptr undefined behavior, since the dereference invokes undefined behavior. This fixes such an error in exec-node.cc in the end-to-end tests. The interesting part of the backtrace is: exec/exec-node.cc:396:27: runtime error: member call on null pointer of type 'MemTracker' #0 in ExecNode::ExecDebugActionImpl(TExecNodePhase::type, RuntimeState*) exec/exec-node.cc:396:27 #1 in ExecNode::ExecDebugAction(TExecNodePhase::type, RuntimeState*) exec/exec-node.h:379:12 #2 in ExecNode::Prepare(RuntimeState*) exec/exec-node.cc:106:43 #3 in TopNNode::Prepare(RuntimeState*) exec/topn-node.cc:75:53 Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 --- M be/src/exec/exec-node.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 3 files changed, 23 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/13769/2 -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13769 Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSAN-clean According to [expr.post] in the C++14 standard, a call to a member function like a->b() is interpreted as (a->b)(). In other words, the dereferencing is done separately from the call. This makes calling member functions on nullptr undefined behavior, since the dereference invokes undefined behavior. This fixes such an error in exec-node.cc in the end-to-end tests. The interesting part of the backtrace is: exec/exec-node.cc:396:27: runtime error: member call on null pointer of type 'MemTracker' #0 in ExecNode::ExecDebugActionImpl(TExecNodePhase::type, RuntimeState*) exec/exec-node.cc:396:27 #1 in ExecNode::ExecDebugAction(TExecNodePhase::type, RuntimeState*) exec/exec-node.h:379:12 #2 in ExecNode::Prepare(RuntimeState*) exec/exec-node.cc:106:43 #3 in TopNNode::Prepare(RuntimeState*) exec/topn-node.cc:75:53 Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 --- M be/src/exec/exec-node.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 3 files changed, 22 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/13769/1 -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13710/2/be/src/service/CMakeLists.txt@57 PS2, Line 57: target_link_libraries(fesupport "-Wl,--whole-archive \ > Can you indent the code inside the if? We generally do this in CMake files. Done -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 25 Jun 2019 03:53:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#3). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/3 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13710 ) Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. Patch Set 2: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4524/ This looks to me like https://issues.apache.org/jira/browse/IMPALA-8700 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 24 Jun 2019 01:10:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13710 to look at the new patch set (#2). Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt M bin/impala-config.sh 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/2 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5031: link fesupport so FE tests run with UBSAN
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13710 Change subject: IMPALA-5031: link fesupport so FE tests run with UBSAN .. IMPALA-5031: link fesupport so FE tests run with UBSAN This commit enables the frontend and JDBC tests to run under UBSAN. Before this comit, they fail with an error message about finding the UBSAN support functions like __ubsan_handle_load_invalid_value. Linking those functions into libfesupport.so requires using the linker flag --whole-archive so that these symbols, which are not directly referenced by the source code used to build libfesupport.so, are included. This patch also enables the custom cluster tests to run under UBSAN; they recently gained frontend tests in commit d72f3330c1edc9086ba120e6d3469a75c0aea083. Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 --- M be/src/service/CMakeLists.txt 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/13710/1 -- To view, visit http://gerrit.cloudera.org:8080/13710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42049fb3e2de83aee0d0e00e2703788afde739e2 Gerrit-Change-Number: 13710 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13437 ) Change subject: IMPALA-5031: signed overflow is undefined behavior .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13437/1/be/src/util/arithmetic-util.h File be/src/util/arithmetic-util.h: http://gerrit.cloudera.org:8080/#/c/13437/1/be/src/util/arithmetic-util.h@117 PS1, Line 117: // This operator makes that behavior defined by doing it in the unsigned domain. > Maybe document exactly what this implies - my understand is that negating t Done -- To view, visit http://gerrit.cloudera.org:8080/13437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73dd6802ec1023275d09a99a2950f3558313fc8e Gerrit-Change-Number: 13437 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 09 Jun 2019 15:53:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13437 to look at the new patch set (#2). Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior Fix remaining signed overflow undefined behaviors in end-to-end tests. The interesting part of the backtraces: exprs/aggregate-functions-ir.cc:464:25: runtime error: signed integer overflow: 0x5a4728ca063b522c0b728f80 + 0x3c2f7086aed236c807a1b500 cannot be represented in type '__int128' #0 AggregateFunctions::DecimalAvgMerge( impala_udf::FunctionContext*, impala_udf::StringVal const&, impala_udf::StringVal*) exprs/aggregate-functions-ir.cc:464:25 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 exprs/aggregate-functions-ir.cc:513:12: runtime error: signed integer overflow: -8282081183197145958 + -4473782455107795527 cannot be represented in type 'long' #0 void AggregateFunctions::SumUpdate(impala_udf::FunctionContext*, impala_udf::BigIntVal const&, impala_udf::BigIntVal*) exprs/aggregate-functions-ir.cc:513:12 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 exprs/aggregate-functions-ir.cc:585:14: runtime error: signed integer overflow: 0x5a4728ca063b522c0b728f80 + 0x3c2f7086aed236c807a1b500 cannot be represented in type '__int128' #0 AggregateFunctions::SumDecimalMerge( impala_udf::FunctionContext*, impala_udf::DecimalVal const&, impala_udf::DecimalVal*) exprs/aggregate-functions-ir.cc:585:14 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 runtime/decimal-value.inline.h:145:12: runtime error: signed integer overflow: 18 * 0x0785ee10d5da46d900f436a0 cannot be represented in type '__int128' #0 DecimalValue<__int128>::ScaleTo(int, int, int, bool*) const runtime/decimal-value.inline.h:145:12 #1 DecimalOperators::ScaleDecimalValue( impala_udf::FunctionContext*, DecimalValue const&, int, int, int) exprs/decimal-operators-ir.cc:132:41 #2 DecimalOperators::RoundDecimal(impala_udf::FunctionContext*, impala_udf::DecimalVal const&, int, int, int, int, DecimalOperators::DecimalRoundOp const&) exprs/decimal-operators-ir.cc:465:16 #3 DecimalOperators::RoundDecimal(impala_udf::FunctionContext*, impala_udf::DecimalVal const&, DecimalOperators::DecimalRoundOp const&) exprs/decimal-operators-ir.cc:519:10 #4 DecimalOperators::CastToDecimalVal( impala_udf::FunctionContext*, impala_udf::DecimalVal const&) exprs/decimal-operators-ir.cc:529:10 #5 impala_udf::DecimalVal ScalarFnCall::InterpretEval (ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:485:208 #6 ScalarFnCall::GetDecimalVal(ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:618:44 #7 ScalarExprEvaluator::GetValue(ScalarExpr const&, TupleRow const*) exprs/scalar-expr-evaluator.cc:321:27 #8 ScalarExprEvaluator::GetValue(TupleRow const*) exprs/scalar-expr-evaluator.cc:251:10 #9 Java_org_apache_impala_service_FeSupport_NativeEvalExprsWithoutRow
[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13436 ) Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/13436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9362ce6b9ba470ed90e5bd2dc313b66ebd8c6af5 Gerrit-Change-Number: 13436 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 01 Jun 2019 20:05:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13436 to look at the new patch set (#3). Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. IMPALA-5031: NULL is undefined in memcpy and memcmp This patch fixes UBSAN "null pointer passed as argument" errors in the end-to-end tests. These are undefined behavior according to "7.1.4 Use of library functions" in the C99 standard (which is included in C++14 in section [intro.refs]): If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined. The interesting parts of the backtraces are: runtime/sorter.cc:575:18: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Sorter::Run::CopyVarLenData(vector const&, unsigned char*) runtime/sorter.cc:575:5 #1 Status Sorter::Run::AddBatchInternal(RowBatch*, int, int*) runtime/sorter.cc:232:11 #2 Sorter::Run::AddInputBatch(RowBatch*, int, int*) runtime/sorter.cc:660:12 #3 Sorter::AddBatchNoSpill(RowBatch*, int, int*) runtime/sorter.cc:882:58 #4 Sorter::AddBatch(RowBatch*) runtime/sorter.cc:862:45 #5 SortNode::SortInput(RuntimeState*) exec/sort-node.cc:177:54 #6 SortNode::Open(RuntimeState*) exec/sort-node.cc:90:43 runtime/tuple.cc:105:25: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, MemPool*) runtime/tuple.cc:105:5 #1 Tuple::DeepCopy(Tuple*, TupleDescriptor const&, MemPool*) runtime/tuple.cc:94:35 #2 Tuple::DeepCopy(TupleDescriptor const&, MemPool*) runtime/tuple.cc:85:3 #3 KrpcDataStreamSender::Channel::AddRow(TupleRow*) runtime/krpc-data-stream-sender.cc:509:43 #4 KrpcDataStreamSender::AddRowToChannel(int, TupleRow*) runtime/krpc-data-stream-sender.cc:846 #5 () runtime/tuple.cc:146:19: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:146:5 #1 Tuple::DeepCopy(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:135:35 #2 RowBatch::SerializeInternal(long, FixedSizeHashTable*, vector*, string*) runtime/row-batch.cc:392:14 #3 RowBatch::Serialize(bool, vector*, string*, long*, bool*) runtime/row-batch.cc:290:45 #4 RowBatch::Serialize(OutboundRowBatch*) runtime/row-batch.cc:259:43 #5 KrpcDataStreamSender::SerializeBatch(RowBatch*, OutboundRowBatch*, int) runtime/krpc-data-stream-sender.cc:955:50 #6 KrpcDataStreamSender::Send(RuntimeState*, RowBatch*) runtime/krpc-data-stream-sender.cc:870:45 runtime/tuple.h:106:12: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:62:79: note: nonnull attribute specified here #0 Tuple::ClearNullBits(int, int) runtime/tuple.h:106:5 #1 HdfsScanner::InitTuple(TupleDescriptor const*, Tuple*, Tuple*) exec/hdfs-scanner.h:512:14 #2 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:742:7 #3 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #4 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #5 OrcListReader::ReadChildrenValue(int, int, Tuple*, MemPool*) const exec/orc-column-readers.cc:473:52 #6 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:743:60 #7 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #8 OrcStructReader::TransferTuple(Tuple*, MemPool*) exec/orc-column-readers.cc:346:52 #9 HdfsOrcScanner::TransferTuples(OrcComplexColumnReader*, RowBatch*) exec/hdfs-orc-scanner.cc:669:58 #10 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:629:45 #11 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:507:19 #12 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:426:21
[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13438 ) Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. Patch Set 3: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4325/ Looks like a fluke to me. Rebuilt fine. Running pre-merge tests again, from the top -- To view, visit http://gerrit.cloudera.org:8080/13438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63379b4c9d2e4738e729a556108c77fed85e6b64 Gerrit-Change-Number: 13438 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 28 May 2019 15:22:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13438 ) Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. Patch Set 1: Hi Tim! After this patch is in, the custom cluster tests can be added to the UBSAN pre-merge Jenkins job. -- To view, visit http://gerrit.cloudera.org:8080/13438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63379b4c9d2e4738e729a556108c77fed85e6b64 Gerrit-Change-Number: 13438 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 26 May 2019 19:09:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enum values are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13438 Change subject: IMPALA-5031: Out-of-range enum values are undefined behavior .. IMPALA-5031: Out-of-range enum values are undefined behavior This patch handles an undefined behavior in the custom cluster tests in which a reference to an invalid enum value is used. To prevent the invalid value, the bytes are first copied into their underlying integer type. The undefined behavior happens in LdapJdbcTest. The relevant backtrace is: include/c++/4.9.2/bits/stl_algobase.h:199:11: runtime error: load of value 8, which is not a valid value for type 'const TProtocolVersion::type' #0 TProtocolVersion::type const& min(TProtocolVersion::type const&, TProtocolVersion::type const&) include/c++/4.9.2/bits/stl_algobase.h:199:11 #1 ImpalaServer::OpenSession(TOpenSessionResp&, TOpenSessionReq const&) service/impala-hs2-server.cc:304:24 #2 TCLIServiceProcessor::process_OpenSession(int, TProtocol*, TProtocol*, void*) generated-sources/gen-cpp/TCLIService.cpp:4953:13 #3 TCLIServiceProcessor::dispatchCall(TProtocol*, TProtocol*, string const&, int, void*) generated-sources/gen-cpp/TCLIService.cpp:4926:3 #4 ImpalaHiveServer2ServiceProcessor::dispatchCall(TProtocol*, TProtocol*, string const&, int, void*) generated-sources/gen-cpp/ImpalaHiveServer2Service.cpp:505:73 #5 thrift::TDispatchProcessor::process (boost::shared_ptr, boost::shared_ptr, void*) toolchain/thrift-0.9.3-p5/include/thrift/TDispatchProcessor.h:121:12 #6 thrift::server::TAcceptQueueServer::Task::run() rpc/TAcceptQueueServer.cpp:74:26 #7 ThriftThread::RunRunnable(boost::shared_ptr , Promise*) rpc/thrift-thread.cc:74:13 Change-Id: I63379b4c9d2e4738e729a556108c77fed85e6b64 --- M be/src/service/impala-hs2-server.cc 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/13438/1 -- To view, visit http://gerrit.cloudera.org:8080/13438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I63379b4c9d2e4738e729a556108c77fed85e6b64 Gerrit-Change-Number: 13438 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13436 to look at the new patch set (#2). Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. IMPALA-5031: NULL is undefined in memcpy and memcmp This patch fixes UBSAN "null pointer passed as argument" errors in the end-to-end tests. These are undefined behavior according to "7.1.4 Use of library functions" in the C99 standard (which is included in C++14 in section [intro.refs]): If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined. The interesting parts of the backtraces are: runtime/sorter.cc:575:18: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Sorter::Run::CopyVarLenData(vector const&, unsigned char*) runtime/sorter.cc:575:5 #1 Status Sorter::Run::AddBatchInternal(RowBatch*, int, int*) runtime/sorter.cc:232:11 #2 Sorter::Run::AddInputBatch(RowBatch*, int, int*) runtime/sorter.cc:660:12 #3 Sorter::AddBatchNoSpill(RowBatch*, int, int*) runtime/sorter.cc:882:58 #4 Sorter::AddBatch(RowBatch*) runtime/sorter.cc:862:45 #5 SortNode::SortInput(RuntimeState*) exec/sort-node.cc:177:54 #6 SortNode::Open(RuntimeState*) exec/sort-node.cc:90:43 runtime/tuple.cc:105:25: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, MemPool*) runtime/tuple.cc:105:5 #1 Tuple::DeepCopy(Tuple*, TupleDescriptor const&, MemPool*) runtime/tuple.cc:94:35 #2 Tuple::DeepCopy(TupleDescriptor const&, MemPool*) runtime/tuple.cc:85:3 #3 KrpcDataStreamSender::Channel::AddRow(TupleRow*) runtime/krpc-data-stream-sender.cc:509:43 #4 KrpcDataStreamSender::AddRowToChannel(int, TupleRow*) runtime/krpc-data-stream-sender.cc:846 #5 () runtime/tuple.cc:146:19: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:146:5 #1 Tuple::DeepCopy(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:135:35 #2 RowBatch::SerializeInternal(long, FixedSizeHashTable*, vector*, string*) runtime/row-batch.cc:392:14 #3 RowBatch::Serialize(bool, vector*, string*, long*, bool*) runtime/row-batch.cc:290:45 #4 RowBatch::Serialize(OutboundRowBatch*) runtime/row-batch.cc:259:43 #5 KrpcDataStreamSender::SerializeBatch(RowBatch*, OutboundRowBatch*, int) runtime/krpc-data-stream-sender.cc:955:50 #6 KrpcDataStreamSender::Send(RuntimeState*, RowBatch*) runtime/krpc-data-stream-sender.cc:870:45 runtime/tuple.h:106:12: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:62:79: note: nonnull attribute specified here #0 Tuple::ClearNullBits(int, int) runtime/tuple.h:106:5 #1 HdfsScanner::InitTuple(TupleDescriptor const*, Tuple*, Tuple*) exec/hdfs-scanner.h:512:14 #2 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:742:7 #3 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #4 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #5 OrcListReader::ReadChildrenValue(int, int, Tuple*, MemPool*) const exec/orc-column-readers.cc:473:52 #6 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:743:60 #7 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #8 OrcStructReader::TransferTuple(Tuple*, MemPool*) exec/orc-column-readers.cc:346:52 #9 HdfsOrcScanner::TransferTuples(OrcComplexColumnReader*, RowBatch*) exec/hdfs-orc-scanner.cc:669:58 #10 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:629:45 #11 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:507:19 #12 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:426:21 #13
[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13437 Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior Fix remaining signed overflow undefined behaviors in end-to-end tests. The interesting part of the backtraces: exprs/aggregate-functions-ir.cc:464:25: runtime error: signed integer overflow: 0x5a4728ca063b522c0b728f80 + 0x3c2f7086aed236c807a1b500 cannot be represented in type '__int128' #0 AggregateFunctions::DecimalAvgMerge( impala_udf::FunctionContext*, impala_udf::StringVal const&, impala_udf::StringVal*) exprs/aggregate-functions-ir.cc:464:25 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 exprs/aggregate-functions-ir.cc:513:12: runtime error: signed integer overflow: -8282081183197145958 + -4473782455107795527 cannot be represented in type 'long' #0 void AggregateFunctions::SumUpdate(impala_udf::FunctionContext*, impala_udf::BigIntVal const&, impala_udf::BigIntVal*) exprs/aggregate-functions-ir.cc:513:12 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 exprs/aggregate-functions-ir.cc:585:14: runtime error: signed integer overflow: 0x5a4728ca063b522c0b728f80 + 0x3c2f7086aed236c807a1b500 cannot be represented in type '__int128' #0 AggregateFunctions::SumDecimalMerge( impala_udf::FunctionContext*, impala_udf::DecimalVal const&, impala_udf::DecimalVal*) exprs/aggregate-functions-ir.cc:585:14 #1 AggFnEvaluator::Update(TupleRow const*, Tuple*, void*) exprs/agg-fn-evaluator.cc:327:7 #2 AggFnEvaluator::Add(TupleRow const*, Tuple*) exprs/agg-fn-evaluator.h:257:3 #3 Aggregator::UpdateTuple(AggFnEvaluator**, Tuple*, TupleRow*, bool) exec/aggregator.cc:167:24 #4 NonGroupingAggregator::AddBatchImpl(RowBatch*) exec/non-grouping-aggregator-ir.cc:27:5 #5 NonGroupingAggregator::AddBatch(RuntimeState*, RowBatch*) exec/non-grouping-aggregator.cc:124:45 #6 AggregationNode::Open(RuntimeState*) exec/aggregation-node.cc:70:57 runtime/decimal-value.inline.h:145:12: runtime error: signed integer overflow: 18 * 0x0785ee10d5da46d900f436a0 cannot be represented in type '__int128' #0 DecimalValue<__int128>::ScaleTo(int, int, int, bool*) const runtime/decimal-value.inline.h:145:12 #1 DecimalOperators::ScaleDecimalValue( impala_udf::FunctionContext*, DecimalValue const&, int, int, int) exprs/decimal-operators-ir.cc:132:41 #2 DecimalOperators::RoundDecimal(impala_udf::FunctionContext*, impala_udf::DecimalVal const&, int, int, int, int, DecimalOperators::DecimalRoundOp const&) exprs/decimal-operators-ir.cc:465:16 #3 DecimalOperators::RoundDecimal(impala_udf::FunctionContext*, impala_udf::DecimalVal const&, DecimalOperators::DecimalRoundOp const&) exprs/decimal-operators-ir.cc:519:10 #4 DecimalOperators::CastToDecimalVal( impala_udf::FunctionContext*, impala_udf::DecimalVal const&) exprs/decimal-operators-ir.cc:529:10 #5 impala_udf::DecimalVal ScalarFnCall::InterpretEval (ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:485:208 #6 ScalarFnCall::GetDecimalVal(ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:618:44 #7 ScalarExprEvaluator::GetValue(ScalarExpr const&, TupleRow const*) exprs/scalar-expr-evaluator.cc:321:27 #8 ScalarExprEvaluator::GetValue(TupleRow const*) exprs/scalar-expr-evaluator.cc:251:10 #9 Java_org_apache_impala_service_FeSupport_NativeEvalExprsWithoutRow service/fe-support.cc:246:26 #10 () runtime/multi-precision.h:116:21: runtime
[Impala-ASF-CR] IMPALA-5031: NULL is undefined in memcpy and memcmp
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13436 Change subject: IMPALA-5031: NULL is undefined in memcpy and memcmp .. IMPALA-5031: NULL is undefined in memcpy and memcmp This patch fixes UBSAN "null pointer passed as argument" errors in the end-to-end tests. These are undefined behavior according to "7.1.4 Use of library functions" in the C99 standard (which is included in C++14 in section [intro.refs]): If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined. The interesting parts of the backtraces are: runtime/sorter.cc:575:18: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Sorter::Run::CopyVarLenData(vector const&, unsigned char*) runtime/sorter.cc:575:5 #1 Status Sorter::Run::AddBatchInternal(RowBatch*, int, int*) runtime/sorter.cc:232:11 #2 Sorter::Run::AddInputBatch(RowBatch*, int, int*) runtime/sorter.cc:660:12 #3 Sorter::AddBatchNoSpill(RowBatch*, int, int*) runtime/sorter.cc:882:58 #4 Sorter::AddBatch(RowBatch*) runtime/sorter.cc:862:45 #5 SortNode::SortInput(RuntimeState*) exec/sort-node.cc:177:54 #6 SortNode::Open(RuntimeState*) exec/sort-node.cc:90:43 runtime/tuple.cc:105:25: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, MemPool*) runtime/tuple.cc:105:5 #1 Tuple::DeepCopy(Tuple*, TupleDescriptor const&, MemPool*) runtime/tuple.cc:94:35 #2 Tuple::DeepCopy(TupleDescriptor const&, MemPool*) runtime/tuple.cc:85:3 #3 KrpcDataStreamSender::Channel::AddRow(TupleRow*) runtime/krpc-data-stream-sender.cc:509:43 #4 KrpcDataStreamSender::AddRowToChannel(int, TupleRow*) runtime/krpc-data-stream-sender.cc:846 #5 () runtime/tuple.cc:146:19: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 Tuple::DeepCopyVarlenData(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:146:5 #1 Tuple::DeepCopy(TupleDescriptor const&, char**, int*, bool) runtime/tuple.cc:135:35 #2 RowBatch::SerializeInternal(long, FixedSizeHashTable*, vector*, string*) runtime/row-batch.cc:392:14 #3 RowBatch::Serialize(bool, vector*, string*, long*, bool*) runtime/row-batch.cc:290:45 #4 RowBatch::Serialize(OutboundRowBatch*) runtime/row-batch.cc:259:43 #5 KrpcDataStreamSender::SerializeBatch(RowBatch*, OutboundRowBatch*, int) runtime/krpc-data-stream-sender.cc:955:50 #6 KrpcDataStreamSender::Send(RuntimeState*, RowBatch*) runtime/krpc-data-stream-sender.cc:870:45 runtime/tuple.h:106:12: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:62:79: note: nonnull attribute specified here #0 Tuple::ClearNullBits(int, int) runtime/tuple.h:106:5 #1 HdfsScanner::InitTuple(TupleDescriptor const*, Tuple*, Tuple*) exec/hdfs-scanner.h:512:14 #2 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:742:7 #3 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #4 OrcStructReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:322:52 #5 OrcListReader::ReadChildrenValue(int, int, Tuple*, MemPool*) const exec/orc-column-readers.cc:473:52 #6 HdfsOrcScanner::AssembleCollection(OrcComplexColumnReader const&, int, CollectionValueBuilder*) exec/hdfs-orc-scanner.cc:743:60 #7 OrcCollectionReader::ReadValue(int, Tuple*, MemPool*) exec/orc-column-readers.cc:375:20 #8 OrcStructReader::TransferTuple(Tuple*, MemPool*) exec/orc-column-readers.cc:346:52 #9 HdfsOrcScanner::TransferTuples(OrcComplexColumnReader*, RowBatch*) exec/hdfs-orc-scanner.cc:669:58 #10 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:629:45 #11 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:507:19 #12 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:426:21 #13 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*,
[Impala-ASF-CR] IMPALA-5031: memcpy requires two non-null arguments
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13434 Change subject: IMPALA-5031: memcpy requires two non-null arguments .. IMPALA-5031: memcpy requires two non-null arguments Counterintuitively, even passing 0 as the third argument of memcpy does not avoid undefined behavior. This occurred during an end-to-end test. The interesting part of the backtrace is: util/dict-encoding.h:451:20: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:45: note: nonnull attribute specified here #0 DictEncoder::AddToTable(StringValue const&, unsigned short*) util/dict-encoding.h:451:3 #1 DictEncoder::Put(StringValue const&) util/dict-encoding.h:422:10 #2 HdfsParquetTableWriter::ColumnWriter:: ProcessValue(void*, long*) exec/parquet/hdfs-parquet-table-writer.cc:436:38 #3 HdfsParquetTableWriter::BaseColumnWriter::AppendRow(TupleRow*) exec/parquet/hdfs-parquet-table-writer.cc:662:9 #4 HdfsParquetTableWriter::AppendRows(RowBatch*, vector const&, bool*) exec/parquet/hdfs-parquet-table-writer.cc:1192:60 #5 HdfsTableSink::WriteRowsToPartition(RuntimeState*, RowBatch*, pair, vector>*) exec/hdfs-table-sink.cc:253:71 #6 HdfsTableSink::Send(RuntimeState*, RowBatch*) exec/hdfs-table-sink.cc:588:45 Change-Id: I2e8e57c34c2848f0dc7dbf32892cc6e86df63506 --- M be/src/util/dict-encoding.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13434/1 -- To view, visit http://gerrit.cloudera.org:8080/13434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e8e57c34c2848f0dc7dbf32892cc6e86df63506 Gerrit-Change-Number: 13434 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13433 Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior This undefined behavior was caught with UBSAN in the end-to-end tests. The interesting part of the backtrace is: gutil/atomicops-internals-x86.h:283:15: runtime error: signed integer overflow: -9223370395229620599 + -9223371946660462582 cannot be represented in type 'long' #0 base::subtle::Barrier_AtomicIncrement(long volatile*, long) gutil/atomicops-internals-x86.h:283:15 #1 internal::AtomicInt::Add(long) common/atomic.h:93:12 #2 RuntimeProfile::Counter::Add(long) util/runtime-profile.h:93 #3 HdfsOrcScanner::AssembleRows(RowBatch*) exec/hdfs-orc-scanner.cc:636:50 #4 HdfsOrcScanner::GetNextInternal(RowBatch*) exec/hdfs-orc-scanner.cc:507:19 #5 HdfsOrcScanner::ProcessSplit() exec/hdfs-orc-scanner.cc:426:21 #6 HdfsScanNode::ProcessSplit(vector const&, MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21 #7 HdfsScanNode::ScannerThread(bool, long) exec/hdfs-scan-node.cc:415:7 #8 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*):: $_0::operator()() const exec/hdfs-scan-node.cc:337:13 Change-Id: Ic638ff4959eaaffc79caa3453dbccaaabcbe95c9 --- M be/src/gutil/atomicops-internals-x86.h 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/13433/1 -- To view, visit http://gerrit.cloudera.org:8080/13433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic638ff4959eaaffc79caa3453dbccaaabcbe95c9 Gerrit-Change-Number: 13433 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] [DOCS] Removed the enterprise-specific links and versions
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13392 ) Change subject: [DOCS] Removed the enterprise-specific links and versions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I265d0c67418d6cde66a02d4eb20ba0fbba0e8636 Gerrit-Change-Number: 13392 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 22 May 2019 04:17:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8116: [DOCS] A new doc for Impala Scaling Limits
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13277 ) Change subject: IMPALA-8116: [DOCS] A new doc for Impala Scaling Limits .. Patch Set 5: (1 comment) Let's keep Impala documentation about Apache Impala. http://gerrit.cloudera.org:8080/#/c/13277/5/docs/topics/impala_scaling_limits.xml File docs/topics/impala_scaling_limits.xml: http://gerrit.cloudera.org:8080/#/c/13277/5/docs/topics/impala_scaling_limits.xml@67 PS5, Line 67: 80 nodes in CDH 5.14 and lower CDH is a Cloudera product. Can you remove this in a follow-on patch, please? Same goes for the cloudera.com reference below. -- To view, visit http://gerrit.cloudera.org:8080/13277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6df672e5de1fb2d34f6b78524e8f20e85ea34fb Gerrit-Change-Number: 13277 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 May 2019 04:20:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Allow running backend tests sharded and in parallel
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 ) Change subject: Allow running backend tests sharded and in parallel .. Patch Set 2: (1 comment) Thanks, I'm hopeful this will bring UBSAN_FULL down to usable latency! http://gerrit.cloudera.org:8080/#/c/13290/2/bin/run-backend-tests.sh File bin/run-backend-tests.sh: http://gerrit.cloudera.org:8080/#/c/13290/2/bin/run-backend-tests.sh@31 PS2, Line 31: S `NUM_PROC`. Otherwise breaks as in https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/5811/console /home/ubuntu/Impala/bin/run-backend-tests.sh: line 32: NUM_PROC: unbound variable -- To view, visit http://gerrit.cloudera.org:8080/13290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d44475e3f5a45c806f00d5003eeadf59683b009 Gerrit-Change-Number: 13290 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Sun, 19 May 2019 19:32:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 4: > Uploaded patch set 4. This has no benchmark implications -- To view, visit http://gerrit.cloudera.org:8080/11919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaad158e6634314a5690a43a0cc04426c1aba8f41 Gerrit-Change-Number: 11919 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Sat, 27 Apr 2019 23:21:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue
Jim Apple has uploaded a new patch set (#4) to the change originally created by Jim Apple. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. IMPALA-5031: signed overflow in TimestampValue The standard says that overflow for signed arithmetic operations is undefined behavior; see [expr]: If during the evaluation of an expression, the result is not mathematically defined or not in the range of representable values for its type, the behavior is undefined. This patch fixes a signed overflow with the folowing backtrace (uninteresting parts elided): runtime/timestamp-value.inline.h:67:13: runtime error: signed integer overflow: -9223372036854775808 + -9223372037 cannot be represented in type 'long' #0 TimestampValue::FromUnixTimeNanos(long, long, cctz::time_zone const&) runtime/timestamp-value.inline.h:67:13 #1 TimestampValue::FromSubsecondUnixTime(double, cctz::time_zone const&) runtime/timestamp-value.inline.h:62:10 #2 CastFunctions::CastToTimestampVal(impala_udf::FunctionContext*, impala_udf::FloatVal const&) exprs/cast-functions-ir.cc:248:172 #3 impala_udf::TimestampVal ScalarFnCall::InterpretEval(ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:485:208 #4 ScalarFnCall::GetTimestampVal(ScalarExprEvaluator*, TupleRow const*) const exprs/scalar-fn-call.cc:608:44 #5 ScalarExprEvaluator::GetValue(ScalarExpr const&, TupleRow const*) exprs/scalar-expr-evaluator.cc:314:41 #6 ScalarExprEvaluator::GetValue(TupleRow const*) exprs/scalar-expr-evaluator.cc:250:10 #7 void Tuple::MaterializeExprs(TupleRow*, TupleDescriptor const&, ScalarExprEvaluator* const*, MemPool*, StringValue**, int*, int*) runtime/tuple.cc:222:27 #8 void Tuple::MaterializeExprs(TupleRow*, TupleDescriptor const&, vector const&, MemPool*, vector*, int*) runtime/tuple.h:174:5 #9 UnionNode::MaterializeExprs(vector const&, TupleRow*, unsigned char*, RowBatch*) exec/union-node-ir.cc:29:14 #10 UnionNode::GetNextConst(RuntimeState*, RowBatch*) exec/union-node.cc:263:5 #11 UnionNode::GetNext(RuntimeState*, RowBatch*, bool*) exec/union-node.cc:296:45 This was seen in the backend test ExprTest.CastExprs. Change-Id: Iaad158e6634314a5690a43a0cc04426c1aba8f41 --- M be/src/runtime/timestamp-value.inline.h 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/11919/4 -- To view, visit http://gerrit.cloudera.org:8080/11919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaad158e6634314a5690a43a0cc04426c1aba8f41 Gerrit-Change-Number: 11919 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Jim Apple
[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12910/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12910/1//COMMIT_MSG@9 PS1, Line 9: various : problems Is there a newer JIRA? The last I remember about this was years ago. -- To view, visit http://gerrit.cloudera.org:8080/12910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89a19c6fc29b7ac21e5d6174d490ddc8a6f9c0b Gerrit-Change-Number: 12910 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 03 Apr 2019 01:59:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line
Hello Lars Volker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#4). Change subject: Give each config change in bootstrap_system.sh its own line .. Give each config change in bootstrap_system.sh its own line If a config file like ~/.ssh/config does not end in a newline character, than the change to that file in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/4 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 4 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@303 PS3, Line 303: cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys && chmod 0600 ~/.ssh/authorized_keys > Is this file affected by the same issue? Good point. Updated here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Tue, 02 Apr 2019 02:28:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#3). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/3 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12900 to look at the new patch set (#2). Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/2 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Ensure ssh config change is on its own line
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12900 Change subject: Ensure ssh config change is on its own line .. Ensure ssh config change is on its own line If ~/.ssh/config does not end in a newline character, than the change in bootstrap_system.sh would get appended to the last line, causeing parsing of that line to fail. Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 --- M bin/bootstrap_system.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/1 -- To view, visit http://gerrit.cloudera.org:8080/12900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776 Gerrit-Change-Number: 12900 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
[Impala-ASF-CR] IMPALA-6826: Extend bootstrap system.sh to Ubuntu 18.04
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12893 ) Change subject: IMPALA-6826: Extend bootstrap_system.sh to Ubuntu 18.04 .. Patch Set 3: Code-Review+2 (1 comment) Thanks for doing this! I think it gets started setting up new Impala developers so they won't have to install a 3-year old Ubuntu version. http://gerrit.cloudera.org:8080/#/c/12893/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12893/3/bin/bootstrap_system.sh@107 PS3, Line 107: echo "This script only supports 16.04 or 18.04 of Ubuntu" >&2 nit: "... only supports Ubuntu 16.04 or 18.04" -- To view, visit http://gerrit.cloudera.org:8080/12893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad790f72ea6b62258aed2225eb7bdf79590c350f Gerrit-Change-Number: 12893 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sat, 30 Mar 2019 23:09:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should support flag names .. Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/12823/6/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12823/6/shell/option_parser.py@74 PS6, Line 74: option_dests[option.dest] = option You might want to check that option1.dest is never equal to any option2._long_opts unless option1 == option2. http://gerrit.cloudera.org:8080/#/c/12823/6/tests/shell/good_impalarc File tests/shell/good_impalarc: http://gerrit.cloudera.org:8080/#/c/12823/6/tests/shell/good_impalarc@4 PS6, Line 4: ' nit: stray character? -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Thu, 28 Mar 2019 02:00:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12823/5/tests/shell/good_impalarc File tests/shell/good_impalarc: PS5: If this breaks existing .impalarc files, I'd prefer to wait until 4.0. -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Wed, 27 Mar 2019 03:26:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/3/bin/bootstrap_system.sh@239 PS3, Line 239: # The following wget command determines if we're running in aws I'd suggest something like "EC2 nodes expose this IP address internally as a way to gather instance metadata. The assumption is that only AWS nodes do this". -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Thu, 21 Mar 2019 18:55:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12779 ) Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Remove company affiliations: concerns of ASF trademarks@ Change-Id: I3164eb9d8bededc1c298e9c6853cb7a7dee02eb8 Reviewed-on: http://gerrit.cloudera.org:8080/12779 Reviewed-by: Thomas Marshall Tested-by: Jim Apple --- M index.html 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Thomas Marshall: Looks good to me, approved Jim Apple: Verified -- To view, visit http://gerrit.cloudera.org:8080/12779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: merged Gerrit-Change-Id: I3164eb9d8bededc1c298e9c6853cb7a7dee02eb8 Gerrit-Change-Number: 12779 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12779 Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Remove company affiliations: concerns of ASF trademarks@ Change-Id: I3164eb9d8bededc1c298e9c6853cb7a7dee02eb8 --- M index.html 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/12779/1 -- To view, visit http://gerrit.cloudera.org:8080/12779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: I3164eb9d8bededc1c298e9c6853cb7a7dee02eb8 Gerrit-Change-Number: 12779 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR](asf-site) Remove company affiliations: concerns of ASF trademarks@
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12779 ) Change subject: Remove company affiliations: concerns of ASF trademarks@ .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I3164eb9d8bededc1c298e9c6853cb7a7dee02eb8 Gerrit-Change-Number: 12779 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 18 Mar 2019 18:37:32 + Gerrit-HasComments: No
[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG@9 PS2, Line 9: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html That says "check the instance identity document, including its signature". Does this patch do that? I don't see it, but maybe wget does that? -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 15 Mar 2019 23:40:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > > I like the current solution, but I think that it should break > > several tests in timestamp-test.cc, for example > > https://github.com/apache/impala/blob/ecf12bec42e11262b88dc0993e375fe4d8acaafb/be/src/runtime/timestamp-test.cc#L290 > > Earlier, you said, "I would prefer to avoid the overflow by > changing the interface to handle nanos only in the -999'999'999 .. > + 999'999'999 range, and treat other values as invalid timestamps." > > I gather from this that you would prefer to alter the test to meet > this restriction than you would to widen the allowed values in > FromUnixTimeNanos? As another comment: if changing the semantics has subtleties, I'd MUCH rather keep the semantics the same, altering only the path where there is undefined behavior, even for a marginal slowdown. -- To view, visit http://gerrit.cloudera.org:8080/11919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaad158e6634314a5690a43a0cc04426c1aba8f41 Gerrit-Change-Number: 11919 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 11 Mar 2019 22:42:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: > I like the current solution, but I think that it should break > several tests in timestamp-test.cc, for example > https://github.com/apache/impala/blob/ecf12bec42e11262b88dc0993e375fe4d8acaafb/be/src/runtime/timestamp-test.cc#L290 Earlier, you said, "I would prefer to avoid the overflow by changing the interface to handle nanos only in the -999'999'999 .. + 999'999'999 range, and treat other values as invalid timestamps." I gather from this that you would prefer to alter the test to meet this restriction than you would to widen the allowed values in FromUnixTimeNanos? -- To view, visit http://gerrit.cloudera.org:8080/11919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaad158e6634314a5690a43a0cc04426c1aba8f41 Gerrit-Change-Number: 11919 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Comment-Date: Mon, 11 Mar 2019 22:37:31 + Gerrit-HasComments: No
