[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds new metrics for current version of catalog, current catalog 
topic version
and catalog service id which are currently used by impala daemon.

Testing:
Verified manually that the new metrics for catalog version, catalog topic 
version,
catalog service id are displayed and they corresponds to the latest version in
catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Reviewed-on: http://gerrit.cloudera.org:8080/8949
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
5 files changed, 62 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 11
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 10: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 10
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 07 Feb 2018 23:03:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1902/


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 10
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:25:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 9:

I was waiting for the GVO issues to quiet down. Will retry now.


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:24:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 10: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 10
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:24:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-07 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 9:

What's the status with this one? Why isn't it merged yet?


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:22:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-06 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 9: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 06 Feb 2018 22:44:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-05 Thread Pranay Singh (Code Review) 
Hello Dimitris Tsirogiannis, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8949

to look at the new patch set (#9).

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds new metrics for current version of catalog, current catalog 
topic version
and catalog service id which are currently used by impala daemon.

Testing:
Verified manually that the new metrics for catalog version, catalog topic 
version,
catalog service id are displayed and they corresponds to the latest version in
catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
5 files changed, 62 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8949/9
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 9
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-05 Thread Pranay Singh (Code Review) 
Pranay Singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 8:

> Looks like the API for Metric changed
 >
 > -fsanitize=thread -DTHREAD_SANITIZER -fverbose-asm -D_GNU_SOURCE
 > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
 > -fPIC   -fPIC -MD -MT 
 > be/src/service/CMakeFiles/Service.dir/impala-server.cc.o
 > -MF be/src/service/CMakeFiles/Service.dir/impala-server.cc.o.d -o
 > be/src/service/CMakeFiles/Service.dir/impala-server.cc.o -c
 > be/src/service/impala-server.cc
 > 01:58:23 ] be/src/service/impala-server.cc:1325:36: error: no
 > member named 'set_value' in 
 > 'impala::AtomicMetric';
 > did you mean 'SetValue'?
 > 01:58:23 ]   ImpaladMetrics::CATALOG_VERSION->set_value(catalog_version);
 > 01:58:23 ]^
 > 01:58:23 ]SetValue
 > 01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared
 > here
 > 01:58:23 ]   void SetValue(const int64_t& value) {
 > value_.Store(value); }
 > 01:58:23 ]^
 > 01:58:23 ] be/src/service/impala-server.cc:1326:42: error: no
 > member named 'set_value' in 
 > 'impala::AtomicMetric';
 > did you mean 'SetValue'?
 > 01:58:23 ]   
 > ImpaladMetrics::CATALOG_TOPIC_VERSION->set_value(catalog_topic_version);
 > 01:58:23 ]  ^
 > 01:58:23 ]  SetValue
 > 01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared
 > here
 > 01:58:23 ]   void SetValue(const int64_t& value) {
 > value_.Store(value); }
 > 01:58:23 ]^
 > 01:58:23 ] be/src/service/impala-server.cc:1327:39: error: no
 > member named 'set_value' in 'impala::LockedMetric impala::TMetricKind::type::PROPERTY>'; did you mean 'SetValue'?
 > 01:58:23 ]   
 > ImpaladMetrics::CATALOG_SERVICE_ID->set_value(PrintId(catalog_service_id));
 > 01:58:23 ]   ^
 > 01:58:23 ]   SetValue
 > 01:58:23 ] be/src/util/metrics.h:197:8: note: 'SetValue' declared
 > here
 > 01:58:23 ]   void SetValue(const T& value) {
 > 01:58:23 ]^
 > 01:58:23 ] 3 errors generated.
 > 01:58:23 ] ninja: build stopped: subcommand failed.
 > 01:58:23 ] Error in /home/ubuntu/Impala/bin/make_impala.sh at line
 > 178: ${MAKE_CMD} ${MAKE_ARGS}

Yes the API for METRIC changed that caused it to fail I have made the correction


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 06 Feb 2018 01:42:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-01 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 8:

Looks like the API for Metric changed

-fsanitize=thread -DTHREAD_SANITIZER -fverbose-asm -D_GNU_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC   
-fPIC -MD -MT be/src/service/CMakeFiles/Service.dir/impala-server.cc.o -MF 
be/src/service/CMakeFiles/Service.dir/impala-server.cc.o.d -o 
be/src/service/CMakeFiles/Service.dir/impala-server.cc.o -c 
be/src/service/impala-server.cc
01:58:23 ] be/src/service/impala-server.cc:1325:36: error: no member named 
'set_value' in 'impala::AtomicMetric'; did 
you mean 'SetValue'?
01:58:23 ]   ImpaladMetrics::CATALOG_VERSION->set_value(catalog_version);
01:58:23 ]^
01:58:23 ]SetValue
01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared here
01:58:23 ]   void SetValue(const int64_t& value) { value_.Store(value); }
01:58:23 ]^
01:58:23 ] be/src/service/impala-server.cc:1326:42: error: no member named 
'set_value' in 'impala::AtomicMetric'; did 
you mean 'SetValue'?
01:58:23 ]   
ImpaladMetrics::CATALOG_TOPIC_VERSION->set_value(catalog_topic_version);
01:58:23 ]  ^
01:58:23 ]  SetValue
01:58:23 ] be/src/util/metrics.h:233:8: note: 'SetValue' declared here
01:58:23 ]   void SetValue(const int64_t& value) { value_.Store(value); }
01:58:23 ]^
01:58:23 ] be/src/service/impala-server.cc:1327:39: error: no member named 
'set_value' in 'impala::LockedMetric'; did you mean 'SetValue'?
01:58:23 ]   
ImpaladMetrics::CATALOG_SERVICE_ID->set_value(PrintId(catalog_service_id));
01:58:23 ]   ^
01:58:23 ]   SetValue
01:58:23 ] be/src/util/metrics.h:197:8: note: 'SetValue' declared here
01:58:23 ]   void SetValue(const T& value) {
01:58:23 ]^
01:58:23 ] 3 errors generated.
01:58:23 ] ninja: build stopped: subcommand failed.
01:58:23 ] Error in /home/ubuntu/Impala/bin/make_impala.sh at line 178: 
${MAKE_CMD} ${MAKE_ARGS}


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Feb 2018 22:00:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1849/


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Feb 2018 01:58:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Jan 2018 23:53:46 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1849/


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Jan 2018 23:53:55 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-22 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 6:

Is this ready to merge?


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 6
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 23 Jan 2018 00:56:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-19 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 6
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Fri, 19 Jan 2018 23:50:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 5:

(8 comments)

A few renames on the metric labels.

http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/service/impala-server.cc@1322
PS5, Line 1322: /// Update the metrics to store the current version of catalog, 
catalog topic version,
  : /// and catalog service id which are used by impalad.
remove comment. You already have the same comment in .h file.


http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/5/be/src/util/impalad-metrics.h@123
PS5, Line 123:
nit: remove extra line


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json
File common/thrift/metrics.json:

http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@233
PS5, Line 233: Version of the catalog which is currently with impalad
"Catalog topic update version."


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@237
PS5, Line 237: Catalog version Impalad
"Catalog topic update version"


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@243
PS5, Line 243: ersion of the catalog topic which is currently with impalad.
"Statestore topic update version."


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@247
PS5, Line 247: Catalog topic Impalad
"Statestore topic update version"


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@253
PS5, Line 253: Service id of catalog which is currently with impalad.
"Catalog service id"


http://gerrit.cloudera.org:8080/#/c/8949/5/common/thrift/metrics.json@257
PS5, Line 257: Catalog ServiceID Impalad
"Catalog service id"



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 5
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Fri, 19 Jan 2018 05:40:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Pranay Singh (Code Review) 
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8949

to look at the new patch set (#5).

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds new metrics for current version of catalog, current catalog 
topic version
and catalog service id which are currently used by impala daemon.

Testing:
Verified manually that the new metrics for catalog version, catalog topic 
version,
catalog service id are displayed and they corresponds to the latest version in
catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
5 files changed, 66 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8949/5
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 5
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 3:

(6 comments)

impala-server.cc has 309 edited lines. That doesn't make sense. You may want to 
check your rebase.

http://gerrit.cloudera.org:8080/#/c/8949/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8949/3//COMMIT_MSG@9
PS3, Line 9: the current version of catalog
nit: update topic message, we have more metrics with the latest patch


http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/service/impala-server.h@1000
PS3, Line 1000: /// Update the metric to store the current version of catalog 
used by impalad.
comment doesn't seem to reflect the function implementation, plz update


http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/util/impalad-metrics.h@112
PS3, Line 112: Catalog
nit: catalog (lowercase)


http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/util/impalad-metrics.cc
File be/src/util/impalad-metrics.cc:

http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/util/impalad-metrics.cc@79
PS3, Line 79: const char* ImpaladMetricKeys::CATALOG_VERSION =
: "catalog.curr-version";
: const char* ImpaladMetricKeys::CATALOG_TOPIC_VERSION =
: "catalog.curr-topic";
: const char* ImpaladMetricKeys::CATALOG_SERVICE_ID =
: "catalog.curr-serviceid";
single lines (if they fit)


http://gerrit.cloudera.org:8080/#/c/8949/3/be/src/util/impalad-metrics.cc@249
PS3, Line 249:
Why not ""?


http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json
File common/thrift/metrics.json:

http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json@233
PS2, Line 233: The version of catalog which is currently with impal
> Changed
Are you sure?



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 3
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Thu, 18 Jan 2018 23:07:50 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Pranay Singh (Code Review) 
Pranay Singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h@978
PS2, Line 978: escriptorMap known_b
> UpdateCatalogVersionMetrics()
Changed the name of function.


http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc@1325
PS2, Line 1325: ImpaladMetrics::CATALOG_VERSION->set_value(catalog_version);
> Maybe my comment was not clear. What I meant is that you should also expose
I have made changes to expose catalog_topic version along with 
catalog_service_id


http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h@113
PS2, Line 113: CATALOG_VERSION;
> CATALOG_VERSION, CATALOG_TOPIC_VERSION, CATALOG_SERVICE_ID
Done


http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json
File common/thrift/metrics.json:

http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json@233
PS2, Line 233: The version of catalog which is currently with impal
> Maybe "Version of the Impalad catalog."
Changed



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 3
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Thu, 18 Jan 2018 19:22:20 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Pranay Singh (Code Review) 
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8949

to look at the new patch set (#3).

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds a new metric that shows the current version of catalog
which is currently used by impala daemon.

Testing:
Verified manually that the new metric for catalog version is displayed and it
corresponds to the latest version in catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
5 files changed, 67 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8949/3
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 3
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-17 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.h@978
PS2, Line 978: CatalogUpdateMetrics
UpdateCatalogVersionMetrics()


http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/service/impala-server.cc@1325
PS2, Line 1325: ImpaladMetrics::CATALOG_CURR_VER->set_value(catalog_version);
Maybe my comment was not clear. What I meant is that you should also expose the 
catalog_topic_version and the catalog_service_id as a metric.


http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/2/be/src/util/impalad-metrics.h@113
PS2, Line 113: CATALOG_CURR_VER
CATALOG_VERSION, CATALOG_TOPIC_VERSION, CATALOG_SERVICE_ID


http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json
File common/thrift/metrics.json:

http://gerrit.cloudera.org:8080/#/c/8949/2/common/thrift/metrics.json@233
PS2, Line 233: The catalog version which is currently with impalad.
Maybe "Version of the Impalad catalog."



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 2
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 17 Jan 2018 19:47:55 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-16 Thread Pranay Singh (Code Review) 
Hello Dimitris Tsirogiannis, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8949

to look at the new patch set (#2).

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds a new metric that shows the current version of catalog
which is currently used by impala daemon.

Testing:
Verified manually that the new metric for catalog version is displayed and it
corresponds to the latest version in catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
---
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
5 files changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8949/2
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 2
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-16 Thread Pranay Singh (Code Review) 
Pranay Singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1061
PS1, Line 1061: 
ImpaladMetrics::CATALOG_CURR_VER->set_value(catalog_update_info_.catalog_version);
> Are you sure you don't need the catalog_version_lock_ to access this here?
Changed the logic that takes the catalog_version_lock_ to update the newly 
added metric


http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1514
PS1, Line 1514:   
ImpaladMetrics::CATALOG_CURR_VER->set_value(min_req_catalog_version);
> I think this may not be necessary?
Removed it.


http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h@113
PS1, Line 113: CATALOG_CURR_VER
> Why not exposing all the information in CatalogUpdateVersionInfo?
Good suggestion added a new function CatalogUpdateMetrics in 
CatalogUpdateVersionInfo



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 1
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 16 Jan 2018 20:54:18 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-12 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1061
PS1, Line 1061: 
ImpaladMetrics::CATALOG_CURR_VER->set_value(catalog_update_info_.catalog_version);
Are you sure you don't need the catalog_version_lock_ to access this here?


http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/util/impalad-metrics.h@113
PS1, Line 113: CATALOG_CURR_VER
Why not exposing all the information in CatalogUpdateVersionInfo?



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 1
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 13 Jan 2018 00:33:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-09 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8949 )

Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/8949/1/be/src/service/impala-server.cc@1514
PS1, Line 1514:   
ImpaladMetrics::CATALOG_CURR_VER->set_value(min_req_catalog_version);
I think this may not be necessary?



--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 1
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 09 Jan 2018 23:05:13 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-05 Thread Pranay Singh (Code Review) 
Pranay Singh has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8949


Change subject: IMPALA-6075: Add Impala daemon metric for catalog version.
..

IMPALA-6075: Add Impala daemon metric for catalog version.

This patch adds a new metric that shows the current version of catalog
which is currently used by impala daemon.

Testing:
Verified manually that the new metric for catalog version is displayed and it
corresponds to the latest version in catalogd.INFO log file.

Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
---
M be/src/service/impala-server.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
4 files changed, 21 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/8949/1
--
To view, visit http://gerrit.cloudera.org:8080/8949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2307eb434561ed74ff058106541c0ebda017d97
Gerrit-Change-Number: 8949
Gerrit-PatchSet: 1
Gerrit-Owner: Pranay Singh