[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 13: (15 comments)

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-23 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. IMPALA-3671: Add query option to limit scratch space usage Currently we can only

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-23 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 10: (4 comments)

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#11). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

2016-09-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4531 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4531 Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests .. IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests The

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4419 to look at the new patch set (#7). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions

[Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings

2016-09-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4528 To

[Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings .. Patch Set 5: (3 comments) Thanks for the review, please see PS5.

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4497 To

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 1: (2 comments) This seems reasonable to me. I think we should get Alex Behm to confirm, since he

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#8). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings .. Patch Set 3: (6 comments) Thanks for the review. Please see PS3.

[Impala-ASF-CR] IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings .. IMPALA-4193: Warn when benchmarks run with sub-optimal CPU settings Change-Id:

[Impala-ASF-CR] WIP: Issue warnings when benchmarks run with sub-optimal system settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: WIP: Issue warnings when benchmarks run with sub-optimal system settings .. WIP: Issue warnings when benchmarks run with sub-optimal system settings This is

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3671: Add query option to limit scratch space usage .. IMPALA-3671: Add query option to limit scratch space usage Currently we can only disable spilling

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 1: (2 comments)

[Impala-ASF-CR] WIP: Issue warnings when benchmarks run with sub-optimal system settings

2016-09-23 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4528 Change subject: WIP: Issue warnings when benchmarks run with sub-optimal system settings .. WIP: Issue warnings when benchmarks run with

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (3 comments) Thanks! Not a full review yet. I still need to spend

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-23 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 1: The functional tests still fail with false positives like - CREATE TABLE functional_kudu.dimtbl

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-23 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has uploaded a new change for review. http://gerrit.cloudera.org:8080/4527 Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. IMPALA-784: Use `-s in SHOW CREATE TABLE output Change-Id:

[Impala-ASF-CR] IMPALA-4194: Bump version to 2.8.0

2016-09-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4194: Bump version to 2.8.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4525 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-23 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#12). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#13). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#13). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-23 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 12: (10 comments)

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC, i.e. utc timestamp()

2016-09-23 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#5). Change subject: IMPALA-3504: UDF for current timestamp in UTC, i.e. utc_timestamp() .. IMPALA-3504: UDF for current timestamp in UTC, i.e. utc_timestamp() Purpose: Returns the

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-09-23 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/4490/3//COMMIT_MSG Commit Message: Line 10: as a

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-09-23 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#4). Change subject: IMPALA-3504: UDF for current timestamp in UTC .. IMPALA-3504: UDF for current timestamp in UTC Purpose: Returns the current date and time (in the local time zone)

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-23 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 11: (26 comments) regarding testing: all tests