[Impala-ASF-CR] IMPALA-1788: Fold constant expressions.

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1788: Fold constant expressions. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5109 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/5047/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1788: Fold constant expressions.

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-1788: Fold constant expressions. .. IMPALA-1788: Fold constant expressions. Adds a new ExprRewriteRule for replacing constant expressions with their literal

[Impala-ASF-CR] IMPALA-1788: Fold constant expressions.

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1788: Fold constant expressions. .. Patch Set 2: (11 comments) Thanks for the speedy review, Marcel!

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. IMPALA-4510: Selectively filter args for metric verification tests

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5135 To

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 5: Code-Review+2 Test fix. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5151 to look at the new patch set (#5). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/4/be/src/runtime/runtime-state.h File

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. IMPALA-4000: Restricted Sentry authorization for Kudu Tables At this time, there is no

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: Sorry -- confusing typo. Correction below: "...we can't always

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: Dimitris, I spoke with Harrison about your question, and will

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables Since Kudu does not

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. IMPALA-4000: Restricted Sentry authorization for Kudu Tables At this time, there is no

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. IMPALA-4000: Restricted Sentry authorization for Kudu Tables At this time, there is no

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-22 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: I have tested that set max_audit_event_log_files to 1. That worked

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 7: Code-Review+2 meant to give this earlier... -- To

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5151 to look at the new patch set (#4). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4956 To unsubscribe,

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 6: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5136 to look at the new patch set (#6). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables ..

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 11: (9 comments)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4956 to look at the new patch set (#12). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory ..

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 12: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4956 To

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: Code-Review+2 Rebase. -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe,

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4893 to look at the new patch set (#4). Change subject: IMPALA-4410: Safer tear-down of RuntimeState ..

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. IMPALA-3342: Add thread counters to monitor plan fragment execution This

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4633 To

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 11: (9 comments)

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 3: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-22 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4833 to look at the new patch set (#7). Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5034

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5034/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-22 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. IMPALA-4450: qgen: use string concatenation operator for postgres queries The random

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-22 Thread Ishaan Joshi (Code Review)
Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5135 To

[Impala-ASF-CR] Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. Patch Set 2: (7 comments) Looks good overall. Still needs some additional tests. Let me

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 7: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5034/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5136 To unsubscribe,

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5125 To

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. TODO: - Corresponding

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4893 to look at the new patch set (#3). Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410:

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: Thanks, I'll check with Harrison. In the meantime, so that we

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. IMPALA-4516: Don't hold process wide lock

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1788: Fold constant expressions.

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1788: Fold constant expressions. .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/5109/2/be/src/exprs/literal.cc File

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. Patch Set 1: It was pointed out by Alex that this is a more general problem than just

[Impala-ASF-CR] Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables Since Kudu

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: I think we should try to be consistent in the way we

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 11: Code-Review+1 Rebased, carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4956 to look at the new patch set (#10). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory ..

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 11: Code-Review+2 Carrying Henry's +2 after rebase. -- To view, visit

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 2: functional_schema_template.sql seems to have tables

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. IMPALA-4283: Ensure Kudu-specific lineage and audit behavior With this commit we add

[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. Patch Set 1: (7 comments)

[Impala-ASF-CR] add ALTER TABLE / RECOVER PARTITION to the tpcds template file

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5187 Change subject: add ALTER TABLE / RECOVER PARTITION to the tpcds template file .. add ALTER TABLE / RECOVER PARTITION to the tpcds

[Impala-ASF-CR] separate snapshot upload as a definite function

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5181 Change subject: separate snapshot upload as a definite function .. separate snapshot upload as a definite function Change-Id:

[Impala-ASF-CR] correct generate files only check in bin/load-test.py

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: correct generate_files_only check in bin/load-test.py .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5184 To

[Impala-ASF-CR] add ALTER TABLE / RECOVER PARTITION to the tpcds template file

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: add ALTER TABLE / RECOVER PARTITION to the tpcds template file .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5187 To

[Impala-ASF-CR] filter command line args

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: filter command line args .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5186 To unsubscribe, visit

[Impala-ASF-CR] add ability to delete snapshot only to remote data load.py

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: add ability to delete snapshot only to remote_data_load.py .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5185 To

[Impala-ASF-CR] enable run tests temporarily

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: enable run_tests temporarily .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5183 To unsubscribe, visit

[Impala-ASF-CR] add option for generating SQL, but skipping actual data load

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: add option for generating SQL, but skipping actual data load .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5182 To

[Impala-ASF-CR] test Jim timezone changes

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: test Jim timezone changes .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5179 To unsubscribe, visit

[Impala-ASF-CR] add --user option to bin/load-data.py

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: add --user option to bin/load-data.py .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5180 To unsubscribe, visit

[Impala-ASF-CR] remove exploration strategy from remote data load.py

2016-11-22 Thread David Knupp (Code Review)
David Knupp has abandoned this change. Change subject: remove exploration strategy from remote_data_load.py .. Abandoned Pushed wrong branch by accident. -- To view, visit http://gerrit.cloudera.org:8080/5178 To unsubscribe,

[Impala-ASF-CR] correct generate files only check in bin/load-test.py

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5184 Change subject: correct generate_files_only check in bin/load-test.py .. correct generate_files_only check in bin/load-test.py Change-Id:

[Impala-ASF-CR] add option for generating SQL, but skipping actual data load

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5182 Change subject: add option for generating SQL, but skipping actual data load .. add option for generating SQL, but skipping actual data

[Impala-ASF-CR] enable run tests temporarily

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5183 Change subject: enable run_tests temporarily .. enable run_tests temporarily Change-Id: Ie074a83b999e5cf9af0e525a90fff66d2b6594c9 --- M

[Impala-ASF-CR] test Jim timezone changes

2016-11-22 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5179 Change subject: test Jim timezone changes .. test Jim timezone changes Change-Id: Ice5d7d7df666fa75ee96faaac9b57b0282aa7119 --- M

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5125 To unsubscribe,

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 4: (9 comments) Last round, we're pretty much done.

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-22 Thread anujphadke (Code Review)
Hello Henry Robinson, Internal Jenkins, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4633 to look at the new patch set (#11). Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 4: Code-Review+2 Rebase, carry +2. -- To

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 9: Any more comments? -- To view, visit http://gerrit.cloudera.org:8080/4956 To

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-11-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 10: Code-Review+2 Hi Anuj, this didn't commit because you didn't carry the +2

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. IMPALA-4432: Handle internal codegen disabling properly There are some conditions in

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5105 To unsubscribe,

[Impala-ASF-CR] IMPALA-4516: Don't hold process wide lock connection to sessions map lock while cancelling queries

2016-11-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4516: Don't hold process wide lock connection_to_sessions_map_lock_ while cancelling queries .. IMPALA-4516: Don't hold process wide lock

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Here's the commit that added CheckAndRotateLogFiles(). Please have

  1   2   >