Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Patch Set 7: Code-Review+2
Fixed the small issue with how we check if security is enabled.
Taras Bobrovytsky has uploaded a new patch set (#7).
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
IMPALA-4000: Restricted Sentry authorization for Kudu Tables
At this time, there is no
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5047
to look at the new patch set (#7).
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Alex Behm has posted comments on this change.
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5047
To unsubscribe,
Alex Behm has posted comments on this change.
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
Patch Set 4:
(6 comments)
Responding to comments. I'll wait for some of the larger changes
Bharath Vissapragada has uploaded a new patch set (#7).
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
This patch improves the
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
Patch Set 6:
(29 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 4: Verified-1
Build failed:
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Patch Set 7:
(1 comment)
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5047
to look at the new patch set (#7).
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5047
to look at the new patch set (#7).
Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
..
Dan Hecht has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 2:
Are any of these overflows legitimate use of signed overflows? Assuming not,
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
Once the Promise (of
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5244
To
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
IMPALA-4519: increase timeout in TestFragmentLifecycle
Increase the timeout to over 120s to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4956/14/be/src/codegen/llvm-codegen.h
Michael Ho has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4956/14/be/src/codegen/llvm-codegen.h
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5244
To
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 2:
> (1 comment)
Yeah, it's counterintuitive.
Given that new information, if I
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
The bugs was that the functions did not
Tim Armstrong has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt
Marcel Kornacker has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > I do not find it more readable, but I find it to be readable
> enough; I think the readability delta
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..
Patch Set 1: Verified-1
Build failed:
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > I do not find it more readable, but I find it to be readable
> enough; I think the readability delta is a
Mostafa Mokhtar has posted comments on this change.
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
Patch Set 6:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> I do not find it more readable, but I find it to be readable enough; I think
> the readability delta is a
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> I don't think we should never use it, but I think it is overkill for this use
> case
The alternative
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > It's the added hidden run-time complexity generally
>
> Can you be more specific? Abstractions naturally
Bharath Vissapragada has uploaded a new patch set (#5).
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
This patch improves the
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> It's the added hidden run-time complexity generally
Can you be more specific? Abstractions naturally hide
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> Am I right to summarise that your main objection is that
> std::function() heap allocates?
It's the added
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt
File
Tim Armstrong has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5246
To
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5246
To unsubscribe,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1:
A better fix could be to make the main thread call Join() on the build thread.
--
To
Jim Apple has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2:
> > Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/43/
>
> SOmething
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5246
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
I checked EMC++ and the ppt you linked to.
Am I right to summarise that your main objection is that
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
Patch Set 9: Code-Review+2
Rebase. Carry +2
--
To view, visit
Jim Apple has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2:
> Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/43/
SOmething went
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2:
Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/43/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 4:
Build started:
Jim Apple has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 4: Code-Review+2
(1 comment)
Carry Tim's +2
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5154
to look at the new patch set (#4).
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 1: Code-Review+2
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5243
To unsubscribe, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5244
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
IMPALA-4519: increase timeout in TestFragmentLifecycle
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5243
Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..
IMPALA-4542: Fix use-after-free in some BE tests
Change
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4363: Add Parquet timestamp validation
..
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4968/8/be/src/exec/parquet-column-readers.cc
File
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
This is a simpler
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5034
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 2:
(2 comments)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
Patch Set 4: Code-Review+1
rebase
--
To view, visit
56 matches
Mail list logo
