[Impala-ASF-CR] IMPALA-4765: Avoid using several loading threads on one table.

2017-01-13 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5707 to look at the new patch set (#2). Change subject: IMPALA-4765: Avoid using several loading threads on one table.

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5707/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-13 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: Release note updates for Impala 2.8 .. Release note updates for Impala 2.8 First cut at 'new features' topic. Includes the Incompatible Changes subtopic for

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC This

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 10: Code-Review+1 (3 comments) The patch looks good to me overall. Especially

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kutil library to the build.

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5715 Change subject: IMPALA-4669: [KUTIL] Add kutil library to the build. .. IMPALA-4669: [KUTIL] Add kutil library to the build. A few

[Impala-ASF-CR] IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5718 Change subject: IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8 .. IMPALA-4669: [KRPC] Import kudu/rpc from commit e1f68b8

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5719 Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5720 Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. IMPALA-4670 / IMPALA-4672: Add RpcMgr

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5714 Change subject: IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8 .. IMPALA-4669: [KUTIL] Copy kudu/util from commit e1f68b8

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add Kudu security library from commit e1f68b8

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5716 Change subject: IMPALA-4669: [SECURITY] Add Kudu security library from commit e1f68b8 .. IMPALA-4669: [SECURITY] Add Kudu security

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-01-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5717 Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build One

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#10). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#9). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 9: Added functional tests. -- To view, visit

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-13 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: Release note updates for Impala 2.8 .. Abandoned OK, got the CLUSTERED hint into the 5668 code review. -- To view, visit http://gerrit.cloudera.org:8080/5644 To

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5599 To unsubscribe,

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. IMPALA-4643: Centralize tags in separate .ditamap Patch set #2 to bring this gerrit

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: > I don't know if this CR becomes inaccessible after being abandoned. Reviews are still accessible after

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 6: And just to confirm that this works:

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-13 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: Code-Review-1 I need to rescue patch set #3 which is missing from 5668. I'll do that before abandoning this

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-13 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. Patch Set 3: Code-Review+2 (1 comment) Fixed the merge conflict and verified the result builds cleanly.

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/18/ -- To view,

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 4: Thanks for the comments (and the prodding.) The verification for

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-13 Thread David Knupp (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5177 to look at the new patch set (#6). Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-13 Thread David Knupp (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5177 to look at the new patch set (#5). Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-13 Thread John Russell (Code Review)
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5599 to look at the new patch set (#3). Change subject: IMPALA-4643: Centralize tags in separate .ditamap ..

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5667/3/blog/assets/js/html5.js File

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Clean up tags for 2 query options .. Clean up tags for 2 query options One query option was missing a tag. The other had a tag but it was

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Clean up tags for 2 query options .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5682 To unsubscribe, visit

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Clean up tags for 2 query options .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/17/ -- To view, visit

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-13 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Clean up tags for 2 query options .. Patch Set 1: Code-Review+2 Confirming based on independent review with doc contributor. -- To view, visit

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5710 Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: Also, to be clear, I don't think the race is a show-stopper, since this is a

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5707/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Improve logging of table loading.

2017-01-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Improve logging of table loading. .. Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/5709/1//COMMIT_MSG Commit Message: Line 7: Improve

[Impala-ASF-CR] Improve logging of table loading.

2017-01-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5709 Change subject: Improve logging of table loading. .. Improve logging of table loading. Changes the log level from trace to debug for

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5707 Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. IMPALA-4733: Avoid using several loading threads on one