[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-19 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 6: (36 comments) http://gerrit.cloudera.org:8080/#/c/5649/4/docs/topics/impala_invalidate_metadata.xml

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-19 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#6). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS] Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and other

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5710 To

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Add the query handle to error messages for Invalid Query Handle for beeswax interface.

2017-01-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. .. Patch Set 1: I was going to do that but I wasn't sure how to test the

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2017-01-19 Thread Anonymous Coward (Code Review)
Anonymous Coward #168 has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5491/4/be/src/runtime/data-stream-mgr.cc

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exec/hash-table-test.cc File

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 4: (12 comments) I had some high level comments. Still trying to understand the flow of execution

[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging

2017-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4775: minor adjustments to python test infra logging .. IMPALA-4775: minor adjustments to python test infra logging - Set up log handler

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Addressed the straightforward comments - we can discuss further in person. From my POV

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5739 to look at the new patch set (#4). Change subject: IMPALA-3748: add query-wide resource acquisition step ..

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 12: Also fix a clang warning when the return value from assert_debug_death is ignored --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 11: Rebased to pick up the WARN_UNUSED_RESULT changes -- To view, visit

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 9: (33 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. HIVE-15653

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5731 To

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

2017-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: removed 'without Cloudera Manager' from two titles .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5749/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: removed 'without Cloudera Manager' from two titles .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5749/1/docs/topics/impala_upgrading.xml File

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Code-Review-1 let's discuss in person before going ahead with it as-is. -- To view,

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (4 comments)

[Impala-ASF-CR] removed 'without Cloudera Manager' from two titles

2017-01-19 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/5749 Change subject: removed 'without Cloudera Manager' from two titles .. removed 'without Cloudera Manager' from two titles Change-Id:

[Impala-ASF-CR] Add the query handle to error messages for Invalid Query Handle for beeswax interface.

2017-01-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. .. Patch Set 1: (1 comment) Any chance you want to do the same thing

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks RECOVER PARTITIONS needs

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Verified+1 http://jenkins.impala.io:8080/job/parallel-all-tests/218/ -- To view,

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5745 To

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMPALA-3748: add query-wide resource acquisition step This adds a PrepareForExecution() method to

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. IMPALA-4449: Revisit table locking pattern in the catalog This commit fixes an issue where

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (14 comments)

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: > Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/ All

[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging

2017-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4775: minor adjustments to python test infra logging .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/199/

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5747/1/docs/topics/impala_known_issues.xml File

[Impala-ASF-CR] Add the query handle to error messages for Invalid Query Handle for beeswax interface.

2017-01-19 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5748 Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. .. Add the query handle to error

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4767: Workaround for HIVE-15653 to preserve table stats.

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4767: Workaround for HIVE-15653 to preserve table stats. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5731 To

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5747/1/docs/topics/impala_known_issues.xml File

[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4775: minor adjustments to python test infra logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5746 To unsubscribe,

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: (1 comment) Bharath, can you take a look?

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kutil library to the build.

2017-01-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kutil library to the build. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5747 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5747 Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. IMPALA-4778 IMPALA-1972: Add known issue Change-Id:

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5745 To

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/ -- To

[Impala-ASF-CR] IMPALA-4775: minor adjustments to python test infra logging

2017-01-19 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5746 Change subject: IMPALA-4775: minor adjustments to python test infra logging .. IMPALA-4775: minor adjustments to python test infra

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-19 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5745 Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4748 addendum: fix compile error from mid-air collision

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4748 addendum: fix compile error from mid-air collision .. IMPALA-4748 addendum: fix compile error from mid-air collision A patchset that was

[Impala-ASF-CR] IMPALA-4748 addendum: fix compile error from mid-air collision

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5744 Change subject: IMPALA-4748 addendum: fix compile error from mid-air collision .. IMPALA-4748 addendum: fix compile error from mid-air

[Impala-ASF-CR] IMPALA-4748 addendum: fix compile error from mid-air collision

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748 addendum: fix compile error from mid-air collision .. Patch Set 1: Code-Review+2 Verified+1 The fix is a trivial change that we'd normally carry a

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: Code-Review+1 (1 comment) The fix makes sense to me. We are doing a

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5743 Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. IMPALA-4789: Fix slow metadata loading due to