Henry Robinson has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. ......................................................................
Patch Set 1: (1 comment) Any chance you want to do the same thing for HS2? See impala-hs2-server.cc. http://gerrit.cloudera.org:8080/#/c/5748/1/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS1, Line 193: "Invalid query handle: " + handle.id try and avoid operator+ for strings - sometimes it doesn't do what you might expect. We prefer Substitute("Invalid query handle: $0", handle.id) -- To view, visit http://gerrit.cloudera.org:8080/5748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
