Zach Amsden has posted comments on this change.

Change subject: Add the query handle to error messages for Invalid Query Handle 
for beeswax interface.
......................................................................


Patch Set 1:

I was going to do that but I wasn't sure how to test the HS2 code path.  Also, 
is looks like there is more conversion to do on the HS2 query handle, looks 
like it is stored as bytes and the output should most likely be a hex UUID.  We 
wouldn't want to output the secret part of the handle I am guessing.

Was considering using boost::spirit::karma for that but this doesn't seem to be 
a common theme in the code yet (it should be - it's rather fast).

-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
Gerrit-HasComments: No

Reply via email to