[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 17: (8 comments) I'm pretty happy with the change. Only minor comment/naming issue left to fix.

[Impala-ASF-CR] IMPALA-5003: Generic constant propagation in planner

2017-03-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5003: Generic constant propagation in planner .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5003: Generic constant propagation in planner

2017-03-16 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5003: Generic constant propagation in planner .. Patch Set 3: (17 comments) No longer a draft. Now with tests!

[Impala-ASF-CR] IMPALA-5003: Generic constant propagation in planner

2017-03-16 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-5003: Generic constant propagation in planner .. IMPALA-5003: Generic constant propagation in planner Rather than specialize the constant propagation

[Impala-ASF-CR] IMPALA-5003: [DRAFT] Generic constant propagation in planner

2017-03-16 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-5003: [DRAFT] Generic constant propagation in planner .. IMPALA-5003: [DRAFT] Generic constant propagation in planner Rather than specialize the constant

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/6410/2//COMMIT_MSG Commit Message: Line 10: are

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3203: Part 1: Free list implementation .. IMPALA-3203: Part 1: Free list implementation We will have a single free list per size class. Free buffers are

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#17). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#17). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#17). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 16: (7 comments) http://gerrit.cloudera.org:8080/#/c/5816/9//COMMIT_MSG Commit Message: Line 15:

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-03-16 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5816 to look at the new patch set (#17). Change subject: IMPALA-3586: Implement union passthrough ..

[Impala-ASF-CR] IMPALA-5031: Suppress noisy UBSAN errors.

2017-03-16 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-5031: Suppress noisy UBSAN errors. .. IMPALA-5031: Suppress noisy UBSAN errors. The current version of the standard C++ library that Impala is often compiled

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/6410/2//COMMIT_MSG Commit Message: Line 10: are

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Pare down ODBC info .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6409 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Pare down ODBC info .. [DOCS] Pare down ODBC info Remove the Cloudera-specific portion of the Impala + ODBC page, leaving just the

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-16 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6372 to look at the new patch set (#4). Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Pare down ODBC info .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/102/ -- To view, visit

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/3/source/gflags/build.sh File

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-16 Thread Joe McDonnell (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6312 to look at the new patch set (#7). Change subject: IMPALA-4996: Single-threaded KuduScanNode

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode .. Patch Set 6: Rebased and fixed kudu-scan-node.cc to handle the case when there are no scan tokens. -- To view,

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 3: As discussed offline with dhecht, I removed the "policy" aspects of the implementation - these

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3203: Part 1: Free list implementation .. IMPALA-3203: Part 1: Free list implementation We will have a single free list per size class. Free buffers are

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5811 To

[Impala-ASF-CR] IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-16 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 1: Kicked off Jenkins job: impala-umbrella-build-and-test-s3/ -- To view, visit

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 17: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/386/

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5811 to look at the new patch set (#17). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5811 To

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 6: (1 comment)

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Pare down ODBC info .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6409 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] [DOCS] Remove references to DSSD storage appliance

2017-03-16 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Remove references to DSSD storage appliance .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6412/1//COMMIT_MSG Commit Message: PS1, Line 9:

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-partitioner.h

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 16: Verified-1 Build failed:

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread John Russell (Code Review)
Hello Greg Rahn, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6409 to look at the new patch set (#2). Change subject: [DOCS] Pare down ODBC info .. [DOCS] Pare down ODBC info Remove

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-16 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Pare down ODBC info .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6409/1/docs/topics/impala_odbc.xml File docs/topics/impala_odbc.xml:

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-16 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT In the catalog executor, we can

[Impala-ASF-CR] [DOCS] Remove references to DSSD storage appliance

2017-03-16 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/6412 Change subject: [DOCS] Remove references to DSSD storage appliance .. [DOCS] Remove references to DSSD storage appliance That's related

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-5003: [DRAFT] Generic constant propagation in planner

2017-03-16 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5003: [DRAFT] Generic constant propagation in planner .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 16: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/385/

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 16: Code-Review+2 Fix a couple of clang-tidy issues -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5811 to look at the new patch set (#16). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 15: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo .. IMPALA-5077: add NUMA and current cpu to CpuInfo NUMA info is found using the /sys

[Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6402 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/384/

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5811 to look at the new patch set (#15). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 15: Code-Review+2 Fix some test failures from the rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. IMPALA-4787: Optimize APPX_MEDIAN() memory usage Before this change, ReservoirSample

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6025 To unsubscribe,