[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#6). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: (21 comments)

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6768 to look at the new patch set (#3). Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp ..

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: There is still one thing that is not clear to me. Why is it allowed to do an ALTER TABLE with an

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6810 To unsubscribe,

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. IMPALA-3654: Parquet stats filtering for IN predicate This generates min/max

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 1: (6 comments) It's a trade off between coverage and test complexity. I can look into

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. IMPALA-5197: Erroneous corrupted Parquet file message The Parquet file column reader may fail in the middle

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-05 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6787/1/tests/query_test/test_scanners.py File

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 1: (1 comment) I'm not really sure if the added complexity to the test infra is warranted,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/6812 Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/537/ -- To

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6810 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (4 comments) Please see my inline comments, especially on

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/6526/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate

2017-05-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3654: Parquet stats filtering for IN predicate .. Patch Set 1: (6 comments)

[native-toolchain-CR] IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)

2017-05-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6672 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 1: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/536/ -- To view, visit

[Impala-ASF-CR] IMPALA-5197: Erroneous corrupted Parquet file message

2017-05-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5197: Erroneous corrupted Parquet file message .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6787/1/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-5120: Default to partitioned join when stats are missing

2017-05-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5120: Default to partitioned join when stats are missing .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (10 comments) getting close

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: [DRAFT] Don't hold QueryExecState::lock during planning

2017-05-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: [DRAFT] Don't hold QueryExecState::lock_ during planning .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4). Change subject: IMPALA-4623: Enable file handle cache .. IMPALA-4623: Enable file handle cache Currently, every scan range maintains a file handle, even when multiple scan ranges

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#20). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166:

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/536/ -- To view, visit

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp

2017-05-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. Patch Set 6: (22 comments) Thank you for your review. Please see PS6

[Impala-ASF-CR] IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types

2017-05-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for remaining types .. IMPALA-4815, IMPALA-4817, IMPALA-4819: Populate Parquet Statistics for