[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 5: Verified-1 Build failed:

Re: [Impala-ASF-CR] IMPALA-2525: Treat parquet ENUMs as STRINGs when creating impala tables.

2017-05-17 Thread Alexander Behm
Hey Jakub, did you want to continue with this patch? There are a couple of comments/questions on the CR. Thanks! Alex On Tue, May 16, 2017 at 8:39 AM, Jakub Kukul (Code Review) < ger...@cloudera.org> wrote: > Jakub Kukul has uploaded a new patch set (#4). > > Change subject: IMPALA-2525:

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. IMPALA-5333: Add support for Impala to work with ADLS This patch leverages the AdlFileSystem in Hadoop to

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 1: (12 comments) Thanks for the review, Matt.

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 2: (9 comments) Looks pretty good to me. I agree with Bharath's comments.

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/591/ --

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 5: Code-Review+2 rebase, carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-17 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#14). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. IMPALA-5301: Set Kudu minicluster memory limit By default, Kudu assumes it has 80% of system

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6844 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/6910/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 4: Code-Review+1 Ok, thanks. Let's see if Henry has any more comments. -- To

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 4: (1 comment) > Sorry, I meant any way to test/validate the error message >

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" We use the new libHDFS API

[Impala-ASF-CR] IMPALA-5286: Query fails due to Kudu column name case

2017-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5286: Query fails due to Kudu column name case .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5286: Query fails due to Kudu column name case

2017-05-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5286: Query fails due to Kudu column name case .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/590/ -- To view,

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Thanks Tim. I agree it could be useful to parametrize, though I figured I'd do that later if it

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 3: Sorry, I meant any way to test/validate the error message functionality itself,

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 3: > any way we can test this? I don't think there is a deterministic way to do

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 3: any way we can test this? -- To view, visit

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6894/2/be/src/util/hdfs-util.cc

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" We use the new libHDFS API

[Impala-ASF-CR] Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet"

2017-05-17 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet" .. Patch Set 1: > Was it a clean revert? If not, where were the conflicts?

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/6910 Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. IMPALA-5333: Add support for Impala to work with ADLS This

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Thanks, just wanted to sanity check the proposed config with you. -- To view, visit

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

2017-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Code-Review+1 Seems fine from the Kudu side. Not quite familiar enough with the test_kudu.py part

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 2: (6 comments) I have a few high level comments around the usability and error reporting.

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (BE)

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (BE) .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6792 To

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Patch Set 8: David, plz abandon or finish this. -- To view, visit

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6891 To

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures .. IMPALA-5319: Fix test_hdfs_scan_node_errors failures The recent Kudu TIMESTAMP patch

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-17 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6891 to look at the new patch set (#2). Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6891 To unsubscribe,

[Impala-ASF-CR] IMPALA-5319: Fix test hdfs scan node errors failures

2017-05-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5319: Fix test_hdfs_scan_node_errors failures .. Patch Set 1: Verified+1 gvo failed with an unrelated but known ddl error: IMPALA-5233 There were no

[Impala-ASF-CR] IMPALA-4890/5143: Coordinator race involving TearDown()

2017-05-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794 .. IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794 This

[Impala-ASF-CR] IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs.

2017-05-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5309: Adds TABLESAMPLE clause for HDFS table refs. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794 .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

2017-05-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794 .. Patch Set 2: Code-Review+2 Rebased, carrying Matthews's +2, Michael's +1. -- To view,

[Impala-ASF-CR] IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

2017-05-17 Thread Lars Volker (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6883 to look at the new patch set (#2). Change subject: IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

[Impala-ASF-CR] IMPALA-5174: Bump gflags to 2.2.0-p1

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5174: Bump gflags to 2.2.0-p1 .. IMPALA-5174: Bump gflags to 2.2.0-p1 This gflags patch adds DEFINE_int32_hidden() etc. macros, which

[Impala-ASF-CR] IMPALA-5174: Bump gflags to 2.2.0-p1

2017-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5174: Bump gflags to 2.2.0-p1 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6889 To unsubscribe, visit