[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 1: What is the perf implication of the backend changes? -- To view, visit

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7438 Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Bikramjeet Vig (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7419 to look at the new patch set (#4). Change subject: IMPALA-4276: Profile displays non-default query options set by planner

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#6). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8080/#/c/7400/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 3: Code-Review+1 (1 comment) LGTM with 1 small test change. Let's wait to

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Code-Review+1 Didn't mean to -1, feel free to carry my +1 once you

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: -Code-Review Sorry for holding this up, didn't realize it was

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/7267/6//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 6: Code-Review+1 (1 comment) LGTM aside from the variable name

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7418/1/CMakeLists.txt File

[Impala-ASF-CR] [SECURITY] Use KRPC's Kinit code to avoid expensive fork

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: [SECURITY] Use KRPC's Kinit code to avoid expensive fork .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7428 To unsubscribe, visit

[Impala-ASF-CR] Downgrade log level of "sampled call" message

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Downgrade log level of "sampled call" message .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7424 To unsubscribe, visit

[Impala-ASF-CR] [SECURITY] Enable MiniKdc and add kerberized BE tests

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: [SECURITY] Enable MiniKdc and add kerberized BE tests .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7427 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4671: Add Impala-native ServicePool

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: IMPALA-4671: Add Impala-native ServicePool .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7423 To unsubscribe, visit

[Impala-ASF-CR] Honor enable shared from this<> rule of sharing only pre-shared objects

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Honor enable_shared_from_this<> rule of sharing only pre-shared objects .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7433 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 6: (1 comment) > Can you extend the Sort metrics in the query profile to include > Avg, Min and

[Impala-ASF-CR] IMPALA-4875: Bound maximum statestore topic update size to 2GB.

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: IMPALA-4875: Bound maximum statestore topic update size to 2GB. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7425 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7418/1/CMakeLists.txt File

[Impala-ASF-CR] Add two-way negotiation thread pools

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Add two-way negotiation thread pools .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. IMPALA-5659: Begin standardizing treatment of thirdparty libraries If Impala was built

[Impala-ASF-CR] Disable Kerberos testing to unblock builds

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Disable Kerberos testing to unblock builds .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7429 To unsubscribe, visit

[Impala-ASF-CR] Test: change linking order for crypto and ssl

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Test: change linking order for crypto and ssl .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7431 To unsubscribe, visit

[Impala-ASF-CR] Unbreak the build

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: Unbreak the build .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[Impala-ASF-CR] IMPALA-5592: Fix computation of uncompressed row batch size

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: IMPALA-5592: Fix computation of uncompressed row batch size .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7434 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-5498: Support for partial sorts .. IMPALA-5498: Support for partial sorts Impala currently supports total sorts (the entire set of data is sorted)

[Impala-ASF-CR] [SECURITY] Make KRPC work with Kerberos

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: [SECURITY] Make KRPC work with Kerberos .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7426 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5659: Bump toolchain version

2017-07-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5659: Bump toolchain version .. IMPALA-5659: Bump toolchain version This bumps the toolchain version to include the fix which ensured

[Impala-ASF-CR] IMPALA-5659: Bump toolchain version

2017-07-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5659: Bump toolchain version .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7422 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#16). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC This patch

[Impala-ASF-CR] Unbreak the build

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7435 Change subject: Unbreak the build .. Unbreak the build Change-Id: Ie8bc5e41e8d5ae2b5ebf93c2380d651d99df10aa --- M CMakeLists.txt 1 file

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-14 Thread Sailesh Mukil (Code Review)
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#23). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-5592: Fix computation of uncompressed row batch size

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7434 Change subject: IMPALA-5592: Fix computation of uncompressed row batch size .. IMPALA-5592: Fix computation of uncompressed row batch

[Impala-ASF-CR] tmp: force static linking against ssl

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7432 Change subject: tmp: force static linking against ssl .. tmp: force static linking against ssl Change-Id:

[Impala-ASF-CR] [SECURITY] Enable MiniKdc and add kerberized BE tests

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7427 Change subject: [SECURITY] Enable MiniKdc and add kerberized BE tests .. [SECURITY] Enable MiniKdc and add kerberized BE tests This

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#6). Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This patch ports the data-flow parts of ImpalaInternalService to

[Impala-ASF-CR] Add two-way negotiation thread pools

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7430 Change subject: Add two-way negotiation thread pools .. Add two-way negotiation thread pools Change-Id:

[Impala-ASF-CR] IMPALA-5667: Race in DataStremSender could cause TransmitData sidecar corruption

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7436 Change subject: IMPALA-5667: Race in DataStremSender could cause TransmitData sidecar corruption .. IMPALA-5667: Race in

[Impala-ASF-CR] [SECURITY] Make KRPC work with Kerberos

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7426 Change subject: [SECURITY] Make KRPC work with Kerberos .. [SECURITY] Make KRPC work with Kerberos KuduRPC itself has experimental

[Impala-ASF-CR] Honor enable shared from this<> rule of sharing only pre-shared objects

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7433 Change subject: Honor enable_shared_from_this<> rule of sharing only pre-shared objects .. Honor enable_shared_from_this<> rule of

[Impala-ASF-CR] Disable Kerberos testing to unblock builds

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7429 Change subject: Disable Kerberos testing to unblock builds .. Disable Kerberos testing to unblock builds Change-Id:

[Impala-ASF-CR] IMPALA-4875: Bound maximum statestore topic update size to 2GB.

2017-07-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7425 Change subject: IMPALA-4875: Bound maximum statestore topic update size to 2GB. .. IMPALA-4875: Bound maximum statestore topic update

[Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries

2017-07-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7418/1/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/7400/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: Thanks, Tim. Yeah I'll do another pass. -- To view, visit

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 5: (3 comments) Looks good aside from some minor things. MJ, I'm ok if you want to +2

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#5). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#5). Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocations Currently TopN retains old string

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7400/3/be/src/exec/topn-node.h

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. IMPALA-4276: Profile displays non-default query options set by planner Fix to populate

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. IMPALA-4276: Profile displays non-default query options set by planner Fix to populate

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-14 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7419/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5659: Bump toolchain version

2017-07-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5659: Bump toolchain version .. Patch Set 1: This could be combined with https://gerrit.cloudera.org/#/c/7418/, but I wanted to get it committed early

[Impala-ASF-CR] IMPALA-5659: Bump toolchain version

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5659: Bump toolchain version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7422 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5659: Bump toolchain version

2017-07-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7422 Change subject: IMPALA-5659: Bump toolchain version .. IMPALA-5659: Bump toolchain version This bumps the toolchain version to include

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts The

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts The

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-14 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Yeah, I'll give it a go. > Do you think that's something you could add to this patch? -- To view,

[Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers

2017-07-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5627: fix dropped statuses in HDFS writers .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7372 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417: make I/O buffer queue fixed-size This removes the dynamically-varying queue size behaviour in the

[Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5627: fix dropped statuses in HDFS writers .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers

2017-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5627: fix dropped statuses in HDFS writers .. IMPALA-5627: fix dropped statuses in HDFS writers The change is mostly mechanical - added Status returns

[Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers

2017-07-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5627: fix dropped statuses in HDFS writers .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-14 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 4: Can you extend the Sort metrics in the query profile to include Avg, Min and Max run size? This will