[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#4). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. Patch Set 1: (10 comments)

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7955/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 11: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-5812: NPE when x joining on const select having an empty result

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5812: NPE when x joining on const select having an empty result .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7971/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 3: Passed the packaging build on multiple platforms. -- To view, visit

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. IMPALA-2810: Remove column stats restoration when altering table This patch

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7857 To

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: [PREVIEW] Use native allocation while building catalog updates .. [PREVIEW] Use native allocation while building catalog updates This patch moves the

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: [PREVIEW] Use native allocation while building catalog updates .. [PREVIEW] Use native allocation while building catalog updates This patch moves the

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5812: NPE when x joining on const select having an empty result

2017-09-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7971 Change subject: IMPALA-5812: NPE when x joining on const select having an empty result .. IMPALA-5812: NPE when x joining on const

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#11). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 10: (1 comment) Also rebased.

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. IMPALA-5885: free runtime filter allocations in Parquet This fixes the parquet

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7931 To

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. IMPALA-5210: Count rows and collection items in parquet scanner

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 9: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > > (1 comment) > > The tests in this change use only 3 query

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-2810: Remove column stats restoration when altering table .. IMPALA-2810: Remove column stats restoration when altering table This patch removes most code

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1197/

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-09-05 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: Need to get back to this now that I have smokes fixed. I imagine I'll want to do things a

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7857 To

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#10). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/runtime/query-state.cc

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: (17 comments)

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-05 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7963 Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. IMPALA-2107: [DOCS] Document base64*code() functions

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. IMPALA-5891: fix PeriodicCounterUpdater initialization Avoid running static

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7942 To

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 2: What's the next step on this one? -- To view, visit http://gerrit.cloudera.org:8080/7581 To

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 3: Code-Review+1 Carry of Dan's +1. -- To view, visit

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7886 to look at the new patch set (#3). Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: Thanks Alex and Tim. Yes, the peak memory usage shouldn't change with this

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash impala (boost exception)

2017-09-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash impala (boost exception) .. Patch Set 1: (13 comments)

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 5: Code-Review+2 rebased -- To view, visit http://gerrit.cloudera.org:8080/7931 To

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1195/ -- To

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: Alex explained to me that this doesn't actually increase the peak memory usage,

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7776 To

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7776 to look at the new patch set (#9). Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7870 To

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7949/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7949/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 8: (4 comments) lgtm after minor comment fixes

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7931/3/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG Commit Message: PS3, Line 22: 1. A

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: Code-Review+1 Carry +1 from Matt Jacobs. -- To view, visit

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#4). Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

[Impala-ASF-CR] IMPALA-2810: Remove column stats restoration when altering table

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2810: Remove column stats restoration when altering table .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 3: (3 comments)

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/1/be/src/catalog/catalog.cc

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1193/ -- To

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. IMPALA-5892: Allow reporting status independent of fragment instance Queries can hit an

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7931 to look at the new patch set (#4). Change subject: IMPALA-5885: free runtime filter allocations in Parquet ..

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: Please fix the typos before submitting -- To view,

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 2: Code-Review+1 Matt, please do the +2 when you don't have any

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7942 To unsubscribe,

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) The fact that we found 3 issues in this code (after IMPALA-3894) makes me nervous. I

[Impala-ASF-CR] IMPALA-5891: fix PeriodicCounterUpdater initialization

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization .. IMPALA-5891: fix PeriodicCounterUpdater initialization Avoid running static destructors and constructors

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/1/be/src/catalog/catalog.cc