[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-17 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#10). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-17 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 9: (5 comments)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 2: > (1 comment) I tried cherry-picking:

[Impala-ASF-CR] Add 'psmisc' to bootstrap system.sh.

2017-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8306 ) Change subject: Add 'psmisc' to bootstrap_system.sh. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8306

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8308 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8309 ) Change subject: IMPALA-5019: Decimal V2 addition .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5019: Decimal V2 addition

2017-10-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8309 Change subject: IMPALA-5019: Decimal V2 addition .. IMPALA-5019: Decimal V2 addition In this patch, we implement the new decimal

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8308 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8308 ) Change subject: Allow configuration of values passed into kerberos env vars .. Patch Set 1: > Uploaded patch set 1. This cherry-pick

[Impala-ASF-CR] Allow configuration of values passed into kerberos env vars

2017-10-17 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8308 to review the following change. Change subject: Allow configuration of values passed into kerberos env vars .. Allow

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src/service.

2017-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add 'psmisc' to bootstrap system.sh.

2017-10-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8306 Change subject: Add 'psmisc' to bootstrap_system.sh. .. Add 'psmisc' to bootstrap_system.sh. testdata/bin/kill-all.sh uses

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (10 comments)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src/service.

2017-10-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8305 Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. .. IMPALA-5599: Clean up references to

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/7079 ) Change subject: IMPALA-1575: Yield admission control resources at query end .. Abandoned Abandoning this patch since it's no longer up for

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 10: (27 comments)

[Impala-ASF-CR] Making bin/bootstrap system.sh executable.

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8292 ) Change subject: Making bin/bootstrap_system.sh executable. .. Making bin/bootstrap_system.sh executable. Script should

[Impala-ASF-CR] Making bin/bootstrap system.sh executable.

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8292 ) Change subject: Making bin/bootstrap_system.sh executable. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-10-17 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4236: Codegen CopyRows() for select nodes

2017-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for select nodes .. Patch Set 8: Code-Review+1 Will let Michael take another look.

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 6: Code-Review+2 Carrying over Tim's

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-17 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8233 to look at the new patch set (#5). Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

[Impala-ASF-CR] IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors

2017-10-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8294 Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

[Impala-ASF-CR] Making bin/bootstrap system.sh executable.

2017-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8292 ) Change subject: Making bin/bootstrap_system.sh executable. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.

2017-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays negative elapsed time. .. Patch Set 1: > (1 comment) But who is the caller of

[Impala-ASF-CR] IMPALA-5058: Improve concurrency of DDL/DML during catalog updates

2017-10-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has abandoned this change. ( http://gerrit.cloudera.org:8080/8266 ) Change subject: IMPALA-5058: Improve concurrency of DDL/DML during catalog updates .. Abandoned There are a number of serious issues