[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-11-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 3: (13 comments)

[Impala-ASF-CR] IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process

2017-11-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 14: Code-Review+2 Yes, I had another look at

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 17: Code-Review+2 Carrying Michael's

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#7). Change subject: IMPALA-6124: Fix alter table ddl updates and test

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#6). Change subject: IMPALA-6124: Fix alter table ddl updates and test

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 5: To make things consistent I removed the ddl updates

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#5). Change subject: IMPALA-6124: Fix alter table ddl updates and test

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#4). Change subject: IMPALA-6124: Fix alter table ddl updates and test

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 3: > (1 comment) > > The patch looks good to me, but

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-29 Thread Lars Volker (Code Review)
Lars Volker has removed a vote on this change. Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Removed Verified+1 by Lars Volker -- To view, visit http://gerrit.cloudera.org:8080/8411 To

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 3: Verified+1 The private S3 build passed. -- To view,

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl updates and test .. Patch Set 3: Running another private S3 build now. -- To view,

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-29 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#3). Change subject: IMPALA-6124: Fix alter table ddl updates and test .. IMPALA-6124:

[Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test

2017-10-29 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8411 to look at the new patch set (#2). Change subject: IMPALA-6124: Fix alter table ddl updates and test .. IMPALA-6124:

[Impala-ASF-CR] IMPALA-6124: Make assertion in ddl update test resilient to long runtime

2017-10-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Make assertion in ddl update test resilient to long runtime .. Patch Set 1: Verified-1 The test failed.

[Impala-ASF-CR] IMPALA-6124: Make assertion in ddl update test resilient to long runtime

2017-10-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 ) Change subject: IMPALA-6124: Make assertion in ddl update test resilient to long runtime .. Patch Set 1: I'm running a private S3 test

[Impala-ASF-CR] IMPALA-6124: Make assertion in ddl update test resilient to long runtime

2017-10-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8411 Change subject: IMPALA-6124: Make assertion in ddl update test resilient to long runtime .. IMPALA-6124: Make assertion in ddl update

[Impala-ASF-CR] IMPALA-6123: Fix column order of a query test in test inline view limit

2017-10-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8409 ) Change subject: IMPALA-6123: Fix column order of a query test in test_inline_view_limit .. Patch Set 2: Code-Review+2 I'll +2 this to

[Impala-ASF-CR] IMPALA-6123: Fix column order of a query test in test inline view limit

2017-10-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8409 ) Change subject: IMPALA-6123: Fix column order of a query test in test_inline_view_limit .. Patch Set 1: (1 comment)

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2017-10-25 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Abandoned IMPALA-5185 has been closed as Won't Fix. -- To view,

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2017-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Patch Set 3: Yes, thanks for the reminder. I'll push the

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 15: Code-Review+1 Thank you for the

[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning

2017-10-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8370 ) Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 11: (4 comments) One more questions, looks

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 10: (21 comments) Mostly minor stuff that I

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 8: (18 comments) Thank you for reworking

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-10-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (10 comments)

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Code-Review+2 Thanks for fixing this.

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. IMPALA-5983: Fix crash in

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 5: Code-Review+2 Carrying my +2 after

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-10-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8240 ) Change subject: IMPALA-6023: Fix broken breakpad test .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-10 Thread Lars Volker (Code Review)
Hello Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8240 to look at the new patch set (#4). Change subject: IMPALA-6023: Fix broken breakpad test ..

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 14: Code-Review+2 This has 4 +1's

[Impala-ASF-CR] IMPALA-6023: Fix broken breakpad test

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8240 Change subject: IMPALA-6023: Fix broken breakpad test .. IMPALA-6023: Fix broken breakpad test We have a test to make sure that hitting a

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures

2017-10-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: I lack context here, but I'll ask Thomas to have another

[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()

2017-10-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: Code-Review+2 This looks good to me. Zoltan should also

[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()

2017-10-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: > OK, looks like the those other *utc* names are not

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 10: I'd like to give Dan and Alex

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5994: Failure in star expansion on struct fields

2017-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8169 ) Change subject: IMPALA-5994: Failure in star expansion on struct fields .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5994: Failure in star expansion on struct fields

2017-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8169 ) Change subject: IMPALA-5994: Failure in star expansion on struct fields .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 1: Thanks for fixing this. Can you add

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

2017-09-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8117 ) Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 5: Code-Review+2 Rebased, carrying Tim's +2. -- To view, visit http://gerrit.cloudera.org:8080/8049 To

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8049/3/bin/clean.sh File bin/clean.sh: Line 33: pushd

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8049 to look at the new patch set (#4). Change subject: IMPALA-5927: Fix enable_distcc for zsh .. IMPALA-5927: Fix

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG Commit Message: Line 12: This change

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8049 to look at the new patch set (#3). Change subject: IMPALA-5927: Fix enable_distcc for zsh .. IMPALA-5927: Fix

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: (5 comments) I'm still trying to see if there are ways to simplify the

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5927: Fix enable_distcc for zsh .. IMPALA-5927: Fix enable_distcc for zsh enable_distcc didn't work on zsh anymore since it relies on automatic variable

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8049/1/bin/distcc/distcc_env.sh File

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 1: MJ, do you prefer one option with a comma separated list of key=value pairs,

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 6: (9 comments) Thank you for working on this. I left some comments inline.

[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"

2017-09-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Patch Set 2: > Lars, did you clarify this with Laurel? What to do with this > change? I

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 6: Is this ready for review? -- To view, visit

[Impala-ASF-CR] Increment version to 2.11.0-SNAPSHOT

2017-09-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Increment version to 2.11.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8080 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: Code-Review+1 Thanks for fixing this. LGTM, let's see what others say. -- To

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8050/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. Patch Set 3: Code-Review+2 Carrying Alex's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8050/2/be/src/service/child-query.cc

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8050 to look at the new patch set (#3). Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() ..

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8050/1/be/src/service/child-query.cc

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() ChildQuery::Cancel() prints a binary ID

[Impala-ASF-CR](asf-site) Update download and signature links for 2.10.0 release.

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Update download and signature links for 2.10.0 release. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8052 To unsubscribe,

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 1: As discussed via email, let's add tests after IMPALA-5664 has been fixed.

[Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/8050 Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel() .. IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/8049 Change subject: IMPALA-5927: Fix enable_distcc for zsh .. IMPALA-5927: Fix enable_distcc for zsh enable_distcc didn't work on zsh anymore

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (2 comments) Changed to INTERNAL_ERROR for the possible error in GetNextBuffer().

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#12). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#11). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: I fixed more test errors and will run an exhaustive build in parallel now. -- To view,

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#10). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

  1   2   3   4   5   6   7   8   9   >