Lars Volker has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7805/6/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: PS6, Line 137: }; : TestByteCaseSet(options, case_set_i64); : TestByteCaseSet(options, case_set_i32); : } : : // Test an enum testcase. May or may not accept integer : template<typename KeyType, typename EnumType> : void TestEnumCase(TQueryOptions& options, > Do you mean replacing the make_pair in L142 or replacing the make_tuple in See my reply below. Line 171: }); > I'm not sure how these are related. I think value-parameterized-tests is us I thought that every CASE would be a parameter value, stored as a struct, templatized if necessary. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
